From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5522EC433FE for ; Tue, 22 Nov 2022 02:00:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CCBF16B0071; Mon, 21 Nov 2022 21:00:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C7B2F6B0073; Mon, 21 Nov 2022 21:00:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B43366B0074; Mon, 21 Nov 2022 21:00:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A30AD6B0071 for ; Mon, 21 Nov 2022 21:00:43 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 71260AB586 for ; Tue, 22 Nov 2022 02:00:43 +0000 (UTC) X-FDA: 80159424366.06.ACB6C0B Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by imf02.hostedemail.com (Postfix) with ESMTP id EAB6A80006 for ; Tue, 22 Nov 2022 02:00:42 +0000 (UTC) Received: by mail-pl1-f182.google.com with SMTP id k7so12238342pll.6 for ; Mon, 21 Nov 2022 18:00:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2GgGmvs1Ahyu1NYakfF+wQ+EN1WPJgC73ojob9sWD98=; b=dsoyxVjsPJfZziaOkScC4QipgGCf6lVyEbE1SA654Cz0zY8WMRj6lwljMm+u6ZCsQO WRrTsQbqydqD8J5efIQlZ4gypoMnATwKKygGkpiPbP/JCY/LOZXUgVZfo8I8V6XnZ+Up Gb6OF+tlx/vNAV44rRH3EYtLQgIQNRRKdShs8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2GgGmvs1Ahyu1NYakfF+wQ+EN1WPJgC73ojob9sWD98=; b=wCjDPW+HBTzSZ9J98aLunycdM4leK8NLfEMecSXyuTyz3ZcMR5dAALSxi5UM0b9d5/ k7IIstmhyMvC1VCtsP9KOe37Nyksz7UZMZ4/JKLRiSyhMBjD7ZFYRDz89qbJcYJhS67n H0YNUj2VRJHM1yc8tAd3ziVdmi4o9xx6LxOMSyv9vzymHEcXJqzTKqCiq9upTa7o5FXp r8qLpQXgnR09C5E/ZvB08cKc5YqiE5b0E52cNM9eW4X+xZ+JgdxRO0d4Wc2vWGfs0xjU cM5Gxsl4e2n756p99u+2zRK/OkN/wEpJgreIBdqrCuDZ3Qic5sCf4HNS1cN3QqNDYR9W jxRQ== X-Gm-Message-State: ANoB5pnD5W+c392VbmYRoTWcR2B243QK4ifXZun0vyUXV3+U+TyBGrKZ OBe0yxdl8wd9ymRgfJnTEyJN0A== X-Google-Smtp-Source: AA0mqf6JDSNeMlNvF1qrQEZMqBsk4ekWK1mjYFEz9mL/IzY8wFaO4iJifcFUMt5P9r1RcbptHaucPQ== X-Received: by 2002:a17:90a:708a:b0:20a:eaab:137 with SMTP id g10-20020a17090a708a00b0020aeaab0137mr23591043pjk.206.1669082442001; Mon, 21 Nov 2022 18:00:42 -0800 (PST) Received: from google.com ([240f:75:7537:3187:e258:71ac:37b7:2d52]) by smtp.gmail.com with ESMTPSA id p67-20020a625b46000000b0056bd59eaef0sm9327024pfb.4.2022.11.21.18.00.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Nov 2022 18:00:41 -0800 (PST) Date: Tue, 22 Nov 2022 11:00:36 +0900 From: Sergey Senozhatsky To: Nhat Pham Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, minchan@kernel.org, ngupta@vflare.org, senozhatsky@chromium.org, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com Subject: Re: [PATCH v6 6/6] zsmalloc: Implement writeback mechanism for zsmalloc Message-ID: References: <20221119001536.2086599-1-nphamcs@gmail.com> <20221119001536.2086599-7-nphamcs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221119001536.2086599-7-nphamcs@gmail.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669082443; a=rsa-sha256; cv=none; b=mAW+foDMoL5UHnPx8jhxKyGEUdgzm5HXg3bDBluknsJw5UpVkDrOn0UzT0Fo73xq5VL9Iq LEiyoLxUrtABmNL2lzk7rx3Hkwsra0K9kMrQG8/PTp0BwwG4Wo72eK+Fjcxt6gu2MOPfe6 JzbYB+pOuyFLjp8CW2LGJoh4fEaU3Ic= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=dsoyxVjs; spf=pass (imf02.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.182 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669082443; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2GgGmvs1Ahyu1NYakfF+wQ+EN1WPJgC73ojob9sWD98=; b=b38hsFNQFBDkZCFdPpEqGwMMHgIXDPUPOLP9kB+Jnh4RRnS45N6BbyXxiqkCtQis6fYiI1 Ef2oyjrAk19gszHyRt6rU+KgkhPwdaNYf1QSfHoK8Exnz/jMnz61QwrIM7ldhCyZKBJdrp KqjoBoSYF1hzCg5LucBeThEOIvP4J4M= X-Stat-Signature: szxj7uu3paomfd6mroop1h6jg1fxkcda X-Rspamd-Queue-Id: EAB6A80006 X-Rspam-User: Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=dsoyxVjs; spf=pass (imf02.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.182 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Rspamd-Server: rspam02 X-HE-Tag: 1669082442-688270 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (22/11/18 16:15), Nhat Pham wrote: > +static int zs_reclaim_page(struct zs_pool *pool, unsigned int retries) > +{ > + int i, obj_idx, ret = 0; > + unsigned long handle; > + struct zspage *zspage; > + struct page *page; > + enum fullness_group fullness; > + > + /* Lock LRU and fullness list */ > + spin_lock(&pool->lock); > + if (list_empty(&pool->lru)) { > + spin_unlock(&pool->lock); > + return -EINVAL; > + } > + > + for (i = 0; i < retries; i++) { > + struct size_class *class; > + > + zspage = list_last_entry(&pool->lru, struct zspage, lru); > + list_del(&zspage->lru); > + > + /* zs_free may free objects, but not the zspage and handles */ > + zspage->under_reclaim = true; > + > + class = zspage_class(pool, zspage); > + fullness = get_fullness_group(class, zspage); > + > + /* Lock out object allocations and object compaction */ > + remove_zspage(class, zspage, fullness); > + > + spin_unlock(&pool->lock); > + > + /* Lock backing pages into place */ > + lock_zspage(zspage); > + > + obj_idx = 0; > + page = zspage->first_page; A nit: we usually call get_first_page() in such cases. > + while (1) { > + handle = find_alloced_obj(class, page, &obj_idx); > + if (!handle) { > + page = get_next_page(page); > + if (!page) > + break; > + obj_idx = 0; > + continue; > + } > + > + /* > + * This will write the object and call zs_free. > + * > + * zs_free will free the object, but the > + * under_reclaim flag prevents it from freeing > + * the zspage altogether. This is necessary so > + * that we can continue working with the > + * zspage potentially after the last object > + * has been freed. > + */ > + ret = pool->zpool_ops->evict(pool->zpool, handle); > + if (ret) > + goto next; > + > + obj_idx++; > + }