From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98445C4332F for ; Tue, 22 Nov 2022 02:15:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D5C0D6B0071; Mon, 21 Nov 2022 21:15:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CE6B86B0073; Mon, 21 Nov 2022 21:15:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B85EC6B0074; Mon, 21 Nov 2022 21:15:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A5D916B0071 for ; Mon, 21 Nov 2022 21:15:29 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6307D160DE9 for ; Tue, 22 Nov 2022 02:15:29 +0000 (UTC) X-FDA: 80159461578.30.B3A27BA Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf01.hostedemail.com (Postfix) with ESMTP id 53E7D40010 for ; Tue, 22 Nov 2022 02:15:27 +0000 (UTC) Received: by mail-pl1-f173.google.com with SMTP id io19so12268121plb.8 for ; Mon, 21 Nov 2022 18:15:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=HHM45P9CjRvHsVijXk9ZVHXwEbtAPy50ILNl92/joDY=; b=jxYZOik4RLpujktsjOabVQGOR90STmbik2Sw3PmAzG7UrmIsIbshf5YKYMkRELIVPi Lf5zywjY+WSlWInhXMYMRaf/FEytVnWz8iWVRPykEmxnnXEA9JgDdROrp4gzcmSV3OqT jQWw8koyVaYSEvJUYMeKmxztQI0gHA5bWZP6U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HHM45P9CjRvHsVijXk9ZVHXwEbtAPy50ILNl92/joDY=; b=lvLhvRna/1QXYp3oLdzvsXtiGI60Sb3u7unB+J1+qPrSwHDOMgKxlc39TRpu0igqjE +xq66bc3LiMgOJsXQQbafm9vfLjpWxExQQ495HY/Ng5epKrYaaH+SOB0g7jvHI39v021 G5m6idax0iXqrlwiNq/8IsfpywRjnEDF4XX07sV4FtY8dtbPmUUKrOxXv1odiITvKErn ISxJQV1r/NZdxgduR6BJCVXyLfe3jhJg7jKKgOYiC6R/deDcEU/OqbyQABPIFNBsDkj5 nHz6HLsoeAQNX33ymqdUBc1XUV5qdQzKdU/pysveGvJjbZeCdkzhk1DTCiLJBDNACJgc 2gKw== X-Gm-Message-State: ANoB5pmsIosLmG3BXxYiKTdwfEG3QNLTIIpOM6GgwT/5w16ZaDqmIeBN zvyUHUT9vgyZT/kb3r8GDr+oow== X-Google-Smtp-Source: AA0mqf4p4DPJ6pgUFsOKYSOfHBjYEjyAnzdS6CSrXvbaB71OjqhgxtMGeyfws+s/bd/s6BKaQ7eKFA== X-Received: by 2002:a17:90a:4ece:b0:218:7c55:47de with SMTP id v14-20020a17090a4ece00b002187c5547demr20774326pjl.172.1669083326192; Mon, 21 Nov 2022 18:15:26 -0800 (PST) Received: from google.com ([240f:75:7537:3187:e258:71ac:37b7:2d52]) by smtp.gmail.com with ESMTPSA id n1-20020a170902f60100b00186ac4b21cfsm10475812plg.230.2022.11.21.18.15.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Nov 2022 18:15:25 -0800 (PST) Date: Tue, 22 Nov 2022 11:15:20 +0900 From: Sergey Senozhatsky To: Nhat Pham Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, minchan@kernel.org, ngupta@vflare.org, senozhatsky@chromium.org, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com Subject: Re: [PATCH v6 6/6] zsmalloc: Implement writeback mechanism for zsmalloc Message-ID: References: <20221119001536.2086599-1-nphamcs@gmail.com> <20221119001536.2086599-7-nphamcs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221119001536.2086599-7-nphamcs@gmail.com> ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=jxYZOik4; spf=pass (imf01.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.173 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669083327; a=rsa-sha256; cv=none; b=einysgLap5V+VBjoG6hs8N033E60TDfVJPJKuEegWbWZBlSetRlWXKhbl8jVADXSXveLxS Jx1IxNJ0ErllpJlfyNUW3AqTxZh37Ivdzo8rNOR3o4D+dGSexqYA3e0lrgVY8BVrmzo2n/ NjelnHLqtZ636Tyvr2MxXNaj8xXLWs4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669083327; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HHM45P9CjRvHsVijXk9ZVHXwEbtAPy50ILNl92/joDY=; b=rDp1NdwcJr69dX3aFFojNXxVoJUXZC/ElGSd+szwUE3syKBhNYTWtEvefgEvEqjykLltKb qNlZyVXwieqRromYymUNDeBjX82rx+/e3lwVcxhTkrxyTMn2/QIFgTRW54mUKj8VSVH8pk t/h4gx/FDFRDVMFzntk2BfHySmmdwus= X-Stat-Signature: s4iaqqx51jck93ymrczr1xzedxxj9ja6 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 53E7D40010 Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=jxYZOik4; spf=pass (imf01.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.173 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Rspam-User: X-HE-Tag: 1669083327-945563 X-Bogosity: Ham, tests=bogofilter, spamicity=0.054128, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (22/11/18 16:15), Nhat Pham wrote: > + > +static int zs_zpool_shrink(void *pool, unsigned int pages, > + unsigned int *reclaimed) > +{ > + unsigned int total = 0; > + int ret = -EINVAL; > + > + while (total < pages) { > + ret = zs_reclaim_page(pool, 8); > + if (ret < 0) > + break; > + total++; > + } > + > + if (reclaimed) > + *reclaimed = total; > + > + return ret; > +} A silly question: why do we need a retry loop in zs_reclaim_page()?