From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A4AAC4321E for ; Mon, 5 Dec 2022 12:56:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C57208E0002; Mon, 5 Dec 2022 07:56:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C077E8E0001; Mon, 5 Dec 2022 07:56:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA7E78E0002; Mon, 5 Dec 2022 07:56:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9B6B78E0001 for ; Mon, 5 Dec 2022 07:56:35 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 67036A0763 for ; Mon, 5 Dec 2022 12:56:35 +0000 (UTC) X-FDA: 80208251550.27.3C835BB Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) by imf11.hostedemail.com (Postfix) with ESMTP id DC76940008 for ; Mon, 5 Dec 2022 12:56:34 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=LoM4ZvQs; spf=pass (imf11.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.170 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670244995; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MNizMxTAJQcCerVNPojMjVYQUThcKeI/6F+iAZVM61E=; b=K3LOP2TGwUumtFMh0V/Xo9rNnwqOZGIiuwvoUUlitHSKP/Mwu3MG/fVEC7zM9iQYxkwp9n tqDakef2Fja7C6JI20k5FI4mRw99MzdQyweDcPOTKY6f0wyCSnRU3EUU0DX1vgoMtIUK1i dsrQ8M122+jhSUYIbgzttglw4H7SPD8= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=LoM4ZvQs; spf=pass (imf11.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.170 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670244995; a=rsa-sha256; cv=none; b=6/vW7xdHuUqH4B0gU/gRwMJl2PyZ1+VVf4u7FdTxhy2NTik3EsG3Oy96PXbc9ntTAqRU3s IQFcjMozNTP3U15Xhh/fhFc+qTtOvGQ3x35hSDIyGosDMXhmOH3ohhCoL/+8uplHGAzvGo ejSLzXTDoP+AXuCn5UzobuNSdypMuf4= Received: by mail-lj1-f170.google.com with SMTP id l8so13385684ljh.13 for ; Mon, 05 Dec 2022 04:56:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=MNizMxTAJQcCerVNPojMjVYQUThcKeI/6F+iAZVM61E=; b=LoM4ZvQsmSIuu2v5/WOVXLHUPhjPjZKvAvKw7ppYq7FOFTyo8eFQ40euk6uUal8ca/ f4FcDS2k74EaENuC8SKrdfkO4r4zI94k6AANBExnMb/NGNbUc5Q/g3SmrZBM++rc2fRi Mvq/FgyW20b7S/QDS2u9mkIjfZhvwLX+GDHXtW1Dc/fDx/H/gJMe/qWedSoBDajI6OCa Iy1zXCVFUpz+u3JlTe5WYx5fjg8jDEg6jL7RBK/aZ8tfso/juT1/lWrf3m3F1uA/XWUD iUANfPIFLzASlDjKPtKEr/AwYdzMIBsl3l1xebHJfWzcKYdcxjqU5/8dmSHEGLXG/LI2 Bckw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MNizMxTAJQcCerVNPojMjVYQUThcKeI/6F+iAZVM61E=; b=QDRRv+I203en9RzvKJPi+8QtSvW5VJbmJ+z5zDPFvG7IdDZkh3ehVhrDq15XgwzfQB i/Nyi4Y/RUL9i1vy6WXYnlEn8A2GxvQHQJus4IQvIS8XaANLPmpl3ZguNaCyDa3rN08g ne4eYeeGsgy6K1JmA49Jfw3uayUVCmKSQpGm0Ki/MIrXRv7F/JNvpJPsGlGZM82zksna qCOeYN+V1ZOxnMEidBMV0foWExNO36whulvCz+EzjOkiXNVpKNsPwXZf8uDPn1D/k+/O 79iW1rVW4brtWlbWma6eYhoa5amgaWX7mtjX0ACSXT8wBqVEaRdH/q9O7fzctNOCM+Qs Nc7w== X-Gm-Message-State: ANoB5pk6J8Xl8rt5Wc+6gvpwi2C4Q0KPx1AD4OBMEbk3Pdotb6+OCb4o b4dyoH70Ueow12e8VnKM4oo= X-Google-Smtp-Source: AA0mqf6PmvS8jf6HU82mhQ98ZgGkGOidYsoFHSWwPdtJQpFz9zyG591eeD+XLTWGRozdUMVBjYZgdQ== X-Received: by 2002:a2e:a9a7:0:b0:26e:2de:49ad with SMTP id x39-20020a2ea9a7000000b0026e02de49admr21169013ljq.511.1670244992807; Mon, 05 Dec 2022 04:56:32 -0800 (PST) Received: from pc636 (host-90-235-25-230.mobileonline.telia.com. [90.235.25.230]) by smtp.gmail.com with ESMTPSA id s9-20020ac24649000000b004b5634f9b9dsm878455lfo.115.2022.12.05.04.56.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Dec 2022 04:56:32 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Mon, 5 Dec 2022 13:56:29 +0100 To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, stephen.s.brennan@oracle.com, urezki@gmail.com, willy@infradead.org, akpm@linux-foundation.org, hch@infradead.org Subject: Re: [PATCH v1 2/7] mm/vmalloc.c: add flags to mark vm_map_ram area Message-ID: References: <20221204013046.154960-1-bhe@redhat.com> <20221204013046.154960-3-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221204013046.154960-3-bhe@redhat.com> X-Rspamd-Queue-Id: DC76940008 X-Stat-Signature: ib145n6i71wosy7rq47zmxk75mcuz9wj X-Rspam-User: X-Spamd-Result: default: False [-1.40 / 9.00]; BAYES_HAM(-6.00)[99.99%]; SORBS_IRL_BL(3.00)[209.85.208.170:from]; SUBJECT_HAS_UNDERSCORES(1.00)[]; MID_RHS_NOT_FQDN(0.50)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_NO_TLS_LAST(0.10)[]; BAD_REP_POLICIES(0.10)[]; TO_DN_SOME(0.00)[]; R_DKIM_ALLOW(0.00)[gmail.com:s=20210112]; RCPT_COUNT_SEVEN(0.00)[8]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_ALLOW(0.00)[+ip4:209.85.128.0/17:c]; DMARC_POLICY_ALLOW(0.00)[gmail.com,none]; TO_MATCH_ENVRCPT_SOME(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[linux-mm@kvack.org]; DKIM_TRACE(0.00)[gmail.com:+]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; RCVD_COUNT_THREE(0.00)[3]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[] X-Rspamd-Server: rspam08 X-HE-Tag: 1670244994-246689 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > Through vmalloc API, a virtual kernel area is reserved for physical > address mapping. And vmap_area is used to track them, while vm_struct > is allocated to associate with the vmap_area to store more information > and passed out. > > However, area reserved via vm_map_ram() is an exception. It doesn't have > vm_struct to associate with vmap_area. And we can't recognize the > vmap_area with '->vm == NULL' as a vm_map_ram() area because the normal > freeing path will set va->vm = NULL before unmapping, please see > function remove_vm_area(). > > Meanwhile, there are two types of vm_map_ram area. One is the whole > vmap_area being reserved and mapped at one time; the other is the > whole vmap_area with VMAP_BLOCK_SIZE size being reserved, while mapped > into split regions with smaller size several times via vb_alloc(). > > To mark the area reserved through vm_map_ram(), add flags field into > struct vmap_area. Bit 0 indicates whether it's a vm_map_ram area, > while bit 1 indicates whether it's a vmap_block type of vm_map_ram > area. > > This is a preparatoin for later use. > > Signed-off-by: Baoquan He > --- > include/linux/vmalloc.h | 1 + > mm/vmalloc.c | 18 +++++++++++++++++- > 2 files changed, 18 insertions(+), 1 deletion(-) > > diff --git a/include/linux/vmalloc.h b/include/linux/vmalloc.h > index 096d48aa3437..69250efa03d1 100644 > --- a/include/linux/vmalloc.h > +++ b/include/linux/vmalloc.h > @@ -76,6 +76,7 @@ struct vmap_area { > unsigned long subtree_max_size; /* in "free" tree */ > struct vm_struct *vm; /* in "busy" tree */ > }; > + unsigned long flags; /* mark type of vm_map_ram area */ > }; > > /* archs that select HAVE_ARCH_HUGE_VMAP should override one or more of these */ > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 5d3fd3e6fe09..d6f376060d83 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -1815,6 +1815,7 @@ static void free_vmap_area_noflush(struct vmap_area *va) > > spin_lock(&vmap_area_lock); > unlink_va(va, &vmap_area_root); > + va->flags = 0; > spin_unlock(&vmap_area_lock); > This is not a good place to set flags to zero. It looks to me like corner and kind of specific. > nr_lazy = atomic_long_add_return((va->va_end - va->va_start) >> > @@ -1887,6 +1888,10 @@ struct vmap_area *find_vmap_area(unsigned long addr) > > #define VMAP_BLOCK_SIZE (VMAP_BBMAP_BITS * PAGE_SIZE) > > +#define VMAP_RAM 0x1 > +#define VMAP_BLOCK 0x2 > +#define VMAP_FLAGS_MASK 0x3 > + > struct vmap_block_queue { > spinlock_t lock; > struct list_head free; > @@ -1967,6 +1972,9 @@ static void *new_vmap_block(unsigned int order, gfp_t gfp_mask) > kfree(vb); > return ERR_CAST(va); > } > + spin_lock(&vmap_area_lock); > + va->flags = VMAP_RAM|VMAP_BLOCK; > + spin_unlock(&vmap_area_lock); > The per-cpu code was created as a fast per-cpu allocator because of high vmalloc lock contention. If possible we should avoid of locking of the vmap_area_lock. Because it has a high contention. > > vaddr = vmap_block_vaddr(va->va_start, 0); > spin_lock_init(&vb->lock); > @@ -2229,8 +2237,12 @@ void vm_unmap_ram(const void *mem, unsigned int count) > return; > } > > - va = find_vmap_area(addr); > + spin_lock(&vmap_area_lock); > + va = __find_vmap_area((unsigned long)addr, &vmap_area_root); > BUG_ON(!va); > + if (va) > + va->flags &= ~VMAP_RAM; > + spin_unlock(&vmap_area_lock); > debug_check_no_locks_freed((void *)va->va_start, > (va->va_end - va->va_start)); > free_unmap_vmap_area(va); > @@ -2269,6 +2281,10 @@ void *vm_map_ram(struct page **pages, unsigned int count, int node) > if (IS_ERR(va)) > return NULL; > > + spin_lock(&vmap_area_lock); > + va->flags = VMAP_RAM; > + spin_unlock(&vmap_area_lock); > + > Same here. -- Uladzislau Rezki