From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E4D1C4332F for ; Mon, 5 Dec 2022 15:44:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CC5BA8E0002; Mon, 5 Dec 2022 10:44:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C754A8E0001; Mon, 5 Dec 2022 10:44:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B16A78E0002; Mon, 5 Dec 2022 10:44:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A113B8E0001 for ; Mon, 5 Dec 2022 10:44:51 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4ECB61C60CF for ; Mon, 5 Dec 2022 15:44:51 +0000 (UTC) X-FDA: 80208675582.30.A5B24B7 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by imf15.hostedemail.com (Postfix) with ESMTP id E81C0A0002 for ; Mon, 5 Dec 2022 15:44:50 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=hSdrSzdO; spf=pass (imf15.hostedemail.com: domain of ilias.apalodimas@linaro.org designates 209.85.208.46 as permitted sender) smtp.mailfrom=ilias.apalodimas@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670255091; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tfKmzFIivR84aG/YhA8CfmmH6xgvFirRXWP7JuK1YUk=; b=ge4vnyJE6Fq8LZpmK8q/0fgFQcI06SjO9xfNPrOfsPQBxDs13eCfu5LNEurtVrrPm2Ttug BO1yg3nD8nnjeFm/d/xGHrn8+zpFTg8s6bmgudxD50h4LJ+m8F5cijwV5DCDXXPiFYsMpW 7NKcM5EcrHAGTKBp+ZQ5IGqw8xPfbK0= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=hSdrSzdO; spf=pass (imf15.hostedemail.com: domain of ilias.apalodimas@linaro.org designates 209.85.208.46 as permitted sender) smtp.mailfrom=ilias.apalodimas@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670255091; a=rsa-sha256; cv=none; b=Sw+T33t4XWHYaFmoxRSk8q119Z1vfGEDQV6K65tnARZVpF4bZmeeihkTwZ9VfPI74kJQZG gAibnxKg6YtHCLIXR8UH3X9R794OM2EEmtXHt7Z9CONVT1/pAk7bcCkCZz4EQIRo2r83dP dAlTXDnkZM5E+ZqpElf1M0E8Ro6W31M= Received: by mail-ed1-f46.google.com with SMTP id e13so16301630edj.7 for ; Mon, 05 Dec 2022 07:44:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=tfKmzFIivR84aG/YhA8CfmmH6xgvFirRXWP7JuK1YUk=; b=hSdrSzdOE8XumiTKevu/I2QmD9fnTqdEpFHE7Bhai9aUZc47b27E5de7lctXQ7Fcj3 9jQs2Lr8eQ+4Jm7YM9e0/FC7O26OeJGq848cC88gEvBgilLMOfF/3hYgw4PPSIPtrrdn flaTluZsylwF1L/KClqXYZAnMYdA7FsPx9DleDMgKsssWBuCDDoiwVdnjH/DJJMgnYS+ snJFEQ0Zb7xWJoyhP0ufhkMLSGdKwVTBKtRGBIAP34JmDPZKFeFmj+q4QvIfILulSBXp X9ZTENd+ZMDJKbRmY6gxyKzqayNA7ihrSWeZ+jlBP7gf4uDhJn1nmvRv/UkSRl6inZ7j PpMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tfKmzFIivR84aG/YhA8CfmmH6xgvFirRXWP7JuK1YUk=; b=hE5rKWNjGbLBihKSVDt0JLzgtaknPVpjkOjsfjXma7I5ptL2GsLgUgHhAxFldQegFd ROL+FiGPZbxVNWvDPdZ3gDMD8YGa6aeGQ8vJQ5SUah907QMkEKNN6M27G7PjwjBGz3Di X50yddRAxKwqb9m4pS6SVpDtCS2kIn80FC5ElFFBXtOL6QssbTEshuzP6ggiIOYPdtgb JpOR3FL8xF+qHxwzPeeA+MFZO5rX9Y5Y2ENGudvHteiBc/eJd7V39yxlrkialdepb8IF lC645CRLVQPu0QjjOO0oPUks+JLVyPiS83yhojSorBMnng7CbMhph2GSfOLf4LWUHrEd v2Vg== X-Gm-Message-State: ANoB5pklSMidNf3TCFmHUXRZvA5SmI/qFpyw4Hj/DmgKVhdcXUeUv/4K YFZU7GADtqvnFCkv2s0iNCCTFg== X-Google-Smtp-Source: AA0mqf7666734hzhIG2U/KjYgpyCj3PeIQsVAQsQWgZsDLq7p5iFn62D/zuoL/PagwGLpE4HJBpAkQ== X-Received: by 2002:a05:6402:4284:b0:461:8156:e0ca with SMTP id g4-20020a056402428400b004618156e0camr19351579edc.271.1670255089592; Mon, 05 Dec 2022 07:44:49 -0800 (PST) Received: from hera (ppp078087234022.access.hol.gr. [78.87.234.22]) by smtp.gmail.com with ESMTPSA id 10-20020a170906200a00b007ae243c3f05sm6221749ejo.189.2022.12.05.07.44.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Dec 2022 07:44:49 -0800 (PST) Date: Mon, 5 Dec 2022 17:44:46 +0200 From: Ilias Apalodimas To: Jesper Dangaard Brouer Cc: "Matthew Wilcox (Oracle)" , Jesper Dangaard Brouer , brouer@redhat.com, netdev@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 00/24] Split page pools from struct page Message-ID: References: <20221130220803.3657490-1-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: E81C0A0002 X-Stat-Signature: k9yr57rfwrxc7aec6jboo8y9miq9gksn X-Spamd-Result: default: False [3.60 / 9.00]; SORBS_IRL_BL(3.00)[209.85.208.46:from]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; BAD_REP_POLICIES(0.10)[]; BAYES_HAM(-0.00)[37.28%]; R_DKIM_ALLOW(0.00)[linaro.org:s=google]; R_SPF_ALLOW(0.00)[+ip4:209.85.128.0/17]; DMARC_POLICY_ALLOW(0.00)[linaro.org,none]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; DKIM_TRACE(0.00)[linaro.org:+]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[linux-mm@kvack.org]; RCPT_COUNT_FIVE(0.00)[6]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; RCVD_VIA_SMTP_AUTH(0.00)[] X-Rspam-User: X-HE-Tag: 1670255090-82906 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Jesper, On Mon, Dec 05, 2022 at 04:34:10PM +0100, Jesper Dangaard Brouer wrote: > > On 30/11/2022 23.07, Matthew Wilcox (Oracle) wrote: > > The MM subsystem is trying to reduce struct page to a single pointer. > > The first step towards that is splitting struct page by its individual > > users, as has already been done with folio and slab. This attempt chooses > > 'netmem' as a name, but I am not even slightly committed to that name, > > and will happily use another. > > I've not been able to come-up with a better name, so I'm okay with > 'netmem'. Others are of-cause free to bikesheet this ;-) Same here. But if anyone has a better name please shout. > > > There are some relatively significant reductions in kernel text > > size from these changes. I'm not qualified to judge how they > > might affect performance, but every call to put_page() includes > > a call to compound_head(), which is now rather more complex > > than it once was (at least in a distro config which enables > > CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP). > > > > I have a micro-benchmark [1][2], that I want to run on this patchset. > Reducing the asm code 'text' size is less likely to improve a > microbenchmark. The 100Gbit mlx5 driver uses page_pool, so perhaps I can > run a packet benchmark that can show the (expected) performance improvement. > > [1] https://github.com/netoptimizer/prototype-kernel/blob/master/kernel/lib/bench_page_pool_simple.c > [2] https://github.com/netoptimizer/prototype-kernel/blob/master/kernel/lib/bench_page_pool_cross_cpu.c > If you could give it a spin it would be great. I did apply the patchset and was running fine on my Arm box. I was about to run these tests, but then I remembered that this only works for x86. I don't have any cards supported by page pool around. > > I've only converted one user of the page_pool APIs to use the new netmem > > APIs, all the others continue to use the page based ones. > > > > I guess we/netdev-devels need to update the NIC drivers that uses page_pool. > [...] Regards /Ilias