From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A61F8C4332F for ; Mon, 5 Dec 2022 16:31:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DFEA88E0003; Mon, 5 Dec 2022 11:31:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DAECC8E0001; Mon, 5 Dec 2022 11:31:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C9DD18E0003; Mon, 5 Dec 2022 11:31:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BCD7A8E0001 for ; Mon, 5 Dec 2022 11:31:25 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7EA0680636 for ; Mon, 5 Dec 2022 16:31:25 +0000 (UTC) X-FDA: 80208792930.11.FA46665 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf29.hostedemail.com (Postfix) with ESMTP id 9BFFB120012 for ; Mon, 5 Dec 2022 16:31:23 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=vIU7rbD2; spf=none (imf29.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670257884; a=rsa-sha256; cv=none; b=U9Dr1b00J9KrzTqZDML95FinhMvl1+rJaBa1lz1hetQZmFFI9McN0eInzX2iduXDTD4j6c wJFm+Jlc4TOvO2ORWnLra2faa/vRdGzd3AdyJheVnH0Nm0ZJNBIraW8Q06nFdkKaVtY9Vp 4xqXMwuAsE2VZoOCaIMrdrkmeDIWu0Q= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=vIU7rbD2; spf=none (imf29.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670257884; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SGd7TXZdDfHrbb1WwiVgQv6yQ1EyRbidqpbDSF4IWfE=; b=dB0rz9gIKnh7EBP7mI29S7qtMQ0J6FoeLmlk88hYEcVyAgu9AVDlatU+mm3dmUYwK1osah 00DaTEH+i9jN4KiXWOD9FSFAL9Jhe3uzZ/RyAZyVIPSevEGvx98fkMG3owM/M9d9VmXzuu HGtHsDI8S2kz4f12c42sPkSvwmldxlI= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=SGd7TXZdDfHrbb1WwiVgQv6yQ1EyRbidqpbDSF4IWfE=; b=vIU7rbD2ffrSWFQprhISZrBpUU 65tdh4jTvUGRiHWmPAlG+U3BeTV9vam1i8Z4Nw0XtUxYdT131B0NceGDxZr2ckCsrVC/mW0xQlN5r 5KdA6Q1K2lVpykdu1+3Tyszq5KEgdrElpw2KGtY59m+wpQeM18oD9/baqv0R3QON7qiyPkLznM1a7 5URojQK7NgPV1/J/iaZXN5vUaGdr6/YmS1GPvsBjL8z5Ng7s21y2W+3Qms4xZeyRZGtjIc6+3p/hY 7mdNY7XEqxGrGwJbRRQZ5KcnmTjTtkiIesmieY9bkiyLAsEjf6thIUqmsfZMQ8vrO8eqsZkcEp3Bn zT6Dc8ug==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2ENA-003QtC-5c; Mon, 05 Dec 2022 16:31:16 +0000 Date: Mon, 5 Dec 2022 16:31:16 +0000 From: Matthew Wilcox To: Jesper Dangaard Brouer Cc: Jesper Dangaard Brouer , Ilias Apalodimas , brouer@redhat.com, netdev@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 00/24] Split page pools from struct page Message-ID: References: <20221130220803.3657490-1-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Spamd-Result: default: False [-0.21 / 9.00]; R_DKIM_ALLOW(-0.20)[infradead.org:s=casper.20170209]; MIME_GOOD(-0.10)[text/plain]; RCVD_NO_TLS_LAST(0.10)[]; BAYES_HAM(-0.01)[43.13%]; DKIM_TRACE(0.00)[infradead.org:+]; FROM_EQ_ENVFROM(0.00)[]; R_SPF_NA(0.00)[no SPF record]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROMTLD(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; FROM_HAS_DN(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_DN_SOME(0.00)[]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; DMARC_NA(0.00)[infradead.org]; ARC_NA(0.00)[] X-Rspamd-Queue-Id: 9BFFB120012 X-Rspamd-Server: rspam01 X-Stat-Signature: 1d865mikcb5xd1prhq5hsogpbtu61zbk X-HE-Tag: 1670257883-143816 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Dec 05, 2022 at 04:34:10PM +0100, Jesper Dangaard Brouer wrote: > I have a micro-benchmark [1][2], that I want to run on this patchset. > Reducing the asm code 'text' size is less likely to improve a > microbenchmark. The 100Gbit mlx5 driver uses page_pool, so perhaps I can > run a packet benchmark that can show the (expected) performance improvement. > > [1] https://github.com/netoptimizer/prototype-kernel/blob/master/kernel/lib/bench_page_pool_simple.c > [2] https://github.com/netoptimizer/prototype-kernel/blob/master/kernel/lib/bench_page_pool_cross_cpu.c Appreciate it! I'm not expecting any performance change outside noise, but things do surprise me. I'd appreciate it if you'd test with a "distro" config, ie enabling CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP so we show the most expensive case. > > I've only converted one user of the page_pool APIs to use the new netmem > > APIs, all the others continue to use the page based ones. > > > > I guess we/netdev-devels need to update the NIC drivers that uses page_pool. Oh, it's not a huge amount of work, and I don't mind doing it. I only did one in order to show the kinds of changes that are needed. I can do the mlx5 conversion now ...