From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 892BAC352A1 for ; Tue, 6 Dec 2022 15:22:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A4208E0002; Tue, 6 Dec 2022 10:22:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 253E68E0001; Tue, 6 Dec 2022 10:22:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 144B88E0002; Tue, 6 Dec 2022 10:22:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 082798E0001 for ; Tue, 6 Dec 2022 10:22:54 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id CB0FE120D41 for ; Tue, 6 Dec 2022 15:22:53 +0000 (UTC) X-FDA: 80212249026.16.B99BB6F Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf14.hostedemail.com (Postfix) with ESMTP id DD992100006 for ; Tue, 6 Dec 2022 15:22:52 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=AYjmlDG8; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670340173; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fTpI119qpAktFn4Vs6O2yNBbMwFml4YlPvJPmAmi3aQ=; b=vwQGNz0B3dDLBl4/NSzMFc8q4Z91ElLybPW/teHpp5T+dkHmRJpCJrqwS2Y6s+Kcrcufqw CKFKBwKN+2Rhs9tlPiGdPujSeFNmKoFRtIATqzUNJ9x6wO1EBzuWhFPDf/qnl0UGwtyv5L Ra7n21twxeFfke++rwhmfIWe9x0rVrg= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=AYjmlDG8; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670340173; a=rsa-sha256; cv=none; b=OKfuV+z372k//AssCd1LloGygLiceIa17PaS0tdKoekLe7IsXoGs56fO0ea09h+9x+OvEf khje0TcGoaCIDhk50XgWtODoclPbyEk6Ttx9CuZtf+LUDUe/nhA40x+viS5wv1tNvdzRow eh+fD/KLLIeIsOO0YgObDuKNuWikse0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=fTpI119qpAktFn4Vs6O2yNBbMwFml4YlPvJPmAmi3aQ=; b=AYjmlDG8052I3kahPR+g0qZmH2 +coxrBOeRY39OnxIO04C4VQrhUTCUOcoP5az3beBkRgr0QbUq6JvhuC3pr2MVq6xmpFPQbG9v/pd5 kSWuL8I01GNZ6W/SV4YKZUJCji1Cm3/ansK5NUk3o1CypnSTjl7re57SGJFaoA3VhuVJOUEE2kG/x OT4LbZAHluuSuXdMVrQeBrj2ZGPLyNploV30fzfK0x9jjWcK4eskqurrCYn98Qp3NMZCZ9gUyNEro Gs/ksxo6SVig7m8m6gftWQ+DOSVfp/G2uK5GaJBxLTXkDaHnbeIN/sjGAxODiRdUGEOykBim1EzOQ PVS+LRTA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2ZmZ-004YCv-Ak; Tue, 06 Dec 2022 15:22:55 +0000 Date: Tue, 6 Dec 2022 15:22:55 +0000 From: Matthew Wilcox To: Nhat Pham Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, bfoster@redhat.com, kernel-team@meta.com Subject: Re: [PATCH v2 2/4] workingset: refactor LRU refault to expose refault recency check Message-ID: References: <20221205175140.1543229-1-nphamcs@gmail.com> <20221205175140.1543229-3-nphamcs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221205175140.1543229-3-nphamcs@gmail.com> X-Stat-Signature: suahmr56nkepgyyh1ay1rish5cbttftz X-Rspam-User: X-Spamd-Result: default: False [-0.51 / 9.00]; BAYES_HAM(-0.31)[69.17%]; R_DKIM_ALLOW(-0.20)[infradead.org:s=casper.20170209]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_SEVEN(0.00)[7]; FROM_EQ_ENVFROM(0.00)[]; R_SPF_NA(0.00)[no SPF record]; MIME_TRACE(0.00)[0:+]; DKIM_TRACE(0.00)[infradead.org:+]; MID_RHS_MATCH_FROMTLD(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_DN_SOME(0.00)[]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; DMARC_NA(0.00)[infradead.org]; ARC_NA(0.00)[] X-Rspamd-Queue-Id: DD992100006 X-Rspamd-Server: rspam06 X-HE-Tag: 1670340172-136628 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Dec 05, 2022 at 09:51:38AM -0800, Nhat Pham wrote: > +static bool lru_gen_test_recent(void *shadow, bool file, int *memcgid, > + struct pglist_data **pgdat, unsigned long *token, bool *workingset) This line needs more than one tab indent. I tend to use two tabs, others try to line up the parameters with the opening '('. But one tab is too visually similar to the body of the function. > rcu_read_lock(); > > memcg = folio_memcg_rcu(folio); > + > + if (!lru_gen_test_recent(shadow, type, &memcg_id, &pgdat, &token, > + &workingset)) Similarly here. &workingset looks like it's part of the body of the if, not part of the function call. > + goto unlock; > + > if (memcg_id != mem_cgroup_id(memcg)) > goto unlock; >