From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5556CC43217 for ; Mon, 28 Nov 2022 13:19:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C314F6B0074; Mon, 28 Nov 2022 08:19:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BE2016B0075; Mon, 28 Nov 2022 08:19:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A83886B0078; Mon, 28 Nov 2022 08:19:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 99F766B0074 for ; Mon, 28 Nov 2022 08:19:29 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 42E42A8D33 for ; Mon, 28 Nov 2022 13:19:29 +0000 (UTC) X-FDA: 80182907658.19.BC24564 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by imf09.hostedemail.com (Postfix) with ESMTP id D9E22140016 for ; Mon, 28 Nov 2022 13:19:27 +0000 (UTC) Received: by mail-pf1-f179.google.com with SMTP id a16so10011963pfg.4 for ; Mon, 28 Nov 2022 05:19:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=l2I2ksH5hcxruZfreywgq7pidAV/0mu8zfYab9h+BkA=; b=XK6ygKE5iglL7w95u3VCz7wr6UE81S0x4emEPBh90kiX3Oe0gnMON+2O9Gof9M/x5C c7DqpaX9PjNk20fK+KfSHQZ2ew5WkcAOFNL/JF9aXyRXjN9dbk3e8XuyICtCmHrf7KIf CcuGRUvZYdicuSLp+eIVcW/7uMHHoDkk2rNpPOJnu5pi1qxiUyjG/o/OYdhHrF2x9W6L Yt0oxSPtKSPnElk+5W8pt8HcFMubgrSmClSCrn3D2GqqVUtcD3XtO+A/Fcb1THKTmUw/ gaWmPGLiHzlJRH4aho3sXXxwjtkSR6JTl0dnKc9/KDZb0ZkiZCKhO8ercLw+racUzrol ZHJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=l2I2ksH5hcxruZfreywgq7pidAV/0mu8zfYab9h+BkA=; b=K9bNYh8J+CR6GGddd3r3qev/ZzhnYqOVIEP3ZGM8dvWWlfE3/j4KImi7teJP7pZZgB QtvylNklQWFxIaEX4pKSV7dkQJ00nJHh7FWt7nzqHrGntGOLPhwmARyXSwF0jSatwd50 U2y4s7hAE2eZy546wW1OoQn9QwjKD64K5Os4rqgi49XZWglQc41rRxXbYvmJCdiLgz/s twVXFc85QGstHO7UoEfjNCfRjxvFZRlM8S0K220tay88wviUp8WIszhAoSoB5oUl0mlB CIdhL/x8hHfFxJwt5yHrwKr2JdSO9iaekylL8R2QISYlYqJRLfkKV4lrbkwgVVgRuAvz fyag== X-Gm-Message-State: ANoB5plOwX5fTuKxzO6Iq1afSB6feCMvx4LLPBxZ85/RIkjOKS+WY9Z7 Hz4b2kfmP++rMAOgVnzKsEMt+4kJaTUi/w== X-Google-Smtp-Source: AA0mqf7DLSfwoEsdbA4QuKrOJVQUkrv+NqyBy5ZIm19QUA5xWknOkU8q6icj7VOL6HxmLj3MK9recg== X-Received: by 2002:aa7:9388:0:b0:56d:4c7e:777a with SMTP id t8-20020aa79388000000b0056d4c7e777amr54006766pfe.0.1669641566562; Mon, 28 Nov 2022 05:19:26 -0800 (PST) Received: from hyeyoo ([114.29.91.56]) by smtp.gmail.com with ESMTPSA id t123-20020a625f81000000b005747b59fc54sm8271954pfb.172.2022.11.28.05.19.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Nov 2022 05:19:25 -0800 (PST) Date: Mon, 28 Nov 2022 22:19:19 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Vlastimil Babka Cc: Christoph Lameter , David Rientjes , Joonsoo Kim , Pekka Enberg , Roman Gushchin , Andrew Morton , Linus Torvalds , Matthew Wilcox , patches@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 11/12] mm, slub: don't aggressively inline with CONFIG_SLUB_TINY Message-ID: References: <20221121171202.22080-1-vbabka@suse.cz> <20221121171202.22080-12-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221121171202.22080-12-vbabka@suse.cz> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669641567; a=rsa-sha256; cv=none; b=E0pfWULzd5h225UHXwdtW48sAkzTOtKcbfXqlve5/GYLrrsJ6jtALd+TtZJBT2eEFlYccs GN7FOeStTQN3bPa9ceYgSVY8m47MGBNCQawm/B54YQ8h7Vv21qAzwnobFyQwqdbNmyar5n Fwfh2HC3GgWk18O8ZfDoIvGBf7ngACs= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=XK6ygKE5; spf=pass (imf09.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.210.179 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669641567; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=l2I2ksH5hcxruZfreywgq7pidAV/0mu8zfYab9h+BkA=; b=7tsKfdF+3mfgOkUd63xWGufhwDXETKgbh38LJuMCJBEtcFDCO9UCQmPog6RsPZny5FsAuk oyfDSc0FYmlrB6XCXSmjUtg0qxE8syKDiZAu6/OUExhknTnqy1/FnYklC7F0aj4/eGFQC0 ph19p8HjnXLrsNLUIsC5UPvWfQosYOI= X-Rspam-User: Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=XK6ygKE5; spf=pass (imf09.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.210.179 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: oootc8f1titmewxkbmpxcoymnruym4bk X-Rspamd-Queue-Id: D9E22140016 X-Rspamd-Server: rspam12 X-HE-Tag: 1669641567-767369 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 21, 2022 at 06:12:01PM +0100, Vlastimil Babka wrote: > SLUB fastpaths use __always_inline to avoid function calls. With > CONFIG_SLUB_TINY we would rather save the memory. Add a > __fastpath_inline macro that's __always_inline normally but empty with > CONFIG_SLUB_TINY. > > bloat-o-meter results on x86_64 mm/slub.o: > > add/remove: 3/1 grow/shrink: 1/8 up/down: 865/-1784 (-919) > Function old new delta > kmem_cache_free 20 281 +261 > slab_alloc_node.isra - 245 +245 > slab_free.constprop.isra - 231 +231 > __kmem_cache_alloc_lru.isra - 128 +128 > __kmem_cache_release 88 83 -5 > __kmem_cache_create 1446 1436 -10 > __kmem_cache_free 271 142 -129 > kmem_cache_alloc_node 330 127 -203 > kmem_cache_free_bulk.part 826 613 -213 > __kmem_cache_alloc_node 230 10 -220 > kmem_cache_alloc_lru 325 12 -313 > kmem_cache_alloc 325 10 -315 > kmem_cache_free.part 376 - -376 > Total: Before=26103, After=25184, chg -3.52% > > Signed-off-by: Vlastimil Babka > --- > mm/slub.c | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index 7f1cd702c3b4..d54466e76503 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -187,6 +187,12 @@ do { \ > #define USE_LOCKLESS_FAST_PATH() (false) > #endif > > +#ifndef CONFIG_SLUB_TINY > +#define __fastpath_inline __always_inline > +#else > +#define __fastpath_inline > +#endif > + > #ifdef CONFIG_SLUB_DEBUG > #ifdef CONFIG_SLUB_DEBUG_ON > DEFINE_STATIC_KEY_TRUE(slub_debug_enabled); > @@ -3386,7 +3392,7 @@ static __always_inline void maybe_wipe_obj_freeptr(struct kmem_cache *s, > * > * Otherwise we can simply pick the next object from the lockless free list. > */ > -static __always_inline void *slab_alloc_node(struct kmem_cache *s, struct list_lru *lru, > +static __fastpath_inline void *slab_alloc_node(struct kmem_cache *s, struct list_lru *lru, > gfp_t gfpflags, int node, unsigned long addr, size_t orig_size) > { > void *object; > @@ -3412,13 +3418,13 @@ static __always_inline void *slab_alloc_node(struct kmem_cache *s, struct list_l > return object; > } > > -static __always_inline void *slab_alloc(struct kmem_cache *s, struct list_lru *lru, > +static __fastpath_inline void *slab_alloc(struct kmem_cache *s, struct list_lru *lru, > gfp_t gfpflags, unsigned long addr, size_t orig_size) > { > return slab_alloc_node(s, lru, gfpflags, NUMA_NO_NODE, addr, orig_size); > } > > -static __always_inline > +static __fastpath_inline > void *__kmem_cache_alloc_lru(struct kmem_cache *s, struct list_lru *lru, > gfp_t gfpflags) > { > @@ -3733,7 +3739,7 @@ static void do_slab_free(struct kmem_cache *s, > } > #endif /* CONFIG_SLUB_TINY */ > > -static __always_inline void slab_free(struct kmem_cache *s, struct slab *slab, > +static __fastpath_inline void slab_free(struct kmem_cache *s, struct slab *slab, > void *head, void *tail, void **p, int cnt, > unsigned long addr) > { > -- > 2.38.1 Acked-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> -- Thanks, Hyeonggon