From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74244C433FE for ; Mon, 28 Nov 2022 13:06:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8426E6B0072; Mon, 28 Nov 2022 08:06:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F1EC6B0073; Mon, 28 Nov 2022 08:06:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6BAF66B0074; Mon, 28 Nov 2022 08:06:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5EC5D6B0072 for ; Mon, 28 Nov 2022 08:06:25 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2AD57160903 for ; Mon, 28 Nov 2022 13:06:25 +0000 (UTC) X-FDA: 80182874730.17.1984BA9 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by imf09.hostedemail.com (Postfix) with ESMTP id 9CB4E140036 for ; Mon, 28 Nov 2022 13:06:23 +0000 (UTC) Received: by mail-pl1-f177.google.com with SMTP id b21so10066721plc.9 for ; Mon, 28 Nov 2022 05:06:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=B3cwuU9wjQ8VbfKUTNnbiIt2B8/rOnQ22JV6mreBMhw=; b=cPT++xvoRpH851YV9eYArPjV+xqU7oPu2rsB24Yh0VaoiI41HRHpq0BuI5kjhwJxrw OaauRFOykeddywo17as5H5aSfdb3k+ZRK1/HrbhkNJGO6DOeJi2sT+a4VpqYybQDQKis LaIAQLPbv5qwbRMFzzXZCxlxYom4ld5FpVwTHDRB9Kty4D6cM0eXW5bmtRdcMDJj7GSF rw1hW/1qPQQAtN9TTWY17ci9C9wYfKL4g6BZxDPd42udY0AUwikvzlnMDm+UuQjqRGvf uauJd5YIf+vCWVArhUPl5uZt/S+Jx2OzwUCUT7cex60mtf6t3INwYhhhtEWW/CCtmeFX 1Hcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=B3cwuU9wjQ8VbfKUTNnbiIt2B8/rOnQ22JV6mreBMhw=; b=zDFlxlYnxRfhLku7NeyPJfFDH4VVsVy3L/Z1g8ZPnMHbrz0Rnll1eVLPXeaYSjmZsk Yu4zoFSl0FSR+KNCkovX6qGU6mC7I8JbAwY/yEg0OhCN875X/HiIPFMvuFZ9W8fQySuN zRdGEPMrxYZUtOA6kV9+KxRQ+jgzwCjtnW0rhJ9Y8DG0zhRTcxUbvEH6z5WcjlGQw3wc HhLmGQ+Gcn2Y/8CVD3KxCzJAA+y19DTYhjqQ38yl6d9Sam8H/XQivNY3XKGrsUfW6qXa SAM9deeLZt5WLtUUuKSON2iTInuTmdz45MZxsQudW9zY0xAMEqCw+A4rGQnR9x+tlnjG 0JTw== X-Gm-Message-State: ANoB5pmmupN7/jbFv1dHlseOqCDK0HcsfGN1viavHNLLXP21W3XMAwp2 MmHDPK3RA0ylCxvko5vXxEc= X-Google-Smtp-Source: AA0mqf4eYVs0SA4FTr5QWchx8Qk7YnD3lg4y6T/+aoiZj0IfOxBEayp7dPUotwd21M+rJErjpzG5NQ== X-Received: by 2002:a17:90a:7d0d:b0:1fa:b51d:8d83 with SMTP id g13-20020a17090a7d0d00b001fab51d8d83mr32931270pjl.169.1669640782164; Mon, 28 Nov 2022 05:06:22 -0800 (PST) Received: from hyeyoo ([114.29.91.56]) by smtp.gmail.com with ESMTPSA id w13-20020a170902e88d00b00183c67844aesm8889847plg.22.2022.11.28.05.06.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Nov 2022 05:06:21 -0800 (PST) Date: Mon, 28 Nov 2022 22:06:15 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Vlastimil Babka Cc: Christoph Lameter , David Rientjes , Joonsoo Kim , Pekka Enberg , Roman Gushchin , Andrew Morton , Linus Torvalds , Matthew Wilcox , patches@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 09/12] mm, slub: split out allocations from pre/post hooks Message-ID: References: <20221121171202.22080-1-vbabka@suse.cz> <20221121171202.22080-10-vbabka@suse.cz> <863dfdbb-2efc-a1d4-3cb1-3edaa67f67bd@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <863dfdbb-2efc-a1d4-3cb1-3edaa67f67bd@suse.cz> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669640783; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=B3cwuU9wjQ8VbfKUTNnbiIt2B8/rOnQ22JV6mreBMhw=; b=p1MEOoL19sS1wfSq1Oqqu5zsQENG3pmVfQNQsP9eFFi3VrZc/14TXGulqAhlR/nfFnQmMs IRyCM0z5RocVD1nk1hbIT0pOW4D11H9wgsSFauEpjCR16N+aYAF/wlZDNeSiA0IFoMJ7Wh FtEhT/OLvQ2CjsrccLrssYyUXIIRC40= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=cPT++xvo; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.177 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669640783; a=rsa-sha256; cv=none; b=XTtvdZL6IMf3Gbt5DkwVI04+g1tP/mUGgfCiwUQ6pg9FH7o7LFkKSM2mcEj5Iq3gs5Msnf advcmw0wXasicExIQpNRGzcf/7X2fZVEzDlhom/SR2FR+aU3imnPaDwKufEhdOVIF9P1PD mkOJPtAvnwxK/XcKMzWmdqZ9KDPwjWY= X-Rspam-User: Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=cPT++xvo; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.177 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com X-Stat-Signature: datfxkuut8ri98hzx6ai5quqhyxmgm4c X-Rspamd-Queue-Id: 9CB4E140036 X-Rspamd-Server: rspam08 X-HE-Tag: 1669640783-282633 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 28, 2022 at 12:01:39AM +0100, Vlastimil Babka wrote: > On 11/27/22 11:54, Hyeonggon Yoo wrote: > > On Mon, Nov 21, 2022 at 06:11:59PM +0100, Vlastimil Babka wrote: > >> In the following patch we want to introduce CONFIG_SLUB_TINY allocation > >> paths that don't use the percpu slab. To prepare, refactor the > >> allocation functions: > >> > >> Split out __slab_alloc_node() from slab_alloc_node() where the former > >> does the actual allocation and the latter calls the pre/post hooks. > >> > >> Analogically, split out __kmem_cache_alloc_bulk() from > >> kmem_cache_alloc_bulk(). > >> > >> Signed-off-by: Vlastimil Babka > >> --- > >> mm/slub.c | 127 +++++++++++++++++++++++++++++++++--------------------- > >> 1 file changed, 77 insertions(+), 50 deletions(-) > > > > [...] > > > >> + > >> +/* Note that interrupts must be enabled when calling this function. */ > >> +int kmem_cache_alloc_bulk(struct kmem_cache *s, gfp_t flags, size_t size, > >> + void **p) > >> +{ > >> + int i; > >> + struct obj_cgroup *objcg = NULL; > >> + > >> + /* memcg and kmem_cache debug support */ > >> + s = slab_pre_alloc_hook(s, NULL, &objcg, size, flags); > >> + if (unlikely(!s)) > >> + return false; > >> + > >> + i = __kmem_cache_alloc_bulk(s, flags, size, p, objcg); > >> + > >> + /* > >> + * memcg and kmem_cache debug support and memory initialization. > >> + * Done outside of the IRQ disabled fastpath loop. > >> + */ > >> + if (i != 0) > >> + slab_post_alloc_hook(s, objcg, flags, size, p, > >> + slab_want_init_on_alloc(flags, s)); > > > > This patch looks mostly good but wondering what happens if someone calls it with size == 0 > > so it does not call slab_post_alloc_hook()? > > Hmm looks like in that case we miss doing obj_cgroup_put(objcg) in > memcg_slab_post_alloc_hook(). Good catch, thanks! > > Fixing up, also a "return false" from int function > (existed also before this patch). > > ----8<---- > diff --git a/mm/slub.c b/mm/slub.c > index b74c4664160e..88f0ce49caab 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -3888,10 +3888,13 @@ int kmem_cache_alloc_bulk(struct kmem_cache *s, gfp_t flags, size_t size, > int i; > struct obj_cgroup *objcg = NULL; > > + if (!size) > + return 0; > + > /* memcg and kmem_cache debug support */ > s = slab_pre_alloc_hook(s, NULL, &objcg, size, flags); > if (unlikely(!s)) > - return false; > + return 0; > > i = __kmem_cache_alloc_bulk(s, flags, size, p, objcg); With that, Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> Thanks! -- Thanks, Hyeonggon