From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E002C433FE for ; Wed, 30 Nov 2022 16:32:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A138C6B0072; Wed, 30 Nov 2022 11:32:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C40F6B0073; Wed, 30 Nov 2022 11:32:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 88C5E6B0074; Wed, 30 Nov 2022 11:32:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7BCD76B0072 for ; Wed, 30 Nov 2022 11:32:50 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5D10640D0A for ; Wed, 30 Nov 2022 16:32:50 +0000 (UTC) X-FDA: 80190652500.11.4BFBD1D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id E8455C000E for ; Wed, 30 Nov 2022 16:32:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669825969; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cPcvPQVr4weLKAr6q7VaroYaObRW2ngmffd73YEX68o=; b=W66n2xYeFqzgrBbEfKETtjvxfk6KW1mZ5Vnqa+evvuLntpzlt1hEt+FDMAS7lt2f2va/VQ 2HuHnFnxjQyIeJqLYpn+IR5yx2wrYn0xaRVa3wjv6H/jpnXVGBqrcrMI3j5B9Wb5TONiAj 5MR9UEamtkf4cnIGqhUJnhUuRaYI4rE= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-154-jAmQI9QnP1ODJaz652SL3g-1; Wed, 30 Nov 2022 11:32:46 -0500 X-MC-Unique: jAmQI9QnP1ODJaz652SL3g-1 Received: by mail-qk1-f199.google.com with SMTP id h13-20020a05620a244d00b006fb713618b8so39473408qkn.0 for ; Wed, 30 Nov 2022 08:32:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cPcvPQVr4weLKAr6q7VaroYaObRW2ngmffd73YEX68o=; b=SMv7ViX82LnneSJsgvstgAZ/XiPB8BEZuuERaFDEHsykG6WwNTPV07g/60OzV5k+3C DnQIlje/rUGTMRX1p4UzDCTc/8GPPVDmqM5NiQlrxPyJJbdX3x0z6UWpm8Li66SAYCwu n0vjadBgfJUQ1dnGmnhEU7fXNA1vQGp84mGaguN0Ih4IlpN9YXp4Px+7vX3sE07JCfr5 08uJFJvEf8HOnIRzO7eIQgi8vIjklzvQmA36mr3Gb/rDI3Iba1wZpWXArTnP8NIJz4JM 55cCXWCtgefLcVAB4I/DDz5EFhUPnyhCJyDlQWuLnOYhWVLfw5TamrwAV3x7cON4A+iY PDVg== X-Gm-Message-State: ANoB5pkqD5ltaBT9BOfZuqqJGbBLSjrsEpKlhcYTExvv9yvaFHFa/x74 IxDwxsZiWuHS935CIQtP+UxvuEVKEEmFt7ByxZQClgQgqjXnzVaq/fzv1J5P0FpwKN5A1ltUWWY GQnHw7RW137A= X-Received: by 2002:ad4:57aa:0:b0:4c6:f83c:4741 with SMTP id g10-20020ad457aa000000b004c6f83c4741mr18462083qvx.11.1669825965619; Wed, 30 Nov 2022 08:32:45 -0800 (PST) X-Google-Smtp-Source: AA0mqf6OTDU7sg0vb7bB/qBN5gRbWQFZmztceG2kv0aCOtIr3ntCqKG4C9sJ/64sHha1ykbVVxPo0g== X-Received: by 2002:ad4:57aa:0:b0:4c6:f83c:4741 with SMTP id g10-20020ad457aa000000b004c6f83c4741mr18462056qvx.11.1669825965375; Wed, 30 Nov 2022 08:32:45 -0800 (PST) Received: from x1n (bras-base-aurron9127w-grc-46-70-31-27-79.dsl.bell.ca. [70.31.27.79]) by smtp.gmail.com with ESMTPSA id j30-20020ac84c9e000000b0039467aadeb8sm1082154qtv.13.2022.11.30.08.32.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Nov 2022 08:32:44 -0800 (PST) Date: Wed, 30 Nov 2022 11:32:43 -0500 From: Peter Xu To: David Hildenbrand Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, James Houghton , Jann Horn , Andrew Morton , Andrea Arcangeli , Rik van Riel , Nadav Amit , Miaohe Lin , Muchun Song , Mike Kravetz Subject: Re: [PATCH 09/10] mm/hugetlb: Make page_vma_mapped_walk() safe to pmd unshare Message-ID: References: <20221129193526.3588187-1-peterx@redhat.com> <20221129193526.3588187-10-peterx@redhat.com> <65a3a912-3534-6718-2c55-e0d4b5246f1e@redhat.com> MIME-Version: 1.0 In-Reply-To: <65a3a912-3534-6718-2c55-e0d4b5246f1e@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669825970; a=rsa-sha256; cv=none; b=h8N85v75lwc1PmrcLV59Dal1ftdYUMOgtj1HXUZ6jHGoe/qjtJm3ddRwZBGllu6eCniiSA 1CMqkSDIGITuz3FkZjNBoTKaHlhPWYQWYx2idNSJ3HyQn0m7X7tnyoL3HMWSZLFGUXUEKa mSHJ+P5Z1CqdzFYlLjlHEQsA7Q0Thpc= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=W66n2xYe; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669825970; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cPcvPQVr4weLKAr6q7VaroYaObRW2ngmffd73YEX68o=; b=K1mdXOR+t0Y6Rrgcr3CEWihzn9fuRJRVFXsdvcVa6R9rK9NeuRtAzvjNN7fF9ZsZQcgRB0 8AuToiKdNPRHYg9MaF5aslmMieCF0NU+0x+pgnjpuNk4ztM5QGxMotXuEkGM5I0tnMjfTA vT/HeXmDdovv8FcEi/V6Cu78unuOsgU= X-Rspamd-Queue-Id: E8455C000E Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=W66n2xYe; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com X-Rspamd-Server: rspam12 X-Rspam-User: X-Stat-Signature: yq4tiksuwkcoppwfa9h67wifizro6j1i X-HE-Tag: 1669825969-356687 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 30, 2022 at 05:18:45PM +0100, David Hildenbrand wrote: > On 29.11.22 20:35, Peter Xu wrote: > > Since page_vma_mapped_walk() walks the pgtable, it needs the vma lock > > to make sure the pgtable page will not be freed concurrently. > > > > Signed-off-by: Peter Xu > > --- > > include/linux/rmap.h | 4 ++++ > > mm/page_vma_mapped.c | 5 ++++- > > 2 files changed, 8 insertions(+), 1 deletion(-) > > > > diff --git a/include/linux/rmap.h b/include/linux/rmap.h > > index bd3504d11b15..a50d18bb86aa 100644 > > --- a/include/linux/rmap.h > > +++ b/include/linux/rmap.h > > @@ -13,6 +13,7 @@ > > #include > > #include > > #include > > +#include > > /* > > * The anon_vma heads a list of private "related" vmas, to scan if > > @@ -408,6 +409,9 @@ static inline void page_vma_mapped_walk_done(struct page_vma_mapped_walk *pvmw) > > pte_unmap(pvmw->pte); > > if (pvmw->ptl) > > spin_unlock(pvmw->ptl); > > + /* This needs to be after unlock of the spinlock */ > > + if (is_vm_hugetlb_page(pvmw->vma)) > > + hugetlb_vma_unlock_read(pvmw->vma); > > } > > bool page_vma_mapped_walk(struct page_vma_mapped_walk *pvmw); > > diff --git a/mm/page_vma_mapped.c b/mm/page_vma_mapped.c > > index 93e13fc17d3c..f94ec78b54ff 100644 > > --- a/mm/page_vma_mapped.c > > +++ b/mm/page_vma_mapped.c > > @@ -169,10 +169,13 @@ bool page_vma_mapped_walk(struct page_vma_mapped_walk *pvmw) > > if (pvmw->pte) > > return not_found(pvmw); > > + hugetlb_vma_lock_read(vma); > > /* when pud is not present, pte will be NULL */ > > pvmw->pte = huge_pte_offset(mm, pvmw->address, size); > > - if (!pvmw->pte) > > + if (!pvmw->pte) { > > + hugetlb_vma_unlock_read(vma); > > return false; > > + } > > pvmw->ptl = huge_pte_lock(hstate, mm, pvmw->pte); > > if (!check_pte(pvmw)) > > Looking at code like mm/damon/paddr.c:__damon_pa_mkold() and reading the > doc of page_vma_mapped_walk(), this might be broken. > > Can't we get page_vma_mapped_walk() called multiple times? Yes it normally can, but not for hugetlbfs? Feel free to check: if (unlikely(is_vm_hugetlb_page(vma))) { ... /* The only possible mapping was handled on last iteration */ if (pvmw->pte) return not_found(pvmw); } > Wouldn't we have to remember that we already took the lock to not lock > twice, and to see if we really have to unlock in > page_vma_mapped_walk_done() ? -- Peter Xu