From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BD94C4332F for ; Sat, 3 Dec 2022 08:58:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E7AB6B0072; Sat, 3 Dec 2022 03:58:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 596BB6B0073; Sat, 3 Dec 2022 03:58:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 437A16B0074; Sat, 3 Dec 2022 03:58:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 342416B0072 for ; Sat, 3 Dec 2022 03:58:14 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 09E8AC02D2 for ; Sat, 3 Dec 2022 08:58:14 +0000 (UTC) X-FDA: 80200393308.17.0079712 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by imf29.hostedemail.com (Postfix) with ESMTP id 9DB88120017 for ; Sat, 3 Dec 2022 08:58:13 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=TCH+a02E; spf=pass (imf29.hostedemail.com: domain of bagasdotme@gmail.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=bagasdotme@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670057893; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/sadz1/CeqA5zMnNYCqP/lEzSjdg/kLkwU3QYovJoVo=; b=n8okJfezCQ2JpyozApb64CEt4On0wMRTwMU17YG6yfi8/mw83rpFxHUMUz60P5t8jD8ds8 DFKW6cc+lRyKp/GjgW8mfCrZUXw6aMubwIlFiT/rkPZcGr3SBPg/S7U4uQzAvIT8NxPqdw rt+tolVJodNcq7MXYeRlOgnQcFyw/Y8= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=TCH+a02E; spf=pass (imf29.hostedemail.com: domain of bagasdotme@gmail.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=bagasdotme@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670057893; a=rsa-sha256; cv=none; b=KEaXHIGTle152m8tFFwn/dMFie3FIKrrTBXptRBVip+E2L4hU5YUFWSTty4rCzwj8PDwSF N7JElXFJXzxo8vyBbKcxzFz7c/CjH91WGycvwQobU8eWVvOqZD/u9Y+lnzLl0RlvwxeHU9 iMUtUnlM8qhcVlEFoW9Eo3e1HGIzzYA= Received: by mail-pl1-f169.google.com with SMTP id a9so6696846pld.7 for ; Sat, 03 Dec 2022 00:58:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/sadz1/CeqA5zMnNYCqP/lEzSjdg/kLkwU3QYovJoVo=; b=TCH+a02ERdRFnTf642Vs6jq9crhRaRo1PkxlU1yySN11VeAP+j9DkZ/e3z5G/uoeVs bOXCEs9OBEwem0ZKkvw6e6dmOY/iAHDTJqLxF//foTdrbbbqR/UqTJbNa45Rz86iZJ1R ZT98xw8b7fqFWyQM2gjHgoumxJpOwE6xg0CX0U7h3UN66Ti2+nvlttY14rX3zqCrb5B/ Cf6iz0g2o4R2gKRPU1i6PhbrO3LuOXeXc/ADnGNxfFw17De1vpwVriU4QVvjKk8Ne5Bq YwKibxAOf1SMhiAtO206DGehkxjJRZanOsHbiwQEds3kLa+H3Ti+2JKipcb0AVdMsR0E 75bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/sadz1/CeqA5zMnNYCqP/lEzSjdg/kLkwU3QYovJoVo=; b=VPCsjOGD8oFdmfpJYbS7B4sJRpRVPytw5KrZ8yC67taBcNXvp6bdJNNzdbv41qv3Yd vwAK8RfSDQsSO8151dH9g0A3T6A1L+lzOX6pSvHoOMcZr1Uzi8C+JBEEX0clIbaANPjD q7hEt+LVfZduD1Hwgg8hqYDtSnxKHiaH7beqeM/O8r4im+ShxaZjyGB0BiO6wAYeIWO2 oXIXule3DnB+C6WIayGl3YD+IMEU0uF5CQHCdfmlpFD1znPNfXIbNgCfBnz2GMQIeKrl 80cYjSQgfSeCnkA38K+x6/q/u/W2o2qbxSQuWumbRsgjhvDMoYSDdYUGTG4Wsw/v/lH2 1NKQ== X-Gm-Message-State: ANoB5pki3SuWT4BqemaeHHcTyQoB6gKNURaHvpQspGZpEihNvqfLv9cm BhY8qctG0ml0TKEdMJXSQEs= X-Google-Smtp-Source: AA0mqf557Tf4hQ3ox+4h4L3bKmykRUVeioIulyBl3fgPqFmNheBWGxzj30flo9/NXH+QYMoZKV/pzQ== X-Received: by 2002:a17:90a:a616:b0:219:6afd:24be with SMTP id c22-20020a17090aa61600b002196afd24bemr16172106pjq.0.1670057892468; Sat, 03 Dec 2022 00:58:12 -0800 (PST) Received: from debian.me (subs03-180-214-233-30.three.co.id. [180.214.233.30]) by smtp.gmail.com with ESMTPSA id o8-20020a17090a420800b0020a7d076bfesm5848220pjg.2.2022.12.03.00.58.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Dec 2022 00:58:11 -0800 (PST) Received: by debian.me (Postfix, from userid 1000) id 3CEE4104547; Sat, 3 Dec 2022 15:58:08 +0700 (WIB) Date: Sat, 3 Dec 2022 15:58:07 +0700 From: Bagas Sanjaya To: Rick Edgecombe Cc: x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , Weijiang Yang , "Kirill A . Shutemov" , John Allen , kcc@google.com, eranian@google.com, rppt@kernel.org, jamorris@linux.microsoft.com, dethoma@microsoft.com, akpm@linux-foundation.org, Andrew.Cooper3@citrix.com, christina.schimpe@intel.com, Yu-cheng Yu Subject: Re: [PATCH v4 01/39] Documentation/x86: Add CET shadow stack description Message-ID: References: <20221203003606.6838-1-rick.p.edgecombe@intel.com> <20221203003606.6838-2-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4Y6TcVcN9xovNDyq" Content-Disposition: inline In-Reply-To: <20221203003606.6838-2-rick.p.edgecombe@intel.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9DB88120017 X-Rspam-User: X-Stat-Signature: zekdg77i7fr5ztufdyxsctioe43zgyjg X-Spamd-Result: default: False [-1.82 / 9.00]; BAYES_HAM(-4.32)[95.97%]; SORBS_IRL_BL(3.00)[209.85.214.169:from]; SIGNED_PGP(-2.00)[]; SUSPICIOUS_RECIPS(1.50)[]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; BAD_REP_POLICIES(0.10)[]; RCVD_NO_TLS_LAST(0.10)[]; DKIM_TRACE(0.00)[gmail.com:+]; RCPT_COUNT_TWELVE(0.00)[40]; FROM_EQ_ENVFROM(0.00)[]; DMARC_POLICY_ALLOW(0.00)[gmail.com,none]; MIME_TRACE(0.00)[0:+,1:+,2:~]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; PREVIOUSLY_DELIVERED(0.00)[linux-mm@kvack.org]; R_DKIM_ALLOW(0.00)[gmail.com:s=20210112]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(0.00)[+ip4:209.85.128.0/17:c]; TO_DN_SOME(0.00)[]; TAGGED_RCPT(0.00)[]; ARC_NA(0.00)[] X-HE-Tag: 1670057893-586981 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --4Y6TcVcN9xovNDyq Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 02, 2022 at 04:35:28PM -0800, Rick Edgecombe wrote: > +An application's CET capability is marked in its ELF note and can be ver= ified > +from readelf/llvm-readelf output: > + > + readelf -n | grep -a SHSTK > + properties: x86 feature: SHSTK Shell commands should be inside literal code block (try double colon). Above is rendered as definition lists instead. > +The return values are as following: > + On success, return 0. On error, errno can be:: Drop indentation on the second line, or better yet, continue the line, like "... as following. On success, ..." Otherwise LGTM, thanks for review.=20 In any case, Reviewed-by: Bagas Sanjaya --=20 An old man doll... just what I always wanted! - Clara --4Y6TcVcN9xovNDyq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCY4sPlAAKCRD2uYlJVVFO oxZmAQCvIsfDFABxypzVEB2ZMvgJzikdcI86EKjquJjkppkMVgD+INIDFYBh7cJP AirZ9vPVfvl8ojgt9fx0uXFCNhiUvgA= =CHdF -----END PGP SIGNATURE----- --4Y6TcVcN9xovNDyq--