From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 332F2C4332F for ; Sat, 17 Dec 2022 12:07:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BFC9C8E0002; Sat, 17 Dec 2022 07:07:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BAC8B8E0001; Sat, 17 Dec 2022 07:07:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A75618E0002; Sat, 17 Dec 2022 07:07:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 96E608E0001 for ; Sat, 17 Dec 2022 07:07:31 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 57BCA120498 for ; Sat, 17 Dec 2022 12:07:31 +0000 (UTC) X-FDA: 80251673502.29.72899C2 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by imf03.hostedemail.com (Postfix) with ESMTP id A1EEA20014 for ; Sat, 17 Dec 2022 12:07:29 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Y8TtUr4w; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.221.46 as permitted sender) smtp.mailfrom=lstoakes@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671278849; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HpNFXXFL69ndIoEgbS5lBM2ElXTRVqEor6edUWSntXM=; b=XXCxKd1HqpC0URKarJVF9YqLiDkZHTQNKdvGF1wN2MAVIiUnqXkyUvfOO56UuSg+aL42iy N8yPV5o2+HFlXHTczXP7ny2/ZbeunbckfAl7/Ln4CmIB9NgFjkJnbHM7YtUkUjbvcVS+Zt GXkoM8+IhQmwifbOdONDKYzHS0ZY4uc= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Y8TtUr4w; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.221.46 as permitted sender) smtp.mailfrom=lstoakes@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671278849; a=rsa-sha256; cv=none; b=kQoGXaeRn1c9CibypfAaHPTIMx5WFiC6/A8IlB9EPoYLye26bbJZyh9VABQ+2mjqUKRH9v vOpgz2PIPQdmycU8D648/kLZVXi/kZhbH3KmGVxDO+DZxPCdoLcEWyNG/fpryF9ZUu+pBN etGT+Se6ns34UZwWWvOTXM9ctrmrN9I= Received: by mail-wr1-f46.google.com with SMTP id o5so4812026wrm.1 for ; Sat, 17 Dec 2022 04:07:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=HpNFXXFL69ndIoEgbS5lBM2ElXTRVqEor6edUWSntXM=; b=Y8TtUr4wFHKXkFj0immup8NKR0AwYJjBJ3BFuOxTrBlT+aVsVPaUa3nqnYVAmlklcz MGQV9UuzDByAGD670+r+Szf2jGPvGt9KJbJM9wSkrXRHfKhvK/kwr3IaJs9OukAZnbLg wlzqxDY2m9EkSZqVNrLNWQHSHxYnbsMATxWzvnpmoLfjq4h82xmkrNCRPfGidecNAYwO yzsJKFG63ZeSplFhgtyAWJiHWb9eQO6INsTQPbqu/xVSQj163/sWtxa0EP7MnL1+eMS2 dMkEKbnGadk9C7/PcnXur3L8TOfyF5xtg1EpdhAQxKKe8iva8KSvg0kShEI1YnrR9Elb keeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HpNFXXFL69ndIoEgbS5lBM2ElXTRVqEor6edUWSntXM=; b=64Pg6Fc/IjR1j9o8tkdEwEwYOc/x/+IIcX4W8ey+BNj88O21CoKn/XwzKRGvbcGblC pKsooELpK+7y4cqLn4wKxd/ibmBgkvdnlV/LwS8RqcMspdDXH0KuioSw1y/H1R0efaq1 FekCgAjiRimkfHaTReQO1Cb8WvzR1p0g5iPTTK6JHjBFvg57WXicJJiiihv7P+yY/Qe0 cYDIIWDdq1/psWMSs6fDpTnO4ZpSPJt8ZEpcvs+6buqceesm6hpfMylbIUId7W5mWWu7 IzkpuHkw/RqAXG8D0Cv5q1yBNDpZjn9iucAZH699zuTNskNvp8hNX9o+uxhX15XzzQsj bcLA== X-Gm-Message-State: ANoB5pnecuzw2EEKMXud7qoqZ24qZs7kZz+isP5E8zTBx5jBnsjyGta3 csBExNls65XTPo87FW946nQ= X-Google-Smtp-Source: AA0mqf5WcLYYg56e9RSOHdx8GzTZ8XCuimdDVsra1khNAyBHH8mhO3U7SUwxP3wQadIQHpNZuVGcYQ== X-Received: by 2002:a05:6000:1e02:b0:242:6aad:879e with SMTP id bj2-20020a0560001e0200b002426aad879emr24265849wrb.7.1671278848265; Sat, 17 Dec 2022 04:07:28 -0800 (PST) Received: from localhost ([2a00:23c5:dc8c:8701:1663:9a35:5a7b:1d76]) by smtp.gmail.com with ESMTPSA id y5-20020a056000108500b0023657e1b980sm4824492wrw.53.2022.12.17.04.07.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Dec 2022 04:07:27 -0800 (PST) Date: Sat, 17 Dec 2022 12:07:27 +0000 From: Lorenzo Stoakes To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, urezki@gmail.com, stephen.s.brennan@oracle.com, willy@infradead.org, akpm@linux-foundation.org, hch@infradead.org Subject: Re: [PATCH v2 5/7] mm/vmalloc: skip the uninitilized vmalloc areas Message-ID: References: <20221217015435.73889-1-bhe@redhat.com> <20221217015435.73889-6-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221217015435.73889-6-bhe@redhat.com> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: A1EEA20014 X-Stat-Signature: 4etfn9nmqc5zj6k9rd496ta1cofun7dq X-HE-Tag: 1671278849-620333 X-HE-Meta: U2FsdGVkX1/hyxHcaPu0odIDkx/uzxO2A0Omyu+R4Y1dPjDkJlfr/zNlxy7B5gpzfbZQwLXZa7gjNu9anmaL42rbaBTeJZrUgTfXP5CoRc6Ydd2Bv2SkuAUf1iFZEOD5APcvMtWMlRAKBDUfh1YlUMyAM2VqtzWtUbaWNI3iCp2UzlbnDwf0e6vB1Y5LwxuFvym1NZbT9ec1H2oT75ddKlD2wLzAp9GQ+glUc9sKAlEstnPzHiuc+XA6q/XwimkjEBNuNHZXWK7A5gDuHVzo7y6DCL/dZyK4akUiir6sITmf69sZ0kIV0aT/MFKPfC3tLIGYSNJa1NghoP004HmktoEFsBNZ1nKs95hLGOYUMU08Qec+xRUQFHfpdmAN8jMDMP+CihWb9iYPMOnQI60Tb6UNAaYzdyM3Xz7t1RYO3XhWqwT2FbZ45XMibJlllIqmSyH8dY35xJu2tjTn+uHNdM77qLG6d8IxvI7p+2XjCZrdlewICkBoH3yicZ/pHERAzr0O02sAHeKK74DA1ogFqsWxmAYAMN62bFLfv/uI0mhz0jgnGSEVhZTDcDm4yP+VE3IiE/63M248TrbpU+n9LZupSlA+JVSQLrh3qY8ExBj/7tQs3FIYKjltDSDrghd9eaID3HucXrcqm98Tvb5AYc6KG8fP5aWrX0OOGkl6thnRZDN0CpSZz7ZDPK2ZKmfZ2gLsp0QUcF/oRSw14rw2Xi2t0ckJwmlO3ETdkUqvdp5dXVH8k8u1mgq/VEpEv++krfUXHAfRMflZGPR2mSUQTjUzmvDtMxmXrCP//68AzAgst89+yUvM5qSNB86VBJnyFosskjrFnSryrcqKzts0K7RBxlgwRyxLs8QQ5FQitU75mavt+Ap7XAdikyA1xiyF2Vx3HZ+8ptR0CANi9N+QGHv+jGbUg+CEdLjtEwUYXWJzE/S0WrrBhW6VW++cId6UhpjvITKYnGoNQkQI4QS OWtLRuYW 2MuuUvGwqq5IOLjePx0tz95KfXQ/OGjWQQ5+wW1fJqpJEdCKyOO4sykU3uKjYxsNwLVlmNQPZad/Zw1m2vTSvlHatCg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.008870, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Dec 17, 2022 at 09:54:33AM +0800, Baoquan He wrote: > @@ -3617,6 +3617,11 @@ long vread(char *buf, char *addr, unsigned long count) > if (!vm && !flags) > continue; > > + if (vm->flags & VM_UNINITIALIZED) > + continue; This comes immediately after asserting that vm _might be null_. This surely must become:- if (vm && vm->flags & VM_UNINITIALIZED) continue;