diff for duplicates of <Y551tFBVcYxPlFlH@hyeyoo> diff --git a/a/1.txt b/N1/1.txt index 96a57ad..a665867 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,51 +1,57 @@ -On Sat, Dec 17, 2022 at 07:30:45PM +0800, gouhao@uniontech.com wrote: -> From: Gou Hao <gouhao@uniontech.com> +> On Sat, Dec 17, 2022 at 07:30:45PM +0800, gouhao@uniontech.com wrote: +> > From: Gou Hao <gouhao@uniontech.com> +> > +> > 'slab_early_init' was introduced by 'commit e0a42726794f +> > ("[PATCH] mm/slab.c: fix early init assumption")', this +> > flag was used to prevented off-slab caches being created > -> 'slab_early_init' was introduced by 'commit e0a42726794f -> ("[PATCH] mm/slab.c: fix early init assumption")', this -> flag was used to prevented off-slab caches being created +> s/prevented/prevent -s/prevented/prevent +Thanks for your review, i will fix it in next version patch. :) -> so early during bootup. +Thanks, +Gou Hao +> +> > so early during bootup. +> > +> > The only user of 'slab_early_init' was removed in commit +> > '3217fd9bdf00 ("mm/slab: make criteria for off slab +> > determination robust and simple")'. +> > +> > Signed-off-by: Gou Hao <gouhao@uniontech.com> +> > --- +> > mm/slab.c | 3 --- +> > 1 file changed, 3 deletions(-) +> > +> > diff --git a/mm/slab.c b/mm/slab.c +> > index 7a269db050ee..ede1f29fd81c 100644 +> > --- a/mm/slab.c +> > +++ b/mm/slab.c +> > @@ -220,7 +220,6 @@ static inline void fixup_objfreelist_debug(struct kmem_cache *cachep, +> > static inline void fixup_slab_list(struct kmem_cache *cachep, +> > struct kmem_cache_node *n, struct slab *slab, +> > void **list); +> > -static int slab_early_init = 1; +> > +> > #define INDEX_NODE kmalloc_index(sizeof(struct kmem_cache_node)) +> > +> > @@ -1249,8 +1248,6 @@ void __init kmem_cache_init(void) +> > slab_state = PARTIAL_NODE; +> > setup_kmalloc_cache_index_table(); +> > +> > - slab_early_init = 0; +> > - +> > /* 5) Replace the bootstrap kmem_cache_node */ +> > { +> > int nid; +> > -- +> > 2.20.1 > -> The only user of 'slab_early_init' was removed in commit -> '3217fd9bdf00 ("mm/slab: make criteria for off slab -> determination robust and simple")'. +> Nice cleanup, thanks! > -> Signed-off-by: Gou Hao <gouhao@uniontech.com> -> --- -> mm/slab.c | 3 --- -> 1 file changed, 3 deletions(-) +> Acked-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > -> diff --git a/mm/slab.c b/mm/slab.c -> index 7a269db050ee..ede1f29fd81c 100644 -> --- a/mm/slab.c -> +++ b/mm/slab.c -> @@ -220,7 +220,6 @@ static inline void fixup_objfreelist_debug(struct kmem_cache *cachep, -> static inline void fixup_slab_list(struct kmem_cache *cachep, -> struct kmem_cache_node *n, struct slab *slab, -> void **list); -> -static int slab_early_init = 1; -> -> #define INDEX_NODE kmalloc_index(sizeof(struct kmem_cache_node)) -> -> @@ -1249,8 +1248,6 @@ void __init kmem_cache_init(void) -> slab_state = PARTIAL_NODE; -> setup_kmalloc_cache_index_table(); -> -> - slab_early_init = 0; -> - -> /* 5) Replace the bootstrap kmem_cache_node */ -> { -> int nid; > -- -> 2.20.1 - -Nice cleanup, thanks! - -Acked-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> - --- -Thanks, -Hyeonggon +> Thanks, +> Hyeonggon +> diff --git a/a/content_digest b/N1/content_digest index db0f928..1c75118 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,73 +1,80 @@ "ref\020221217113045.15997-1-gouhao@uniontech.com\0" - "From\0Hyeonggon Yoo <42.hyeyoo@gmail.com>\0" + "From\0gouhao@uniontech.com\0" "Subject\0Re: [PATCH] mm/slab: remove unused slab_early_init\0" - "Date\0Sun, 18 Dec 2022 11:06:44 +0900\0" - "To\0gouhao@uniontech.com\0" - "Cc\0cl@linux.com" - penberg@kernel.org - rientjes@google.com + "Date\0Sun, 18 Dec 2022 20:21:24 +0800\0" + "To\042.hyeyoo@gmail.com\0" + "Cc\0akpm@linux-foundation.org" + cl@linux.com + gouhao@uniontech.com + gouhaojake@163.com iamjoonsoo.kim@lge.com - akpm@linux-foundation.org - vbabka@suse.cz - roman.gushchin@linux.dev keescook@chromium.org - linux-mm@kvack.org - linux-kernel@vger.kernel.org linux-hardening@vger.kernel.org + linux-kernel@vger.kernel.org + linux-mm@kvack.org mingo@elte.hu - " gouhaojake@163.com\0" + penberg@kernel.org + rientjes@google.com + roman.gushchin@linux.dev + " vbabka@suse.cz\0" "\00:1\0" "b\0" - "On Sat, Dec 17, 2022 at 07:30:45PM +0800, gouhao@uniontech.com wrote:\n" - "> From: Gou Hao <gouhao@uniontech.com>\n" + "> On Sat, Dec 17, 2022 at 07:30:45PM +0800, gouhao@uniontech.com wrote:\n" + "> > From: Gou Hao <gouhao@uniontech.com>\n" + "> > \n" + "> > 'slab_early_init' was introduced by 'commit e0a42726794f\n" + "> > (\"[PATCH] mm/slab.c: fix early init assumption\")', this\n" + "> > flag was used to prevented off-slab caches being created\n" "> \n" - "> 'slab_early_init' was introduced by 'commit e0a42726794f\n" - "> (\"[PATCH] mm/slab.c: fix early init assumption\")', this\n" - "> flag was used to prevented off-slab caches being created\n" + "> s/prevented/prevent\n" "\n" - "s/prevented/prevent\n" + "Thanks for your review, i will fix it in next version patch. :)\n" "\n" - "> so early during bootup.\n" + "Thanks,\n" + "Gou Hao\n" + "> \n" + "> > so early during bootup.\n" + "> > \n" + "> > The only user of 'slab_early_init' was removed in commit\n" + "> > '3217fd9bdf00 (\"mm/slab: make criteria for off slab\n" + "> > determination robust and simple\")'.\n" + "> > \n" + "> > Signed-off-by: Gou Hao <gouhao@uniontech.com>\n" + "> > ---\n" + "> > mm/slab.c | 3 ---\n" + "> > 1 file changed, 3 deletions(-)\n" + "> > \n" + "> > diff --git a/mm/slab.c b/mm/slab.c\n" + "> > index 7a269db050ee..ede1f29fd81c 100644\n" + "> > --- a/mm/slab.c\n" + "> > +++ b/mm/slab.c\n" + "> > @@ -220,7 +220,6 @@ static inline void fixup_objfreelist_debug(struct kmem_cache *cachep,\n" + "> > static inline void fixup_slab_list(struct kmem_cache *cachep,\n" + "> > \t\t\t\tstruct kmem_cache_node *n, struct slab *slab,\n" + "> > \t\t\t\tvoid **list);\n" + "> > -static int slab_early_init = 1;\n" + "> > \n" + "> > #define INDEX_NODE kmalloc_index(sizeof(struct kmem_cache_node))\n" + "> > \n" + "> > @@ -1249,8 +1248,6 @@ void __init kmem_cache_init(void)\n" + "> > \tslab_state = PARTIAL_NODE;\n" + "> > \tsetup_kmalloc_cache_index_table();\n" + "> > \n" + "> > -\tslab_early_init = 0;\n" + "> > -\n" + "> > \t/* 5) Replace the bootstrap kmem_cache_node */\n" + "> > \t{\n" + "> > \t\tint nid;\n" + "> > -- \n" + "> > 2.20.1\n" "> \n" - "> The only user of 'slab_early_init' was removed in commit\n" - "> '3217fd9bdf00 (\"mm/slab: make criteria for off slab\n" - "> determination robust and simple\")'.\n" + "> Nice cleanup, thanks!\n" "> \n" - "> Signed-off-by: Gou Hao <gouhao@uniontech.com>\n" - "> ---\n" - "> mm/slab.c | 3 ---\n" - "> 1 file changed, 3 deletions(-)\n" + "> Acked-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>\n" "> \n" - "> diff --git a/mm/slab.c b/mm/slab.c\n" - "> index 7a269db050ee..ede1f29fd81c 100644\n" - "> --- a/mm/slab.c\n" - "> +++ b/mm/slab.c\n" - "> @@ -220,7 +220,6 @@ static inline void fixup_objfreelist_debug(struct kmem_cache *cachep,\n" - "> static inline void fixup_slab_list(struct kmem_cache *cachep,\n" - "> \t\t\t\tstruct kmem_cache_node *n, struct slab *slab,\n" - "> \t\t\t\tvoid **list);\n" - "> -static int slab_early_init = 1;\n" - "> \n" - "> #define INDEX_NODE kmalloc_index(sizeof(struct kmem_cache_node))\n" - "> \n" - "> @@ -1249,8 +1248,6 @@ void __init kmem_cache_init(void)\n" - "> \tslab_state = PARTIAL_NODE;\n" - "> \tsetup_kmalloc_cache_index_table();\n" - "> \n" - "> -\tslab_early_init = 0;\n" - "> -\n" - "> \t/* 5) Replace the bootstrap kmem_cache_node */\n" - "> \t{\n" - "> \t\tint nid;\n" "> -- \n" - "> 2.20.1\n" - "\n" - "Nice cleanup, thanks!\n" - "\n" - "Acked-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>\n" - "\n" - "-- \n" - "Thanks,\n" - Hyeonggon + "> Thanks,\n" + "> Hyeonggon\n" + > -ae0e23c29229c2965420ba2357c22a12ffbfd56827aa2e5d5486a4124ea6a2dc +2aeba7e5aa5bf75053cff2b29cc5a8f646823aa0946333a423aa96132627b164
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox