From: Matthew Wilcox <willy@infradead.org>
To: "Vishal Moola (Oracle)" <vishal.moola@gmail.com>
Cc: linux-mm@kvack.org, damon@lists.linux.dev,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
sj@kernel.org
Subject: Re: [PATCH 3/3] swap: Convert deactivate_page() to deactivate_folio()
Date: Wed, 7 Dec 2022 16:18:31 +0000 [thread overview]
Message-ID: <Y5C814+q1QAtKvRW@casper.infradead.org> (raw)
In-Reply-To: <20221207002158.418789-4-vishal.moola@gmail.com>
On Tue, Dec 06, 2022 at 04:21:58PM -0800, Vishal Moola (Oracle) wrote:
> /*
> - * deactivate_page - deactivate a page
> - * @page: page to deactivate
> + * deactivate_folio - deactivate a folio
> + * @folio: folio to deactivate
> *
> - * deactivate_page() moves @page to the inactive list if @page was on the active
> - * list and was not an unevictable page. This is done to accelerate the reclaim
> - * of @page.
> + * deactivate_folio() moves @folio to the inactive list if @folio was on the
> + * active list and was not an unevictable page. This is done to accelerate
... and was not unevictable. This ...
> + * the reclaim of @folio.
> */
> -void deactivate_page(struct page *page)
> +void deactivate_folio(struct folio *folio)
> {
> - struct folio *folio = page_folio(page);
> -
> if (folio_test_lru(folio) && !folio_test_unevictable(folio) &&
> (folio_test_active(folio) || lru_gen_enabled())) {
> struct folio_batch *fbatch;
> --
> 2.38.1
>
>
prev parent reply other threads:[~2022-12-07 16:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 0:21 [PATCH 0/3] Convert deactivate_page() to deactivate_folio() Vishal Moola (Oracle)
2022-12-07 0:21 ` [PATCH 1/3] madvise: Convert madvise_cold_or_pageout_pte_range() to use folios Vishal Moola (Oracle)
2022-12-07 9:47 ` kernel test robot
2022-12-07 23:46 ` kernel test robot
2022-12-07 0:21 ` [PATCH 2/3] damon: Convert damon_pa_mark_accessed_or_deactivate() " Vishal Moola (Oracle)
2022-12-07 0:56 ` SeongJae Park
2022-12-07 1:04 ` SeongJae Park
2022-12-07 2:43 ` Vishal Moola
2022-12-07 0:21 ` [PATCH 3/3] swap: Convert deactivate_page() to deactivate_folio() Vishal Moola (Oracle)
2022-12-07 16:18 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5C814+q1QAtKvRW@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sj@kernel.org \
--cc=vishal.moola@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).