From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B640EC4708E for ; Wed, 7 Dec 2022 16:18:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DD4D48E0003; Wed, 7 Dec 2022 11:18:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D5BC78E0001; Wed, 7 Dec 2022 11:18:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BFC8C8E0003; Wed, 7 Dec 2022 11:18:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id AD9CB8E0001 for ; Wed, 7 Dec 2022 11:18:32 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7B2F6C08A1 for ; Wed, 7 Dec 2022 16:18:32 +0000 (UTC) X-FDA: 80216018064.01.06B63EB Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf16.hostedemail.com (Postfix) with ESMTP id 64DEF18000E for ; Wed, 7 Dec 2022 16:18:31 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=EUFd0ueI; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670429912; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CTE6dIt+WJ+vgyPZslBvBPKrvguQdijjejJhRQWzhfU=; b=JxLuP+RHtFL3YYkgA60E9ms7lAgsbyMPM63cWa7NDonxkKf3MTu0k/tc1x3kJzbVYW6prG FS1zz/MgddxEQzLZhpsWTnGTwM4ccQaA2fNnTnHgsPIpmVEMODQUW4BXv3UuVfe+hl0LT7 ZG56p7Kk+OUgwrAhGZw9+gvRpS0HrL4= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=EUFd0ueI; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670429912; a=rsa-sha256; cv=none; b=RO7RSUr7Nps3sRwyh9OjbHRlF+jtH1sXWbRwkOal+Uh7eRpRC03H7ZGX00lkgx1ouaurSP OmyyfT4HzEzsrtyNEd846Mwc4zOJD/iKo/gPN8M29DeuARA1iO/epa+0RElC5k7cDFlpJd ptV2P4Te2PuWahJMYxZbSU/U85NvdoA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=CTE6dIt+WJ+vgyPZslBvBPKrvguQdijjejJhRQWzhfU=; b=EUFd0ueIKCe4OzBKsVkD5N/fXz zwYytj69x7Hr59S7QSGQsQSA+T1HqUFvBOKCsad7up1f0y/tAYobcGbBquBO//IxTqDd8/83rbM5f oMJQil/xQa+zCfr+zoJGoo+TEtmcN0JfTEyDDo7ioFjPFKU6jvOQNHZcLzimZSyxjNGNHpvOrpmcB DS1gDSXEQdPNoyynfUmEsD9UJJQWkBkGEqJMa5EUwvkqr8sY12DkAtcVBU3Gsn8x3dvkpG00kSqYX euP/95Xn8boTEWKaeoJpazyT3dSNNcrqPwl195NolKfPR9FFTu8yoFzcGEwMvq8vq9cbrmaps1VBy 0j8HXGYA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2x7v-005z8C-WC; Wed, 07 Dec 2022 16:18:32 +0000 Date: Wed, 7 Dec 2022 16:18:31 +0000 From: Matthew Wilcox To: "Vishal Moola (Oracle)" Cc: linux-mm@kvack.org, damon@lists.linux.dev, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, sj@kernel.org Subject: Re: [PATCH 3/3] swap: Convert deactivate_page() to deactivate_folio() Message-ID: References: <20221207002158.418789-1-vishal.moola@gmail.com> <20221207002158.418789-4-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221207002158.418789-4-vishal.moola@gmail.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 64DEF18000E X-Stat-Signature: tngcooq74b4ofb31oi4mojx68x8fgzwp X-Spamd-Result: default: False [2.05 / 9.00]; SUSPICIOUS_RECIPS(1.50)[]; SUBJECT_HAS_UNDERSCORES(1.00)[]; BAYES_HAM(-0.25)[67.09%]; R_DKIM_ALLOW(-0.20)[infradead.org:s=casper.20170209]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; R_SPF_NA(0.00)[no SPF record]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; RCVD_COUNT_TWO(0.00)[2]; DKIM_TRACE(0.00)[infradead.org:+]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROMTLD(0.00)[]; TO_DN_SOME(0.00)[]; DMARC_NA(0.00)[infradead.org]; TAGGED_RCPT(0.00)[]; ARC_NA(0.00)[] X-Rspam-User: X-HE-Tag: 1670429911-945272 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 06, 2022 at 04:21:58PM -0800, Vishal Moola (Oracle) wrote: > /* > - * deactivate_page - deactivate a page > - * @page: page to deactivate > + * deactivate_folio - deactivate a folio > + * @folio: folio to deactivate > * > - * deactivate_page() moves @page to the inactive list if @page was on the active > - * list and was not an unevictable page. This is done to accelerate the reclaim > - * of @page. > + * deactivate_folio() moves @folio to the inactive list if @folio was on the > + * active list and was not an unevictable page. This is done to accelerate ... and was not unevictable. This ... > + * the reclaim of @folio. > */ > -void deactivate_page(struct page *page) > +void deactivate_folio(struct folio *folio) > { > - struct folio *folio = page_folio(page); > - > if (folio_test_lru(folio) && !folio_test_unevictable(folio) && > (folio_test_active(folio) || lru_gen_enabled())) { > struct folio_batch *fbatch; > -- > 2.38.1 > >