From: Michal Hocko <mhocko@suse.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Hugh Dickins <hughd@google.com>,
Shakeel Butt <shakeelb@google.com>,
linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] mm: push down lock_page_memcg()
Date: Wed, 7 Dec 2022 15:07:18 +0100 [thread overview]
Message-ID: <Y5CeFqlMrUyzZL2s@dhcp22.suse.cz> (raw)
In-Reply-To: <20221206171340.139790-1-hannes@cmpxchg.org>
On Tue 06-12-22 18:13:38, Johannes Weiner wrote:
> New series based on the discussion in the previous thread around
> getting lock_page_memcg() out of rmap.
>
> I beat on this with concurrent high-frequency moving of tasks that
> partially share a swapped out shmem file. I didn't spot anything
> problematic. That said, it is quite subtle, and Hugh, I'd feel better
> if you could also subject it to your torture suite ;)
For the whole series
Acked-by: Michal Hocko <mhocko@suse.com>
Thanks!
>
> Thanks!
>
> Against yesterday's mm-unstable.
>
> Documentation/admin-guide/cgroup-v1/memory.rst | 11 ++++-
> mm/memcontrol.c | 56 ++++++++++++++++++------
> mm/rmap.c | 26 ++++-------
> 3 files changed, 60 insertions(+), 33 deletions(-)
>
--
Michal Hocko
SUSE Labs
prev parent reply other threads:[~2022-12-07 14:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 17:13 [PATCH v2 0/3] mm: push down lock_page_memcg() Johannes Weiner
2022-12-06 17:13 ` [PATCH 1/3] mm: memcontrol: skip moving non-present pages that are mapped elsewhere Johannes Weiner
2022-12-07 1:51 ` Hugh Dickins
2022-12-08 0:36 ` Shakeel Butt
2022-12-06 17:13 ` [PATCH 2/3] mm: rmap: remove lock_page_memcg() Johannes Weiner
2022-12-07 1:52 ` Hugh Dickins
2022-12-08 0:36 ` Shakeel Butt
2022-12-06 17:13 ` [PATCH 3/3] mm: memcontrol: deprecate charge moving Johannes Weiner
2022-12-07 0:03 ` Shakeel Butt
2022-12-07 21:51 ` Andrew Morton
2022-12-07 22:15 ` Shakeel Butt
2022-12-07 1:58 ` Hugh Dickins
2022-12-07 13:00 ` Johannes Weiner
2022-12-07 14:07 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5CeFqlMrUyzZL2s@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shakeelb@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).