From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 041B0C63705 for ; Wed, 7 Dec 2022 14:07:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 621A58E0003; Wed, 7 Dec 2022 09:07:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A7F28E0001; Wed, 7 Dec 2022 09:07:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 449A98E0003; Wed, 7 Dec 2022 09:07:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 36D798E0001 for ; Wed, 7 Dec 2022 09:07:22 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0B5D58014D for ; Wed, 7 Dec 2022 14:07:22 +0000 (UTC) X-FDA: 80215687524.19.365A36C Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf11.hostedemail.com (Postfix) with ESMTP id 6D77340016 for ; Wed, 7 Dec 2022 14:07:20 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=Dzp6vahb; spf=pass (imf11.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670422040; a=rsa-sha256; cv=none; b=3dvX9darHLiFjrhW5rniVrCh0etB1tyKJ+rZ8EvSJlynd/JHB29Hfzk0/aLYDTJVf7Bfsr m5gMjRp7WOeo4fDl4nymMWReOaikBLPPQeXzc2QuMQmcmMZuDPN43yMhrjLpLJrWEKs0kf dgzduXmc1k3VbAPxrroA9Xph64NepaU= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=Dzp6vahb; spf=pass (imf11.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670422040; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tosjZfZODydjUbuqrfEIBGsRjeHYQJ8iIC4GtSX4HdI=; b=KlAJkgFmQyuJfBdV3cSdYl76w02J8Kb8bX2RbqBU/9TrrUVppURYxxEI/lSEGNczc1kKzT SEGKTavyHVPrbW82OieK/zrDin94z7OB5QTiUfSuJZ/bHUzNgApHFva8y1U7jbyp1o9MGC 5OFMjwcYU/6ihgQSuyIBK8f3h6a4cyI= Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id CDAC921D6F; Wed, 7 Dec 2022 14:07:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1670422038; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tosjZfZODydjUbuqrfEIBGsRjeHYQJ8iIC4GtSX4HdI=; b=Dzp6vahbk3af6y9m0wtHT4j/LM+TyWTrbJIuLUyzPAbc24XF/CBB1eIm3UDK4IGhqwI+mj YIpJgQTcYIhAkzTYqDboGt/kD5Qs0wi5JejZgTgYXEQGBipL0FKzPZWbIw15KxDOL4Pufn QLs/PPjzoH1pMZyBiKRFSJZzF1m3LC4= Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id AAAC6136B4; Wed, 7 Dec 2022 14:07:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id D00+JxaekGOvBwAAGKfGzw (envelope-from ); Wed, 07 Dec 2022 14:07:18 +0000 Date: Wed, 7 Dec 2022 15:07:18 +0100 From: Michal Hocko To: Johannes Weiner Cc: Andrew Morton , Linus Torvalds , Hugh Dickins , Shakeel Butt , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/3] mm: push down lock_page_memcg() Message-ID: References: <20221206171340.139790-1-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221206171340.139790-1-hannes@cmpxchg.org> X-Rspam-User: X-Spamd-Result: default: False [-4.48 / 9.00]; BAYES_HAM(-4.58)[96.67%]; SUBJECT_HAS_UNDERSCORES(1.00)[]; DMARC_POLICY_ALLOW(-0.50)[suse.com,quarantine]; R_SPF_ALLOW(-0.20)[+a:smtp-out1.suse.de]; R_DKIM_ALLOW(-0.20)[suse.com:s=susede1]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_SEVEN(0.00)[8]; FROM_EQ_ENVFROM(0.00)[]; DKIM_TRACE(0.00)[suse.com:+]; TO_MATCH_ENVRCPT_SOME(0.00)[]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[] X-Rspamd-Queue-Id: 6D77340016 X-Rspamd-Server: rspam01 X-Stat-Signature: q6841nfcwaa3k5kwyc3hzgcsrit5x36g X-HE-Tag: 1670422040-524442 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 06-12-22 18:13:38, Johannes Weiner wrote: > New series based on the discussion in the previous thread around > getting lock_page_memcg() out of rmap. > > I beat on this with concurrent high-frequency moving of tasks that > partially share a swapped out shmem file. I didn't spot anything > problematic. That said, it is quite subtle, and Hugh, I'd feel better > if you could also subject it to your torture suite ;) For the whole series Acked-by: Michal Hocko Thanks! > > Thanks! > > Against yesterday's mm-unstable. > > Documentation/admin-guide/cgroup-v1/memory.rst | 11 ++++- > mm/memcontrol.c | 56 ++++++++++++++++++------ > mm/rmap.c | 26 ++++------- > 3 files changed, 60 insertions(+), 33 deletions(-) > -- Michal Hocko SUSE Labs