From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 096DEC4708D for ; Wed, 7 Dec 2022 20:14:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 580E28E0003; Wed, 7 Dec 2022 15:14:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 509E98E0001; Wed, 7 Dec 2022 15:14:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 383648E0003; Wed, 7 Dec 2022 15:14:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 25FA28E0001 for ; Wed, 7 Dec 2022 15:14:29 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DCDE9140B74 for ; Wed, 7 Dec 2022 20:14:28 +0000 (UTC) X-FDA: 80216612616.23.6066A35 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 7BAA04000D for ; Wed, 7 Dec 2022 20:14:28 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QiRZMPBH; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670444068; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NwhTHbbeviWH0KrB78oH/LTS3J/aYRYFLjpGDACvYxQ=; b=SqaCkYLY0QaeKhuizqLijO5W+bjYgcafn+UL1oNYSrUvN1O6ABSsVsBiUYxnd4VBamt/Id cdVa3tTmfiryKqoQTTQSUWE0GLuSuoWw33CDcGWtv/7YdnRj9TTAMuJ1F0LWRfFK0YPEvH E2+kpX1ykm044DHfb4v/EGW06ZZsd6Q= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QiRZMPBH; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670444068; a=rsa-sha256; cv=none; b=1RaTngW85/dyGmw2Hd3wuMR6GAWB69IwjteIg7+6CO5KjVKeS2ZLk+/x89ULwA9Uj5Bw1C lIABnyFb6GXaZ1Ruk4XgTLOP/zmTryrCcwabmjrbjV70dmfRdNv0P0LTgR4hMiYSxHfNIu 46G/566szdxfDFWo+sgGQtGPiJa3YNY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670444068; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NwhTHbbeviWH0KrB78oH/LTS3J/aYRYFLjpGDACvYxQ=; b=QiRZMPBH8mOsljl5ROTXAD62aCzZRj2BFvUEJuGiuKDeJ50gfnPgqefCsV2Fjezvr47tHH ClMVivwU2VosePnF8LgjFs/vriMieTU3BNsfKTHbiRyyu4OO5Cyyn3F1k5te7Bl6snrxPs jkb6ZqnBtoGnTVTj3NeCj81oXQ2t/dI= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-411-ME1DC97HOWevOesJXdqhoQ-1; Wed, 07 Dec 2022 15:14:24 -0500 X-MC-Unique: ME1DC97HOWevOesJXdqhoQ-1 Received: by mail-qv1-f69.google.com with SMTP id m4-20020ad44484000000b004c78122b496so6497489qvt.7 for ; Wed, 07 Dec 2022 12:14:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NwhTHbbeviWH0KrB78oH/LTS3J/aYRYFLjpGDACvYxQ=; b=MGEwEtx5q9KGHFbJcOPhzUBBbE5IxeS2p+yQnvC/Gvgk/Cie0qlB7tBJuX2eT4kTCs UmUd0kGx/8pLpIPSnAODplSUnmTbh/AdUAewuUan17oVWWA+tc1afrVPeWYHgcZJr1PP cvfuS7OJ1jExlXoBVgjbZdtqBY0Wofep0XZrut014beh/79N05Kk9DLeENnHpDwFI9dH h7q0rR4iKR0JLcZZVzN4shi/gH/iqPp75fSdEPhe7vTHUj3VcsdOlz1aPjri4PCbp71g UvX4+8CdwJ2seFnooLzoWArrO4WzI2YunIlgpVjqcOC85qewi3P4Ye3FodIxLOsjvMDD dJIA== X-Gm-Message-State: ANoB5plz/v2z+u3tQrsKPwCsCbj5pM6bCtCDLsUmNSkle+DcdSzBAjGO k+711D3CoBF5sa1rv4jj5D7GF+NaHwK2DlKN0Psj3EXppWX6D61o1ps4lTfO4nfSVA+WTNgX3d8 hdO75bhqvyUI= X-Received: by 2002:a05:622a:418e:b0:3a6:50d6:9d83 with SMTP id cd14-20020a05622a418e00b003a650d69d83mr1603201qtb.65.1670444064223; Wed, 07 Dec 2022 12:14:24 -0800 (PST) X-Google-Smtp-Source: AA0mqf4SSNd44QhqnnNZ0i6AennrIOirgtTvrJFr6Mu7McdEgQfXGHu8jvVW9mOcJnUEYSAhNsEucw== X-Received: by 2002:a05:622a:418e:b0:3a6:50d6:9d83 with SMTP id cd14-20020a05622a418e00b003a650d69d83mr1603193qtb.65.1670444063944; Wed, 07 Dec 2022 12:14:23 -0800 (PST) Received: from x1n (bras-base-aurron9127w-grc-46-70-31-27-79.dsl.bell.ca. [70.31.27.79]) by smtp.gmail.com with ESMTPSA id x16-20020ac87a90000000b003a5fb681ae7sm13845182qtr.3.2022.12.07.12.14.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Dec 2022 12:14:23 -0800 (PST) Date: Wed, 7 Dec 2022 15:14:22 -0500 From: Peter Xu To: David Hildenbrand Cc: Hugh Dickins , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Ives van Hoorne , Andrew Morton , Alistair Popple , Mike Rapoport , Nadav Amit , Andrea Arcangeli Subject: Re: [PATCH RFC] mm/userfaultfd: enable writenotify while userfaultfd-wp is enabled for a VMA Message-ID: References: <690afe0f-c9a0-9631-b365-d11d98fdf56f@redhat.com> <19800718-9cb6-9355-da1c-c7961b01e922@redhat.com> <92173bad-caa3-6b43-9d1e-9a471fdbc184@redhat.com> <22d8e8ac-d75-a66-2650-b4d59f89855e@google.com> <37a9442e-f6e5-35f5-0d51-669d60936b5f@redhat.com> MIME-Version: 1.0 In-Reply-To: <37a9442e-f6e5-35f5-0d51-669d60936b5f@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 7BAA04000D X-Stat-Signature: 55amkcfwwqf4oox5yfuy1i4aado5ytdf X-Spamd-Result: default: False [5.10 / 9.00]; SORBS_IRL_BL(3.00)[209.85.219.69:received]; SUSPICIOUS_RECIPS(1.50)[]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; BAD_REP_POLICIES(0.10)[]; BAYES_HAM(-0.00)[31.85%]; DKIM_TRACE(0.00)[redhat.com:+]; RCPT_COUNT_SEVEN(0.00)[10]; FROM_EQ_ENVFROM(0.00)[]; DMARC_POLICY_ALLOW(0.00)[redhat.com,none]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; PREVIOUSLY_DELIVERED(0.00)[linux-mm@kvack.org]; R_DKIM_ALLOW(0.00)[redhat.com:s=mimecast20190719]; ARC_NA(0.00)[]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(0.00)[+ip4:170.10.129.0/24]; TO_DN_SOME(0.00)[]; TAGGED_RCPT(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[] X-HE-Tag: 1670444068-556811 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 07, 2022 at 08:53:36PM +0100, David Hildenbrand wrote: > Once user space successfully placed an uffd-wp marker, and e.g., verified > using pagemap that it is indeed placed, the system should not silently drop > it. Note that the anon path doesn't use pte markers. We won't lose a pte marker, hopefully, if we do that's a more severe one. > > The behavior between an ordinary THP and a huge zeropage differs. For THP, > we handle the split correctly and don't lose the marker. Assuming the huge > zeropage woud be disabled, the behavior would be (IMHO) correct. The test > case would pass. > > For example, QEMU with uffd-wp based snapshotting will make sure that all > virtual addresses are populated (e.g., mapping the shared, eventually the > huge zeropage -- populate_read_range()), before protecting using uffd-wp. > Losing a uffd-wp marker would be problematic. > > The good news is that we barely will end up PTE-mapping the huge zeropage > unless there is real user-space interaction (mprotect(), mremap(), mmap()), > so this shouldn't trigger in the QEMU use-case. Ah yes, I forgot that part. If it's not affected then it's better. > > > Anyhow, I'll send a patch in a couple of days and we can discuss further. > It's independent of the other discussion, just wanted to report my findings > after staring at that code for way too long today. Thanks, that works for me. -- Peter Xu