From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C785C4332F for ; Thu, 8 Dec 2022 20:22:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D79A38E0003; Thu, 8 Dec 2022 15:22:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D03998E0001; Thu, 8 Dec 2022 15:22:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA3598E0003; Thu, 8 Dec 2022 15:22:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A57C28E0001 for ; Thu, 8 Dec 2022 15:22:01 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8355C140E6E for ; Thu, 8 Dec 2022 20:22:01 +0000 (UTC) X-FDA: 80220260442.28.9D92215 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id A054E80016 for ; Thu, 8 Dec 2022 20:21:59 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AVCVWimQ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670530919; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mMLxZ2vEpcan9FP4JPPeH3ALepfz4tDO6+Vi7LEQRvk=; b=SCT/hEqHy2K75+Ynwaz4fpINxbwQ8GRns1bIzDrMm46sxaPIlxua9MqsihoryFC3dNIU96 NsbmT7NUqhPSMRgUpzLNQ6PiEwgf+ikIJshWMEM31a1vM84ZUhrUKJCTaaHb4VPOBpbdch eR1eRUMsGX5eRCDxUTC51NVYkHZ92YA= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AVCVWimQ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670530919; a=rsa-sha256; cv=none; b=hP9SxQqq0wXGmg2c8E7mxIo4LUoWGkcBJ2L78hnFhekxudgMMVKNF6Uut3Tpn8DOTwVpMJ 2XJS3RY3SeocdIwzUBMpx/OJoS/vfVd1WPVPQmfZB8/cIFBZ/WIHH3527UHl4dgYMXiya/ lD61+aEbal34tqUATOQ0I0AhEF2F184= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670530918; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mMLxZ2vEpcan9FP4JPPeH3ALepfz4tDO6+Vi7LEQRvk=; b=AVCVWimQqDfyq9Qj2pIRxFVHdtlnGuE5OpMClhbP5dWvHrrKKT87k6QtRs9+yoBuBn1drp pbOXjFCRbMC68v40Lw4E+WKqCoyQ/Lsoz1RnT13KZWF3wli0LXrEYW25yl/cou0QZhFCSY 5KECj4Ob4ZYMMrQA2rUHbby51WOrdyo= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-310-5IXhgJyVOdqvGjPSRUn1YA-1; Thu, 08 Dec 2022 15:21:57 -0500 X-MC-Unique: 5IXhgJyVOdqvGjPSRUn1YA-1 Received: by mail-qk1-f198.google.com with SMTP id h13-20020a05620a244d00b006fb713618b8so2736636qkn.0 for ; Thu, 08 Dec 2022 12:21:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mMLxZ2vEpcan9FP4JPPeH3ALepfz4tDO6+Vi7LEQRvk=; b=hwctP9sij9SoWoSloayXtEjiUBQyhnULKDa3HgrK2Z90TYe/WbdMxwUC8t0nVMFbVa cslcW3XcD7P8N2k3eJk+6njcT+7Pp0YGNzbkMSbaIueb3KCiyQR4Suc7sHhbegKPrT8P nQviPOr3gdz5GGx4RmdNY8CF/Q5XxT4b0OwA4bxNaC/ABQ2RuKcB/a76mwlV+XrKNhyT lRQb3qkyJJ3zavbfQSKIaECUWOiwLCqwT240fNOVpnVdq/aehF/UGsLSICFR5u2doxAH ilia/fIzqTr0lACxxIEkd+xpVSrCy8/RoWfPcN6jlO6DiDGCF95OdOYjcNAvCCe6GVVv WV+g== X-Gm-Message-State: ANoB5pntvwaWiTmQetHlh/Cmi2TxpQ3pAwbO90g31IzznyrsdbXc/jts GK8WZjispzUF5ucYIvdMxgq+GHMg6hEZFoxYi5KT4FRmcgbTdCzAUYNEFHJVdiErmG/fxClCZAr BR4RBi06Vn6w= X-Received: by 2002:ac8:774d:0:b0:3a5:7ab0:e1c4 with SMTP id g13-20020ac8774d000000b003a57ab0e1c4mr4517416qtu.35.1670530917389; Thu, 08 Dec 2022 12:21:57 -0800 (PST) X-Google-Smtp-Source: AA0mqf7k+qy/zHCSKcSSKL+b4cS9+x4HXGI/lH5oy++Dhi9P840spOv4KDspGKt5GTP4hJO3hvBySw== X-Received: by 2002:ac8:774d:0:b0:3a5:7ab0:e1c4 with SMTP id g13-20020ac8774d000000b003a57ab0e1c4mr4517397qtu.35.1670530917146; Thu, 08 Dec 2022 12:21:57 -0800 (PST) Received: from x1n (bras-base-aurron9127w-grc-46-70-31-27-79.dsl.bell.ca. [70.31.27.79]) by smtp.gmail.com with ESMTPSA id ga23-20020a05622a591700b003a526675c07sm16021164qtb.52.2022.12.08.12.21.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Dec 2022 12:21:56 -0800 (PST) Date: Thu, 8 Dec 2022 15:21:55 -0500 From: Peter Xu To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Ives van Hoorne , stable@vger.kernel.org, Andrew Morton , Hugh Dickins , Alistair Popple , Mike Rapoport , Nadav Amit , Andrea Arcangeli Subject: Re: [PATCH v1] mm/userfaultfd: enable writenotify while userfaultfd-wp is enabled for a VMA Message-ID: References: <20221208114137.35035-1-david@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: A054E80016 X-Stat-Signature: yq3qs3jw6diyxt1f9ek6pdpriyyg6jpd X-HE-Tag: 1670530919-74766 X-HE-Meta: U2FsdGVkX1/0aYUepmwsu79p8GYdWoPdkQ2yeBxKUPIV3RXpEf5zIdYD8rsm2jrAEnQD98Ca4ImEFh/80C2OUAKK4ZpEZyAGQoCNkBIecyvQqG+XfOmxS9wpuVMYTiJ2uZRkTUSSPaA1/102h2SMxXnUvJ3QVdi0J9XlCKVblwq/pvYPoH4LL+97qHkn01C6saPbD6DJKCmUNicqFgY6SrbGNOZMS/6CwBj0vQhZFlcxCCk2J0dJBYTF+xbPcz5fgAOT7EAAH5nDtswM+rBOm/h6XzUMv+zDbSLj6q03C4flRfstL0CRtuK7geGDqY2NdTtr2t/qLtG76vdOgsiNHqgMV/A6KtQPUSr8MImfk6A48IMLBzpDAqzZuKxNwBK7BUBBQ6Eb8vbfvTa2RIiXNRjIyUpW1ZtgY3AUTH+ued8jpHi4UbPz1S5tiqryonEehqCY2zu6MGO1spLdJ5f1FQXk8TdwGJ7iIJ9RPO7fg5DoWx5ZDPpNjEp4CvSODVhhDuo8QAOtisEfixB7bGZTfDBNm6dMH4pUKuLuI+sHKLCIUwNmx68/NwTn3acgNXa3Vf2A9s1s9UJFb7GuuvgcN3R9+p/SX3uE/rgdjx8tQ8ujy3gOMZG5oViIlWPNZbBsbWtvtM4lda1wXTYzAbFOBZ06VvtiIFLK/HeUiA0PaD8CZ0hU/Kz1F3gxUek+2uSh6TFCKS3NWvihIQgnwZBfS7lKoM9fZzq1IKFTWP4VyblmKMIibi3IpskhSd1O7Oqz+x3WeQ0ee9d54A/EJDa/+PnI7NLJZ0C4/2xJsHVmidZVNiO6lu3+34DxuCBpdyMhcfqeS1Zv6O/30ygp0vvXJXP231TCZR7kzCWWN2fbMhkA0C2Vg9M8Smkou7q5uRNqUCjEaFqizxRKlPXCNec9F/WS2Q3vVDEe2VNHcpxPeoHgn+5gz+u9fSmkP92oG2XwFXm+LncVtcB/OTBlD7i 5ZFHMhsl yGwmc4r4KZyOeLomir/C3+0xW70qVHW9Newuqon0lsZPFR2GD7YglZhGn/AlD5iIAoVdDn0cmWvXS4XR7R2fdiuRf02gScK0sRWq02hfkH9J5ddky9kyfwsZi2RKRLb5sj9v0y76FQhGR920gamJkuJsCtiLZWuR4VkvSZcwwOouo3EGEyAW2hCsuzQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Dec 08, 2022 at 03:06:06PM -0500, Peter Xu wrote: > On Thu, Dec 08, 2022 at 05:44:35PM +0100, David Hildenbrand wrote: > > I'll wait for some more (+retest) before I resend tomorrow. > > One more thing just to double check: > > It's 6a56ccbcf6c6 ("mm/autonuma: use can_change_(pte|pmd)_writable() to > replace savedwrite", 2022-11-30) that just started to break uffd-wp on > numa, am I right? > > With the old code, pte_modify() will persist uffd-wp bit, afaict, and we > used to do savedwrite for numa hints. That all look correct to me until > the savedwrite removal patchset with/without vm_page_prot changes. > > If that's the case, we'd better also mention that in the commit message and > has another Fixes: for that one to be clear. Nah, never mind. I think the savedwrite will not guarantee pte write protected just like the migration path. The commit message is correct. -- Peter Xu