From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A352C4332F for ; Thu, 8 Dec 2022 22:04:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B566D8E0007; Thu, 8 Dec 2022 17:04:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B07B98E0001; Thu, 8 Dec 2022 17:04:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9CE828E0007; Thu, 8 Dec 2022 17:04:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8DA1D8E0001 for ; Thu, 8 Dec 2022 17:04:44 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 64AEA1C684B for ; Thu, 8 Dec 2022 22:04:44 +0000 (UTC) X-FDA: 80220519288.28.1800572 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf12.hostedemail.com (Postfix) with ESMTP id 0C5ED40020 for ; Thu, 8 Dec 2022 22:04:40 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=MaowyLHm; spf=none (imf12.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670537082; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XHcJ8SFuAjHDaK1/sDcU1aP6FVHrSJrqK2PQkn+GzIA=; b=A51u0VASkw97iFnxBGkzDRLyGvw5sPKVUuHOMcYcUDdMK3GvmCjPXGhfkhOeXknz0LgaQc 07WAX0I3QtdfXNmZQZgxB76aM+FoMjgdNeCd+87ZaB9Rk9lKHnje+jcB7k79zmyb0cbRQI WICjW5tdoY6fbbryBlUIXCU8kSKzUiI= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=MaowyLHm; spf=none (imf12.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670537082; a=rsa-sha256; cv=none; b=Vu5Xc0vw0kXOwoUkAmqFK9Xd8jAbe5m4QdBh2cxCbf0u16wcLw8onmgc7yKB1/GP8srRyT 795DTX9D28FcEVtXa2BfRNpYMHP0LDmqybxiRkyAnz/vL+n7KDGX05tWP+4jiUW4fO8E4d 7xGFtQ7tUO7m6C60C7/CoUF1wfuNc1s= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=XHcJ8SFuAjHDaK1/sDcU1aP6FVHrSJrqK2PQkn+GzIA=; b=MaowyLHmWPQgkqBIN5HOcX+TId fnlYME6a45ZhMgxqrMWAn0NBXQL3Svo8/I8Oyd39Dy6Pq2xJiesE6aQVKwCM/PayQOO1foS2o33Yn nai5Vm3LF4vGAje6Zo5qVDNe+RDgZSeyAahV8zfKMw5TiR57my0xt7CfgATEi/zY+8jC3nn0v+uFZ d/EU4aCIfYafA3lMQxYu4iFvI9LPThGMV2Yz4i0gIJwHRtwJJxFpOKkglfHQnzMm6fOGNuPqdolt2 p8sKfGq4dQXO4xDTiOenReWBMPnD8n4jE5uCTgaV9hzcVtxT2rPloeYBBf/VSyvzFVxh+kPHP5ooZ bOzc+IVA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1p3P0S-007NAH-4g; Thu, 08 Dec 2022 22:04:40 +0000 Date: Thu, 8 Dec 2022 22:04:40 +0000 From: Matthew Wilcox To: Sidhartha Kumar Cc: Mike Kravetz , John Hubbard , linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, songmuchun@bytedance.com, tsahu@linux.ibm.com, david@redhat.com Subject: Re: [PATCH mm-unstable] mm: clarify folio_set_compound_order() zero support Message-ID: References: <20221207223731.32784-1-sidhartha.kumar@oracle.com> <92965844-c430-8b8e-d9f1-705d7578bceb@nvidia.com> <0187f9c2-e80a-9cde-68bc-c9bdbd96b6fe@oracle.com> <2723541a-79aa-c6b5-d82c-53db76b78145@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2723541a-79aa-c6b5-d82c-53db76b78145@oracle.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 0C5ED40020 X-Rspam-User: X-Stat-Signature: eu1fz19dyeuyzswsdijdeatfscti88kx X-HE-Tag: 1670537080-928858 X-HE-Meta: U2FsdGVkX19QiTuU3d3pqNpaAhXM5o5eXz4di+MDo6AGpszHEwK9WjQ8g1CxzLpunzF+8qTwtPBRGDcOuVhac5Z6BvJSqrTlk1W2Yhspku7fZTrdZFGMnmcVofj7EWgCD2ONtaW0V2M38sDTprOEVGhyNTv1XuX5nlWmYZJ2lf3hUH9HRo1g32MGHVDS64H8K2EB+rN4zod1jAtEB0cFGkji0C5rCLvxS6UaCclmvb5SHnHKOvBIjOXz6k5K9lqG2dOq4BOeRwySyOqPHlYC8Be3CD1cvzoSwNEG7ixylh1TGLItYP3EqtJVEDvczf4wBH7E9Z/i+ciFt9YEIkTYYLkw3Okv/DirqYjAJMqPXqv/T5SUpwDo9mefRPsTgMSIef2ca2/WidJnWHxA+DvzsZK5d5Up1e++sBNMMwWDltBFumwwSwzAF6mGN3FsSfY5xG/YAiytw8iN7kOYkaOdaSsot1NF1WaP6WUBZBDky+miPzmIyM1vkHPBT8oe26b3zZsCFo/+80vSp1vkxNLOCsQDGCoFgLbAI+phXMeRER0VPAiJqafjJYKHiimojEF2D1hDoMjC10qYknRqymx2prMrVQ8mKecb5YJxAm8iM8yk3ZMGG74NUQP/J42G5dl9VLXa3kL5Op4k3peKoGUPbSMJSVeDGnqUmOxbp9KVDs64Lta3k+tic6VOiFB9KF+igVMay76zhD1xRe27QKTeezGYnBNHaD6og2w882BY367qfmjlbmwGfVyxTCIjDQgOBSW+KjbJSylEH16co6pblpQFA4g32jXgXjFC8rBs7nZtuYymQ8D1q36b3bOV8yBFqd7aJ2cSOP4raIypNeDhy2Cn9hNsFNqIevYWKazrfni+S5+qRQbxZNFD0uQ2F4XYAckAeY7pQAgS9n3hQU8RTA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Dec 08, 2022 at 01:58:20PM -0800, Sidhartha Kumar wrote: > 5) improve the style of folio_set_order() by removing ifdefs from inside the > function to doing > > #ifdef CONFIG_64BIT > static inline void folio_set_order(struct folio *folio, > unsigned int order) > { > VM_BUG_ON_FOLIO(!folio_test_large(folio), folio); > > folio->_folio_order = order; > folio->_folio_nr_pages = order ? 1U << order : 0; > } > #else > static inline void folio_set_order(struct folio *folio, > unsigned int order) > { > VM_BUG_ON_FOLIO(!folio_test_large(folio), folio); > > folio->_folio_order = order; > } > #endif While we usually prefer to put ifdefs outside the function, I don't think that's justified in this case. I'd rather see a comment inside the function like: static inline void folio_set_order(struct folio *folio, unsigned int order) { VM_BUG_ON_FOLIO(!folio_test_large(folio), folio); folio->_folio_order = order; #ifdef CONFIG_64BIT /* * When hugetlb dissolves a folio, we need to clear the tail * page, rather than setting nr_pages to 1. */ folio->_folio_nr_pages = order ? 1U << order : 0; #endif }