From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A0C5C3DA7A for ; Thu, 29 Dec 2022 21:06:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 442798E0002; Thu, 29 Dec 2022 16:06:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F23E8E0001; Thu, 29 Dec 2022 16:06:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E11A8E0002; Thu, 29 Dec 2022 16:06:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1DA408E0001 for ; Thu, 29 Dec 2022 16:06:20 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E8916160377 for ; Thu, 29 Dec 2022 21:06:19 +0000 (UTC) X-FDA: 80296576878.26.59AD303 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf07.hostedemail.com (Postfix) with ESMTP id 767734000D for ; Thu, 29 Dec 2022 21:06:17 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=elyq7n35; spf=none (imf07.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672347977; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RokMjtqMjewWNdkAge9DNv5vn/LF3fp1QserzHEAYNU=; b=DoARuKXljZ2kiCXmiZlcO6rfkp9XPknosCU3sRc1WGx9hiWrpAi4AJx/BQ3WEatWU5HYHk QG+RkYfDuhvuhA8+QBllCOXPTyqV1PQThXie+2ib1/EAEznm+q5ALrKQkEtjapQX3e4Nq1 5lHIE/ianz0dlZNQaTjRyzV50A+iXC4= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=elyq7n35; spf=none (imf07.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672347977; a=rsa-sha256; cv=none; b=6v3+itNbs1btjQBDyELGryuWbBVuBdvG4coss0zpX5OMvWcYU6arD1fK7fgO1D3jXQYKQg XDHJwfXjR7VAQHeaWQyb4y61H2aQYqGcCBk5dxC3ZCBbzasd0LgI7rAT55k0wS4PHWHqmZ /QVbP6MsfoBOcUyHxf6RmjwmohRqtS0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=RokMjtqMjewWNdkAge9DNv5vn/LF3fp1QserzHEAYNU=; b=elyq7n35ZXguK6nHFKSxpNOkHO S6LUqru5U0/By72R5eacy0P/1LvjlrSfVd4iVRZy5uJGQN1JUQVF2D4dokhMXP87zp2i58ZiajVT5 aqjAChGiUGH4FryZAC4tVMLACZHSLzDFvMvQuFAPEDH3OXmp1Pz46uH/LdhFN0b//r0vcPRhYXuFP e0nFeIbbiBs7RWhtOQOLnHSC7J2HqYcya92F8IfOywBXtJ+QyfuG/aytQbL6YoFYafHhWNdFQekY6 fellKYINkEwEqTOodEgxAyHP4rQ0rbRLT96ZT07IdRVlxBTg+sqNM3K7V5Memw+V30v1C2qKMwJsx Axy2LZeA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pB06O-00A7H2-Ao; Thu, 29 Dec 2022 21:06:12 +0000 Date: Thu, 29 Dec 2022 21:06:12 +0000 From: Matthew Wilcox To: Kefeng Wang Cc: Andrew Morton , SeongJae Park , damon@lists.linux.dev, linux-mm@kvack.org, vishal.moola@gmail.com, david@redhat.com Subject: Re: [PATCH -next v3 5/7] mm/damon/vaddr: convert damon_young_pmd_entry() to use folio Message-ID: References: <20221228113413.10329-1-wangkefeng.wang@huawei.com> <20221228113413.10329-6-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221228113413.10329-6-wangkefeng.wang@huawei.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 767734000D X-Stat-Signature: zdan5mnr6cxwyafh97i5dy5gumwu3fb9 X-HE-Tag: 1672347977-256044 X-HE-Meta: U2FsdGVkX1+bF67k1Rv7cwy7McFz8p7nepQYczLswOFeH2ePODanY6nUANuAOGG1zrCRLPbRKg29VGzOJPj62pNoUTeJClXNqN2EVavNRHj0110ZbnV23dY7QgJLWd2k3frbL6KJG92QS4HRgmSmQ++1a3eE/u8rqiXs3MC8lRZP6MoNRYiiOegJMLvqgTu9jlzOZaac3GGU4cUb8kL11mA633NIqmRhEx9foP4GifYWr5SlrPwvy4s3tILoZ3iIa6zoFG6T2KrTrY2pO2D1A4RRPdQ/EIwMNelWpc4pQUjzGWnEUid5xgFZPwjt8vMGc1D+CgJU1exOTfHnE8Kf/wYH6vn5guPbSokXwvzcbpQeL/MKumrwh0lWlWSvW8X6UfqZRvjCWWgo3bBOFqzacjwJgsV/Xvl34Jk6BdrmLyw52DEdskthb6PuJtwrjpPddcIpOIxsl/rt03u8UU/gQyZXK14np1f7+kOj3Fuh0rVbGd2aQMkYKASNEEDPtX82xQUH5i8ScMW6At5loAfiRXjzghcITEEZ994WfBvS51uF70hunosjv74n4Laco4NA2l546Co9dSjuJYlbvYFvan5FHCpA8VML2YMfI6/EpsIpZN5C/k4dBayu7meb08RdMTg3LOqSu40NGyy7fg4mpMRm+/6ZDcXzC0DTEfztO0k4Fh7LzYuHx9xGVV4xI6c2MHcuptBH+hzydTFFu+RTQSstBjQ+cFfSTWBRFSpe2J+tybBewYOAX33gzdgDBbs766uEzAMAsawzW+pY9y2vUoHW6TSpX0vSHoelmGRA6cjCY8WRXhCuII3cAdH4a5jHqo3grC9gZDFJ+vzRGB2f5riaNU0j2xnxOIv+d6bMPlfuzb2iOZoQkTKUWwDLlom0VjQ9xxPXydDnLz0Go8kUk2efR2BeOC0jTXsPGbNd6+fOwXqhwZkh6y3Axydxy/907pSGfHW7QyG04QypKLV Gfi8tiv8 ng4w7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 28, 2022 at 07:34:11PM +0800, Kefeng Wang wrote: > - if (pmd_young(*pmd) || !page_is_idle(page) || > + if (pmd_young(*pmd) || !folio_test_idle(folio) || > mmu_notifier_test_young(walk->mm, > addr)) { > *priv->page_sz = HPAGE_PMD_SIZE; hmm ... > pte = pte_offset_map_lock(walk->mm, pmd, addr, &ptl); > if (!pte_present(*pte)) > goto out; > - page = damon_get_page(pte_pfn(*pte)); > - if (!page) > + folio = damon_get_folio(pte_pfn(*pte)); > + if (!folio) > goto out; > - if (pte_young(*pte) || !page_is_idle(page) || > + if (pte_young(*pte) || !folio_test_idle(folio) || > mmu_notifier_test_young(walk->mm, addr)) { > *priv->page_sz = PAGE_SIZE; hmm ... So why aren't we doing '*priv->page_sz = folio_size(folio)'? What does DAMON want to do when encountering folios that are neither PAGE_SIZE nor HPAGE_PMD_SIZE?