From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BAEAC4332F for ; Mon, 19 Dec 2022 10:25:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8554B8E0002; Mon, 19 Dec 2022 05:25:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 805BD8E0001; Mon, 19 Dec 2022 05:25:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6CD098E0002; Mon, 19 Dec 2022 05:25:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5A9918E0001 for ; Mon, 19 Dec 2022 05:25:05 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 31AC91C6251 for ; Mon, 19 Dec 2022 10:25:05 +0000 (UTC) X-FDA: 80258672970.23.0F9ED85 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by imf30.hostedemail.com (Postfix) with ESMTP id E06348000B for ; Mon, 19 Dec 2022 10:25:00 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=alien8.de header.s=dkim header.b=Gi31Brcu; spf=temperror (imf30.hostedemail.com: error in processing during lookup of bp@alien8.de: DNS error) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671445503; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Td6DN6d9KHuO8Ni0x4sFSPaN76BIetZ9amTLwGfBuQY=; b=0ligCHkRn+Nie+CTHJOB3RTTDtepI9siDfjPoStw6N5sLTuxxUCRjvuUWL+bK1ckpxBrH1 beAR1WPKoEd/1XSEzt0UkO+ogllSTIKpcki1Rqw+keYR9Xg/9ArQ9f8j9ZjE7rT9L/ZKCy HwlLI8peKCOX9B2ywPXZlEcrYy+xi0w= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=alien8.de header.s=dkim header.b=Gi31Brcu; spf=temperror (imf30.hostedemail.com: error in processing during lookup of bp@alien8.de: DNS error) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671445503; a=rsa-sha256; cv=none; b=ZMbmkmyLcGK3noE17c16PEXG1h8v4xJWGrGx6w2YHbN2GAgzBZclaMEi5W1Kac26Xw/Mwn jMfYvpwFCJsmXUBXUI+mCp7BtyoIvIkQmXuhfmX08bTkSpt8HZwhBxshtFzyU8rwxUVLdd UJ+dca1+VSGTXiDAMeir1MA9yn21iFY= Received: from zn.tnic (p5de8e9fe.dip0.t-ipconnect.de [93.232.233.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 241F21EC0662; Mon, 19 Dec 2022 11:17:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1671445046; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=Td6DN6d9KHuO8Ni0x4sFSPaN76BIetZ9amTLwGfBuQY=; b=Gi31BrcudDAIpa+PJzR9Rm2IwbH2EvgIUujPE8wya8WJCeKy/2ekrtTK9r05L2S9b69Vty nPxnhxFIIyGflDiLpYzFN3KhRz/d2AlJ8y/q4NmLiN36+iptFsaIT87iBVCGpQcQ6JiTDL XdJKVV4+vR907NBBpfad61/X4A6kZl0= Date: Mon, 19 Dec 2022 11:17:22 +0100 From: Borislav Petkov To: Chao Peng Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, qemu-devel@nongnu.org, Paolo Bonzini , Jonathan Corbet , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Arnd Bergmann , Naoya Horiguchi , Miaohe Lin , x86@kernel.org, "H . Peter Anvin" , Hugh Dickins , Jeff Layton , "J . Bruce Fields" , Andrew Morton , Shuah Khan , Mike Rapoport , Steven Price , "Maciej S . Szmigiero" , Vlastimil Babka , Vishal Annapurve , Yu Zhang , "Kirill A . Shutemov" , luto@kernel.org, jun.nakajima@intel.com, dave.hansen@intel.com, ak@linux.intel.com, david@redhat.com, aarcange@redhat.com, ddutile@redhat.com, dhildenb@redhat.com, Quentin Perret , tabba@google.com, Michael Roth , mhocko@suse.com, wei.w.wang@intel.com Subject: Re: [PATCH v10 2/9] KVM: Introduce per-page memory attributes Message-ID: References: <20221202061347.1070246-1-chao.p.peng@linux.intel.com> <20221202061347.1070246-3-chao.p.peng@linux.intel.com> <20221219081532.GD1691829@chaop.bj.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221219081532.GD1691829@chaop.bj.intel.com> X-Stat-Signature: djt8mdxpgjxc7mox7cw6y3q114bponhi X-Rspam-User: X-Rspamd-Queue-Id: E06348000B X-Rspamd-Server: rspam06 X-HE-Tag: 1671445500-279533 X-HE-Meta: U2FsdGVkX19/nAjEpiGAgk8jFP2Q6KVt47uvTGqZNnoPnogkf+H8qx0nba6Zx4GsaJj0lmdw2ryDGIb1M4JBJWd6pRPKaLCJlu+XWPlbmFqL7/FGwR905PGkk+5f8FHPdbg7vbXi576oDjknjHEsNPWkIfWxgvBJ+GpPQnHbp3FA7dZUdi7m/veo06G3UYs2pAYz5dL1rH4qZkvY9uPWUHUyYpdZuT4yNkHaNvmOgvUOQLNOQSvdUHCTEmPN+rKdZtbj6UYvUs6978nkcHcFjmAXU6POzNACtwrPNcBRTqYxkZsfvlHcMExZ4olVTBvJP+FzRm77Lr4JD6kCmhI6yI2HJfGgrkX+75tPMNav3rpq460ThnY8CVQW/VIzwWzqRMBv6eZrhQGQo3SLJn8FuY3Enk8MOZXrSUimRQ4kQJh7v061KlUWFgLy1AGdiq+mSb9lcTgo/sZGrPWzdGy7pdhWIP5IL+1/UwK7XQkxgirTsiWkKzbvgLvH0AcYpyH8W+kXCYbdG1PtSIvnSc2QwqhaHHItn7JsYgqrozvquQwsXwiWusUsAKbI9CC85PACERMZl92MgAxSG8GHiXGnKRzn+WCHY57+MG1VyFFW/rulRnSb8QxuaQ5b798KBy2FoU9ozfEqXqI0rdxRNdL/gUxWcZRSyZ0ciKtaFwnTBAAv4GZPBOBsKvKLuoE3BVGFjg1XcWAydjyYsoFM4lZibRBIHIVzWwuRwPPiFXHtKLubKaLZrpP6RvKWPNdHO3dkrnX6mL7kI9z817N8jFBQWYqkHjuf4yW9CDHxO+fZqdO2CU9gn6hvYezp+TK9w57mWdWGuczN5DQXQGGgPa41Hjk0ltOd/CtaaonCedjTnNU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Dec 19, 2022 at 04:15:32PM +0800, Chao Peng wrote: > Tamping down with error number a bit: > > if (attrs->flags) > return -ENXIO; > if (attrs->attributes & ~supported_attrs) > return -EOPNOTSUPP; > if (!PAGE_ALIGNED(attrs->address) || !PAGE_ALIGNED(attrs->size) || > attrs->size == 0) > return -EINVAL; > if (attrs->address + attrs->size < attrs->address) > return -E2BIG; Yap, better. I guess you should add those to the documentation of the ioctl too so that people can find out why it fails. Or, well, they can look at the code directly too but still... imagine some blurb about user-friendliness here... :-) -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette