From: Lorenzo Stoakes <lstoakes@gmail.com>
To: Uladzislau Rezki <urezki@gmail.com>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org,
Matthew Wilcox <willy@infradead.org>,
Nicholas Piggin <npiggin@gmail.com>, Baoquan He <bhe@redhat.com>
Subject: Re: [PATCH] mm: vmalloc: correct use of __GFP_NOWARN mask in __vmalloc_area_node()
Date: Mon, 19 Dec 2022 12:25:40 +0000 [thread overview]
Message-ID: <Y6BYRDbprdAeE0IZ@lucifer> (raw)
In-Reply-To: <Y6BUhXwswQTsfp0E@pc636>
On Mon, Dec 19, 2022 at 01:09:41PM +0100, Uladzislau Rezki wrote:
> There are three more warn_alloc()s below. Those are explicitly disabled.
> Could you please rework the patch and make it working also?
Ah yes, sorry missed those, I think then the simplest solution then would be to
simply yank the __GFP_NOWARN specifier at the top of the function and restore
the explicit flag being passed to vm_area_alloc_pages() you added in
c3d77172dfc0.
This whole thing does make me wonder if this function is due a more general
refactor.
Will spin up a v2!
prev parent reply other threads:[~2022-12-19 12:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 23:46 [PATCH] mm: vmalloc: correct use of __GFP_NOWARN mask in __vmalloc_area_node() Lorenzo Stoakes
2022-12-19 12:09 ` Uladzislau Rezki
2022-12-19 12:25 ` Lorenzo Stoakes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y6BYRDbprdAeE0IZ@lucifer \
--to=lstoakes@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@gmail.com \
--cc=urezki@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).