From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7144DC4332F for ; Tue, 20 Dec 2022 18:56:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0C1CD8E0002; Tue, 20 Dec 2022 13:56:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 071F58E0001; Tue, 20 Dec 2022 13:56:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E55608E0002; Tue, 20 Dec 2022 13:56:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D81E78E0001 for ; Tue, 20 Dec 2022 13:56:42 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 85296160C83 for ; Tue, 20 Dec 2022 18:56:42 +0000 (UTC) X-FDA: 80263591044.12.7DD1576 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by imf23.hostedemail.com (Postfix) with ESMTP id CA6C814000D for ; Tue, 20 Dec 2022 18:56:40 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="OqHxK/ij"; spf=pass (imf23.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671562600; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hPsXopC8VlOGBjVqyvv0STceQYDc5rKNyXXZ+5W5wLk=; b=FC2KlUWk54o6fUHG7h5hrZNe9TSHoEKmnfDRYxkygVITaOCMNXYh8W46qKL1MNJATJbhxS koj/CmD/ybGORNo9w/zb7CqMG2O9nc7+zv4PzNoPlTf6BAbBLaI8WJVT/OUx08DnV/fMlC 5zU6Xl+eb+NmdWq64KF5CoBS/azwUoc= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="OqHxK/ij"; spf=pass (imf23.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671562600; a=rsa-sha256; cv=none; b=JiCpO6z/uqBTK0xITd7Gi9zJiDFxHRjUSy02hRXhV0Ahl5Wjb6FFqcQQOzttkUwBlah4X1 PJy2jJ3veqmVB6SW6Q3oLtrg8jaSVYxlW15GRUCgdp8H9GHqulJQ4mwlTxx5/1iNPeOY91 QMqpxfqdvRUD9yPAbngar2N160QOXDM= Received: by mail-wm1-f50.google.com with SMTP id r203-20020a1c44d4000000b003d6b8e8e07fso69435wma.0 for ; Tue, 20 Dec 2022 10:56:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=hPsXopC8VlOGBjVqyvv0STceQYDc5rKNyXXZ+5W5wLk=; b=OqHxK/ijy0pwjrnJ7CgrfppgL8g+E2Bcu0/llP444kXxELGG+uatHkv0kONDPi0kEi 8ft56IFxKCb0fd3kryO7Ov2DWx9jkuYkBps9fPLVWX3FK1m8VX8l91Psekv2KqZCjR1t nU1jqUyHU8x++rwNdEVSIaQ1laQ5YRKCQHFeNeStN3UU6qt4pVIOy/NcLC8u7IJZkuvp L7ibMa2Cj7fI3e9W5y+3Qqt+a/IX4KIm/RBcDP7rpOXLf9lW4ge4d18cVrQVmI8SgCef QaZGdfyrLntWA/80w2k0Yex0cNMGV+IzQsiI5CDeY8dMAIpgBT8nibx31fvW53veRE+T mcng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hPsXopC8VlOGBjVqyvv0STceQYDc5rKNyXXZ+5W5wLk=; b=MCVkj9IACrIjFrcT6G4wHl5T45bewLbQBtuFswb/X+/UOfTfpBecTQ2xzGKWuiHK8r xniPPJwMrpYIxsQ6/j4SE/ZQ9PRQzOuKLBpWktyVrZGWWHxWnC6qLzJUF/LQ/sO1vLr3 x6Bf+G9vOwodTyiJ7qjcej8mqqC9YBvcu0OLP7FqC/CnlTkabFI+3UF/Jk7tCUDqkqUm wiK8mbKp45JzhETrDr9JR6sckcWgeGZODbGqCTY9132kdH83kEqEfva4tU72UhfRoXIs V/OTSA4hpYI6zwBDY0Xl0fYtaw3JB2AsyNcqY/j/+xe4kBEVVugfycT/tgXznyfqvdUb GE1A== X-Gm-Message-State: AFqh2koHNsn/2O15FAC9H+PVQ7oIaaNX4lty4baHoW+d/SBjUh2qwzmj RaVXIoAc2IQoYo4KzQQAaz0= X-Google-Smtp-Source: AMrXdXu11W1GwRxdfJAqPTr6zCnU20ODFhQVmowwREDaFmTSTS7SG34Ko2229fWjO5IpJxn/erV3hQ== X-Received: by 2002:a05:600c:a53:b0:3d3:5d47:271c with SMTP id c19-20020a05600c0a5300b003d35d47271cmr4087178wmq.12.1671562599405; Tue, 20 Dec 2022 10:56:39 -0800 (PST) Received: from localhost ([2a00:23c5:dc8c:8701:1663:9a35:5a7b:1d76]) by smtp.gmail.com with ESMTPSA id u21-20020a7bc055000000b003c6bd91caa5sm16874912wmc.17.2022.12.20.10.56.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Dec 2022 10:56:38 -0800 (PST) Date: Tue, 20 Dec 2022 18:56:38 +0000 From: Lorenzo Stoakes To: "Uladzislau Rezki (Sony)" Cc: Andrew Morton , linux-mm@kvack.org, LKML , Baoquan He , Christoph Hellwig , Matthew Wilcox , Nicholas Piggin , Oleksiy Avramchenko Subject: Re: [PATCH 2/2] mm: vmalloc: Replace BUG_ON() by WARN_ON_ONCE() Message-ID: References: <20221220182704.181657-1-urezki@gmail.com> <20221220182704.181657-2-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: CA6C814000D X-Rspam-User: X-Stat-Signature: skknkmn4u8ik5k18q44jju1fegzdzyz9 X-HE-Tag: 1671562600-556237 X-HE-Meta: U2FsdGVkX18RisSL7W0amw9RWbksVZCGVURc2ujhuqmCczjXXPs4ikQOCqsnaKyxXKmmE1KK9pBi1eIecLKjKhjAuZ2QArEEPNBRlJBMBbf97QzJxUsXpB/fhqzOfQrVmJYHt7aZmSj3mEIxEhjBNT13i3mA7r7zhy8Yf1jbMwKiuCISAj/NS91Z/BmPbqxQC7xe6HvcGUj04qCTwwwjcTQ1CNDm08bqtcQ4STEqjiNS/TcPAIt13N2u0A8SO8lWfFl66HQmRnSdIH9IUMBjjhBBch9xiN+tdPptIDz4Ahp3bIXF3wEZXUM/jZjaLs4q2iPwDIsi46JAA++xCHdQ7fZUZgGhSFZJIAEaZ7NPeHtTv9O6n9nr9CD9BKzZsk8jyXO4n8W1GRy8tdrSkf5+PLX9ReQVeHkqLx8yAFxLycNL0g5BhBPKeposNirvP0wCbYRkEElMW3Tz1LBsELa73f5GIxIANUr90+SZcUUawyFuFq8bSpeSSV9nAlMsxstNprY8CSZw550U0LaVFrP6qlNZktM1TENIVv2HQf2tJMMtjO6MgQ99iKu1m92zKYzDpvzB5i8qlzEuMrP5nhOoA0dziqGQBGxh/msor8blHazcA+MPC/grzkr9kCA7ykIFcTQWv0dL26g6T2fNNJxHEdjxuUkIaKGOe3tK5uoDwc1036viEMcs2yEEWdi6YFsc+X7jkiavgXPuZvdF2fpNbbl8nhZbX3UXYBMxWfuE71yghNXov1hmWgkmpsIQnrplVKXy6disuWUm2hYoKd6U2BBMZrXwvhO+0xiVBSvFHVcF3U1aNiz5RirgKN8qDpJkw2woOwA8VcTvQOYs9Qo/gHj1LHdSrhLn062GarY8LjtdlakBCeURRL37A7imiYpd1r6GtKZxmf5xx1ttJVsJV+DKmHtqqtZCo5ioohwPCRG4zDrdUB59173UY5s825PGBL8BatqPnuLE/qtS7eB jp0fQaW4 0efCRmNwkWV5kKZsIX6+3ifwRMT3W5Rzf9RZHRWcZT6yEmL+1WZM/2N0a+UKHMMAt7B+uZN8HWNsXKUhgwietaJMWc75LA3ocD13KF1kyGG2Q67HwmJMSTVNOKxfPlEpv0Ih+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000014, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 20, 2022 at 06:53:18PM +0000, Lorenzo Stoakes wrote: [snip > Absolutely in favour of this in principle (BUG_ON() is something we should > resort to in only the direst of circumstances), one small nit - perhaps it'd be > neater to simply make this a guard clause? E.g.:- > > if (!WARN_ON_ONCE(!va)) > return; > > ... Made a mistake here, meant to say if (WARN_ON_ONCE(!va)) return; Of course :) Apologies, only just noticed you are sending a v2, perhaps something to consider for it? But will hold off further review until you send it! :)