From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90083C4332F for ; Wed, 21 Dec 2022 11:39:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E79568E0002; Wed, 21 Dec 2022 06:39:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E2AF88E0001; Wed, 21 Dec 2022 06:39:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CCA668E0002; Wed, 21 Dec 2022 06:39:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BB5DE8E0001 for ; Wed, 21 Dec 2022 06:39:54 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A226D1201F8 for ; Wed, 21 Dec 2022 11:39:53 +0000 (UTC) X-FDA: 80266119066.12.275B436 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) by imf14.hostedemail.com (Postfix) with ESMTP id CE46E10000F for ; Wed, 21 Dec 2022 11:39:51 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=mTbZppwn; spf=pass (imf14.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.46 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671622791; a=rsa-sha256; cv=none; b=LATPM0IWV43l2mjitmJdL4SDDP7omZH9+sAl4JBEjreaXEzK6MFiP6prpaCPJByFyFfCu+ Gy5pzvpIvIskoZA59qqEpl5TbF7rY0ny8fRje8kfz3mjbXRQCrDv/9BbiqmjN75CeJ2cIW WFTtgZIz72O3rt6RLWCIT94fXkWaWJI= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=mTbZppwn; spf=pass (imf14.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.46 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671622791; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YcOAZ1b4V0JHDlFi6vemRpWBd7E+1UkjfBLEbbTl/Do=; b=wF7+A6S8+44zc1wn64GX19CX428AW3bMMLp4YGDYTLLl8XTfMOICBezgIJGw0jB1bMzOoi 2Uy6cTMWGWo7pSSTMPjgc9DMz1p3803r20HEIHUiqqLFZc26xdK6wxjW8TzZ8cW1kxqDVm J4Y0lRXOyxXOT/Jr8XeYGr/FbHiGLR0= Received: by mail-lf1-f46.google.com with SMTP id f34so7876082lfv.10 for ; Wed, 21 Dec 2022 03:39:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=YcOAZ1b4V0JHDlFi6vemRpWBd7E+1UkjfBLEbbTl/Do=; b=mTbZppwnJqQvWr8Uf7k9OT9/r7KlCF+MteCB2q+/e/36aQ7yjH+o1zZie0jW8LeTP4 C1N8ysoJm6Gb1+k9Xnpt+bN5F54aJE/ZYQ8Fzza9hwV8pKFNoErNfTJP6neEGPgpJpXW xpl+SMFAdk7yES6SXS15EzVbWcFD93Wxj+bifpne8F3V2WhdbpCGfQu0gtzFczIGfTGZ +aBa4n3brk0BVX2UZFSH9V0Ag8zfm7hkNCgHo0W3AeLzkWOwyHUhh5kYPjCYZ0G038R6 77m/u9MBQyNONFT1DQ6QrtM+MCkKRe3hdibLWzcOgpuRbrNmnOpi2hwVfNTFtXS6xy63 nGvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YcOAZ1b4V0JHDlFi6vemRpWBd7E+1UkjfBLEbbTl/Do=; b=k2VHjYnyVCcoul5tbh8yKhF/xVBSSi8soXiR1KZj6xD7ugVL1/E/4JbpKTYKed+wxB c7vxPL4qGLNKP4fsOVM+5aNSNyhnzlI2JYa5luUcWcYe5uC1GG6hZra59qCfByDgMSq7 XYwcn91gv0/Bad6yCw4umrMg6QFnc7XG1um//mClO/nosW3QGjcgeYyGHrws/ZfUiZkI jCEWtfGCzBWYIXm1cCyj4hB6zV6wr0fn4f4/dFWhDUDBI4J/ha40vCN5k6hymnDAk0j1 OVrUA9hlXr9BUfW7dtDEWljDeTUsh6d0VOHCCmIieSYCCg/fxzU1N1s2d2aNzZbT/PzX mbxA== X-Gm-Message-State: AFqh2kp7gvDLjKcDhmBbrJBYr0XCEntPNQBofq/fz6JqJMlPpwWfS1ip uz605wLmt4V37ipB2uw/kFQ= X-Google-Smtp-Source: AMrXdXsL6XBIJLCnp+GoORbmld1Yl1OUfL2YJX95BH5pgOWqHgtmlAv55mITc8Slv4YjKH6Xh7fjKw== X-Received: by 2002:ac2:5231:0:b0:4a6:c596:6ff7 with SMTP id i17-20020ac25231000000b004a6c5966ff7mr445761lfl.2.1671622789882; Wed, 21 Dec 2022 03:39:49 -0800 (PST) Received: from pc636 (host-90-233-218-120.mobileonline.telia.com. [90.233.218.120]) by smtp.gmail.com with ESMTPSA id o15-20020a05651205cf00b004b15bc0ff63sm1801594lfo.277.2022.12.21.03.39.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Dec 2022 03:39:49 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Wed, 21 Dec 2022 12:39:46 +0100 To: Lorenzo Stoakes Cc: "Uladzislau Rezki (Sony)" , Andrew Morton , linux-mm@kvack.org, LKML , Baoquan He , Christoph Hellwig , Matthew Wilcox , Nicholas Piggin , Oleksiy Avramchenko Subject: Re: [PATCH 2/2] mm: vmalloc: Replace BUG_ON() by WARN_ON_ONCE() Message-ID: References: <20221220182704.181657-1-urezki@gmail.com> <20221220182704.181657-2-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: CE46E10000F X-Stat-Signature: k46wrabtt4k8ifc1i6zdeqbh5joifd17 X-HE-Tag: 1671622791-677922 X-HE-Meta: U2FsdGVkX19zz/ceib4N2WhcBzmuHaN91OckAQgNtXal4eS99bJuwlJ//zPwADFA+oluCIAUfcTgCtmzOIC5RjjXZ9lKIRCaabU01QTgHlmvL0qNzCqMTILFSKALr/FgH2Ujde+n/om8XwAq67H+aJ8uUy4HY35bLJW8gh7bG/GV0DdlAh7qUg5QuYmawt65gu3NRKrbPt7WHeI7myGnjGIWWdFl/AC2Qp+55FMGB/e6OJ2xjHzkNi83EU5pCI9OQ8Ytwf5DIimSS4bNsbnAs6U+iXdojMKf8eWt8+ZzVE+xRfyfDv68RirP93NhG/HCUMX/A9p/Wc/EHCu0RjkKbO1wEqC4dObF0BiWGj5uuknxtXtVerTMhQzEs80+AoiKZFHcCLGgwTeLuvhllJoNgRMWluhQ5+cKgDYcXKK1rSemoxAOnNMFXHTunF/lVgVteN2KT6ciDaiTNoNv+OVoxzznjpGrF4IFnR3f5qia8/YRM0bKa11FmJvnN7rwkWn9Y9PKPF5u3iHTZjNndGEJCBdI7rYrMUdl2VwZVaIvEHihIvsqXVz8qq2JmDXsnv0Ll4VlkUud+MZ/+AtBoGuN0FV2tsL64Rmk1qy0a/6fvB/r48feek8qjfAmYc7WRfXuwxGXXiVko+FFKxA8Vj4YY2JZyuVJLaksJlIIN6sodDPtSli6Ys3wFR8kIH7AcvFOSKXsSuIcbhlhAdhpc3yzdIK6d90R8qqLY9wDc0Cb+5OarJcx2HkFXhLFLNvaIuUCOL5Aakeo23kpr6uH/T9da1WCiaTxzB/dPaWLnr+8MAFul2D+SE04oNuZYE/nFW+3dNE3U6aeRe6/ImHJXrduHt6Q/9EYmcy+HKzEvhdmP+fytNUb96Itf195SXMlFqB+Lz49oeh/76dQMaqDNVQTZVk3uTEUCRSEScNCkzpStmuO9ikU4i5a2FqAQXNJvnNBPL4T7japT8Rrprs9sz2 1y4MJOpi QiBj7+0aR1JqOS6LZC0TSXZhlrZbaUVKwWSP4XCE5ltsrftfTiRpqPF/lg+w8v7baElP0hCGbLOJED408LyvFrw2JNVR8vU9JhSR0zjmEU61jyBnq3RZa5Ib62//Bjyyd8nqJoaX5BJ5y75c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 20, 2022 at 06:56:38PM +0000, Lorenzo Stoakes wrote: > On Tue, Dec 20, 2022 at 06:53:18PM +0000, Lorenzo Stoakes wrote: > [snip > > Absolutely in favour of this in principle (BUG_ON() is something we should > > resort to in only the direst of circumstances), one small nit - perhaps it'd be > > neater to simply make this a guard clause? E.g.:- > > > > if (!WARN_ON_ONCE(!va)) > > return; > > > > ... > > Made a mistake here, meant to say > > if (WARN_ON_ONCE(!va)) > return; > Agree. This looks better. Less confusing :) I will post a v2. -- Uladzislau Rezki