From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D33FBC10F1B for ; Wed, 21 Dec 2022 19:13:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5417B8E0002; Wed, 21 Dec 2022 14:13:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4EF488E0001; Wed, 21 Dec 2022 14:13:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B94F8E0002; Wed, 21 Dec 2022 14:13:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 28E148E0001 for ; Wed, 21 Dec 2022 14:13:09 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id EF525120CAB for ; Wed, 21 Dec 2022 19:13:08 +0000 (UTC) X-FDA: 80267261256.08.560D5FB Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by imf05.hostedemail.com (Postfix) with ESMTP id 1AF73100012 for ; Wed, 21 Dec 2022 19:13:05 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=FaVOUANB; spf=pass (imf05.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671649986; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=loGkZ6fPSrrmhsnB/j6H1/AVCfOR2MAXJgzPNmIA2Q8=; b=5/Vp5e0R1D0pUzOCPGG7l3uPYDm26fthLBA/5WTtFVp/L+BiRN8otDYOa1EEUTJ7juHee8 UAf7iENtnkJf2UQxezQWPCELgtDvNKpw6UoIVnDEwUJ/KuJH5AwQOsy9Mryd8aarStAZwD w7J9OdP8XdDLkVuAjBxBU+OwzrslYVQ= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=FaVOUANB; spf=pass (imf05.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671649986; a=rsa-sha256; cv=none; b=sWWVwuWUc6255lJrG46km+fDnTLJ1hA8E7uI0yM2FHFfajPCunphwk4vk333je4D8SocUa zAF9T+qi+/T4nSgntSr07dCTq3GuVhNf+jiBEgRODVxAn2HpdzqwUYPvHC6EYXIw0pPW9+ rXYFFhQdGgeQpOPEPipIqqSTfT1CT1U= Received: by mail-wr1-f54.google.com with SMTP id h16so15858474wrz.12 for ; Wed, 21 Dec 2022 11:13:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=loGkZ6fPSrrmhsnB/j6H1/AVCfOR2MAXJgzPNmIA2Q8=; b=FaVOUANB+JUidsrSRWcPVrk9vir9R7x13EZXvbbFJKhNPfY6MQVuzhcYF76JipPOh9 G3oLP/cCugNtim+SoHolkoMY46Q4+FUVk89IKwlXBGRaDtFy8sIZgDSSFrA4+o1LeD+o 7G0Pl5bYpMKuIlW9IMN+BZu4FdORmvf1DPnR0CM3xwThjvqJCKpULmerXqRa+9nDWdZO ChFRyGKk65HzSCiPKmMS8dEoyHPIk5lSyoApNLe7sBUzkyxjaOvicQv1Q8icK7vbI2Wv i5BybSBQHbpfJxvLHsuiX9keXUGHsZ5DttiD9e0YpMw3pgpqT69m5DFY9MWU1knvBJNr ZyGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=loGkZ6fPSrrmhsnB/j6H1/AVCfOR2MAXJgzPNmIA2Q8=; b=ZX/UztzEl60HNnG1SRrDJhu1BDn5RyFe6yD5EXpfik+qjdcHt+nsOKhiz7VuEjHMDb Yz8ISvAU0CT+Si+r3SW0myg4hmxfPQhzi8NEyIzuV1oBD7yaEqFJFv68OybZ/V+YRx/3 G5o4jo8q+V017WyxDXV+jHDyjY3o3lMLpjulBh0E0FzWeecBdrgXl6kph6yNP6TqWY9H 1I1GR4LzlM83iB2SvSiPeOlGxzXuq5u9Ae/qoZUfFpPQwW/uRVoT9FYgZTlCKyHLySV9 AFt17jL/dTTn11GeJ2YNjZsZpvw34/45hmWsMDrrMl0i02sLefRbQ+rAh/gm9DMG75GU 2vEQ== X-Gm-Message-State: AFqh2kotYv6M4X8DlcMtcqVmv4bwagMbsNGhjocfvmRQZ8CIbXZE2ogW JYvAyHnRhgmNGsgVQ92rdOo= X-Google-Smtp-Source: AMrXdXu5nCKznJHZrUQSE0Oijx3MYaVAi4blJLehAPfwEFKcFqI3ZBZGTh+4Ga7pdR4U6qZlW8OvaA== X-Received: by 2002:a05:6000:16cb:b0:242:1b0d:9c58 with SMTP id h11-20020a05600016cb00b002421b0d9c58mr2117681wrf.69.1671649984661; Wed, 21 Dec 2022 11:13:04 -0800 (PST) Received: from localhost ([2a00:23c5:dc8c:8701:1663:9a35:5a7b:1d76]) by smtp.gmail.com with ESMTPSA id w16-20020a5d5450000000b0026a4bb75477sm2473118wrv.28.2022.12.21.11.13.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Dec 2022 11:13:04 -0800 (PST) Date: Wed, 21 Dec 2022 19:13:03 +0000 From: Lorenzo Stoakes To: "Uladzislau Rezki (Sony)" Cc: Andrew Morton , linux-mm@kvack.org, LKML , Baoquan He , Christoph Hellwig , Matthew Wilcox , Nicholas Piggin , Oleksiy Avramchenko Subject: Re: [PATCH v2 3/3] mm: vmalloc: Replace BUG_ON() by WARN_ON_ONCE() Message-ID: References: <20221221174454.1085130-1-urezki@gmail.com> <20221221174454.1085130-3-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221221174454.1085130-3-urezki@gmail.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 1AF73100012 X-Stat-Signature: 5r3rpmwys9oe3fke4r5ggebpmitarcdt X-Rspam-User: X-HE-Tag: 1671649985-813100 X-HE-Meta: U2FsdGVkX1/zgMZ5ClRupzq613BgcA6VqTdFH7WIIbcbaeThVCVOt+Hcwmk41WO1hhclMupNsc0uqgrGH/EQOhV0ytyofMTWwc4E8H1P5NgUK0iWioS6MlbDvMUw1RTK576qtBgIK1bKi//sy/z66wEKvFy3TKHrmm+efDge8upxWkaZaJwZyWfV4JNOm0UTLWPQhNPSxjlvy6dRNb2BuO9yki/8aFy9EXlvntNHiYtchYfDTu5F0se5LJ0kn3LgTf4scr7x6jXRSyA2ePMPHJTxG1USXfWvvYsZsKn1+ZMqW/MSnd5XHc7e0kyP5DSuL2CYyD+i2f3mnmzZ2ewDK/L3YffsJ0u53Y3ZnZNl03zl96rbtoHoq9L3SxDq94RLVkLUeNb9fAw/OreFuHHgU0Q8z6lScLEL8gyUU7gEl0AJc2fPQCuiTEfgV+1d01XIsuuePXPI87MgctMmJx3X1LoBbAqrG7p5d1M2IeiBwnc3r0fSEWfKdY1qgl0KQzyuT8i4sq6Y0VguML7NroVotX/IJ//z6qQxwjQYoD4PGNj5tOb6QN+sGZrwgF5umncETbOg+IBoWjAkPwJRCCg6ZQMrqxJLdBUBDig3uUdYGRxDYiq8EYfra8KnspJ1Haocnv7SGw+O8aAnVGyODmVRLW5EAOmybxDIfu/XUqGOrmoBNvlkZ5vUh7MB4heBu7YJhKZ7wrQSnS2hY2+lr6s58kzecovWMW6Zw8XfvryGkhuuFa27Cfod1uLnCC9Xg1bTf2YSCFWoiExqmiAX/kiCuaXX3WCtlm2TzrQ2htdFNYbzr4PHpr0CxNWeSaMboZRorKlbs9c+8zw1XJNzdYOYHdZboyDWGq5E8IKE4BOgwbunG/aHUuew4lfuOJfDLiVNoiMI1I7aQ7iAZVO3mybWxxBILfZLuSLvXYreWF+HyEVIIVMb8j4qhd8v06MZIb4VGMtkZbwjmDTrXgNuI/U FgG1LcXO 42KQs5pUSoMsLobLrqolYC7PmbLto0T0idiPq3sxcIaakeCXo6zkQFg+dA0GZyB1NGndDdxicACcMxt5hSVBSGKfdlqWsYUEeAiSBjrr/cxo+0iy/1NVEK6Unj6JB1Ja2icMzZhXKzvTRREA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 21, 2022 at 06:44:54PM +0100, Uladzislau Rezki (Sony) wrote: > Currently a vm_unmap_ram() functions triggers a BUG() if an area > is not found. Replace it by the WARN_ON_ONCE() error message and > keep machine alive instead of stopping it. > > The worst case is a memory leaking. > > Signed-off-by: Uladzislau Rezki (Sony) > --- > mm/vmalloc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 17e688cc7357..221d8950e13c 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -2252,7 +2252,9 @@ void vm_unmap_ram(const void *mem, unsigned int count) > } > > va = find_unlink_vmap_area(addr); > - BUG_ON(!va); > + if (WARN_ON_ONCE(!va)) > + return; > + > debug_check_no_locks_freed((void *)va->va_start, > (va->va_end - va->va_start)); > free_unmap_vmap_area(va); > -- > 2.30.2 > Reviewed-by: Lorenzo Stoakes