From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37FFAC4332F for ; Thu, 22 Dec 2022 14:41:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A5831900003; Thu, 22 Dec 2022 09:41:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A0863900002; Thu, 22 Dec 2022 09:41:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A8B7900003; Thu, 22 Dec 2022 09:41:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 77F00900002 for ; Thu, 22 Dec 2022 09:41:36 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 0CE4E160E0F for ; Thu, 22 Dec 2022 14:41:36 +0000 (UTC) X-FDA: 80270205792.01.3799F88 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by imf02.hostedemail.com (Postfix) with ESMTP id 2CB4F8000F for ; Thu, 22 Dec 2022 14:41:33 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="JKp/m0Cz"; spf=pass (imf02.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671720094; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y8q7yCOMFgnvKGyTp7h3zj10DGyq90Tq72pzXwBz32s=; b=VOIUbCifqMDsmW6RpbdR5K6s5+mT85grKSBkCEJKHrLOSMdshf23mHItnEmkadFMDexRwz 2xUXdMlwqdOMK05cSjsr6oSijNrWCZYTYeSoMS79Zzvv0EtfgnTRP7aL6fg6nPwh15q59h y+aTnUHj/1nMs3RltUl1mbM0Cx2F+3U= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="JKp/m0Cz"; spf=pass (imf02.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671720094; a=rsa-sha256; cv=none; b=8EdLDjj7n1uixXx1TzI64Fe0NhVRsbk1ZW27eJqFPfbxRQeFEIa1VJ35SWgsJgf93Omps8 gdgqlfeyE8KoUAQsHSnkJnDa8UlZyPUyxBZ6koJzeXzkJlx1tkKgnCIntFwN5RyAqTOFkp BeGLmp3Ctn8SuJn8XbxOf4hvwV9dsag= Received: by mail-lf1-f54.google.com with SMTP id m29so2991401lfo.11 for ; Thu, 22 Dec 2022 06:41:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from:from:to :cc:subject:date:message-id:reply-to; bh=Y8q7yCOMFgnvKGyTp7h3zj10DGyq90Tq72pzXwBz32s=; b=JKp/m0Cz9g+KRBmrZ/zb9sY+rbC+Z3MKRfAhzZXDV3M0CkvZ0MtVmXHIJVLK6xNIux SiXkQz/4OrIVReFWaudjX+Q/K5ngnuWoqoa3giU7d3QNHzuaVX3ZJmyB5jxHNgHXL518 FgRSGoDcZWdL1XJhH0WBXvo2Z0rIDRTEwaWAfoQhpyx/1cUsOjHmqS/5xxE8wX+kAPlQ yytA/9ncZGE49NskaeCGz2uQ+PYzeXnU13mZOdOww/V9xcRntA/UR35Hq59+HvsTRdJs 9EYjcKy6/fMsxGcUVXjd3ajvUtpRXkbJpa26mam0cJ920JbNThdqWjgF8CNeNnxk7Alz Q2cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Y8q7yCOMFgnvKGyTp7h3zj10DGyq90Tq72pzXwBz32s=; b=oXmg0RZyTsrYYOoZXXd/quPEoQRZWdC6NuYUenQoifRtVZZtcfW8XOQukEGH8y0aIU SoMieo3nvH72tAtp6avCYyOTwK4wNEl4U4ZUKAvS7t+go9wK6Aq53roFu80MdwF10rmG E8cRnaDEuM8z9PPmHF0KazTq1Yo/0gMitwH/wBbvhUkUUAxL98v35aX/wo1WYs0r70jM s67WlC5P/3gEH5Ww56UpHLO0mArjNXgA5b1ke3j/FiVFgFklGW7i3JkwHxKtTa3qvVN1 6mdfj5jnI7vGA4gpbMEL90KMl1axJT5yTBwKO0UWP6lNEhDy45U626SDJw72EHxV+BAF L9LA== X-Gm-Message-State: AFqh2kogKni4stDKhe9Lrok/1Z/HMRK0PnMzUFFGi6UcGKN6uq6YoLoX InuUhLvuI4IVoqpZw7dl7bc= X-Google-Smtp-Source: AMrXdXvinT8dSllKaVAXZCxs9aPvOnFv4m4qU/eR7WOf1jlIEExyVF0VtYqBpvRaGk+5TAkMt4hSSA== X-Received: by 2002:a19:5218:0:b0:4bc:4ad0:4148 with SMTP id m24-20020a195218000000b004bc4ad04148mr1482686lfb.8.1671720092395; Thu, 22 Dec 2022 06:41:32 -0800 (PST) Received: from pc636 (host-90-233-218-120.mobileonline.telia.com. [90.233.218.120]) by smtp.gmail.com with ESMTPSA id q8-20020ac25108000000b004aac23e0dd6sm90078lfb.29.2022.12.22.06.41.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Dec 2022 06:41:31 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Thu, 22 Dec 2022 15:41:29 +0100 To: Christoph Hellwig Cc: "Uladzislau Rezki (Sony)" , Andrew Morton , linux-mm@kvack.org, LKML , Baoquan He , Lorenzo Stoakes , Matthew Wilcox , Nicholas Piggin , Oleksiy Avramchenko , Roman Gushchin Subject: Re: [PATCH v2 1/3] mm: vmalloc: Avoid of calling __find_vmap_area() twise in __vunmap() Message-ID: References: <20221221174454.1085130-1-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 2CB4F8000F X-Stat-Signature: 6gpnngii9sazho3ormgqi9sgrsh6bgx1 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1671720093-300120 X-HE-Meta: U2FsdGVkX18apW9PdNluQNAhoYoeL4995sSYNqsr2zu1C+aCLNKNTqDq+0T5cJWsEyEwqFijoBK0oEW9fYkmDINqsLQ2uJsI7Hhjzt2ff6aTtP8bV2pFR0J49ffVrq74191B5MaQ2Zmp1p8gXQKA8iQSkAdSCQrzbVjCMWSXBvkS6H7CFA8xqBLxFKajMhMgH5qozhpmkXHg0WwogiGzm2EPdThB+G2CgjKkUZmKeAsf4KJxJIKe1MY8e6Po5K1Uc2tmyy8dsvRYj1PMQvfbpWxTwzw7Dc0XeljUu3sSGyuz/Pstcb5mKEBXPS0f35mWf/IWJ4DnNlfo8s1gBg5fhZvjdrzBi5m+z8hZR+wqd80Nc/pjiJd/A0vndoTaOxGzvPqGT75A5aObGm+7098bmfPPx35WnjNY0J2SiIzzU9LZwRtQxnaYs7nEwnXo/tjjcRfkoNSdahSkRUSqzZ2OUCqLh+t6w0A2NPPl3sBPSdLjbTL+4h5xEAxmT09+G7xNGZU1JuiiO4wNfQFBtG9syDYd+R2OJ5mmR1Be1LpZftVmo4+AtPbOxuHMfoWIL/RXAyhkNYs/UV/y1G8FcgsBs6g6b1ov80uxE09o+7xCYC6r3yIEyguM0mc7KSblVeXO3efyDhH0vGjUOhq4o8yI97BoKjNy0oclaW1L7Ct2n/X3czTRi2yvkB69Yw9GHxzTOP3UIiG0AU0ABKWuLndeVLwU+6KNGNnTvkqvLMPY6C9i3/Gd5AbiWLwKpuM8wVeSrm2S40vwTwUOgjkShiAC5u37s/MpSEwTqLoXsPwgtg120Sc4bdCsgvUJ4Sv7uFJCy5jOuJcV+RDeBpkXIWAGwjqpu4gK/UcR2onzXkQtefNcN75LSbmvtYWkfFAsVgZQbVO1ij3cirCtOnyiskuho/BIHuWNJp+qZ7qT590Aqr7Fb6hKtqvy+sS6Vd/eLc/SH3lQm+xjW+fftDPhPK+ mSkwbsuY e0uOU5AIC1sVcoEDty52oTIKDG+NgwewlYLa/FXLDsPTkhrr5mO4ZyDig0CAKiYnLz9hVWwsTSsV8jVVFknt2ZJRn/LwCt0tsUeFCSI7BETEF8FEY0LKbCaHoKWHlAhMn5MIk X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > A sorry. I need more coffee, this is not the cover letter, but the > patch that introduceѕ find_unlink_vmap_area. > Sorry. I should post it with a cover latter to make it less confusing. > > - spin_lock(&vmap_area_lock); > > - unlink_va(va, &vmap_area_root); > > - spin_unlock(&vmap_area_lock); > > + if (!list_empty(&va->list)) { > > + spin_lock(&vmap_area_lock); > > + unlink_va(va, &vmap_area_root); > > + spin_unlock(&vmap_area_lock); > > + } > > As mentioned before, I'd much rather move this into the callers. > Agree. There is only one caller, it is the free_vmap_block(). Will fix in the v3. > > + va = find_unlink_vmap_area((unsigned long) addr); > > + return __remove_vm_area(va); > > This can drop the va local variable now. > Do you mean like: struct vm_struct *remove_vm_area(const void *addr) { might_sleep(); return __remove_vm_area( find_unlink_vmap_area((unsigned long) addr)); } ? Thanks for review! -- Uladzislau Rezki