From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D2D6C4332F for ; Thu, 22 Dec 2022 14:43:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 21B8D900003; Thu, 22 Dec 2022 09:43:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C96B900002; Thu, 22 Dec 2022 09:43:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 090F1900003; Thu, 22 Dec 2022 09:43:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id EE968900002 for ; Thu, 22 Dec 2022 09:43:48 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id AECDA140B98 for ; Thu, 22 Dec 2022 14:43:48 +0000 (UTC) X-FDA: 80270211336.17.E52269C Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) by imf28.hostedemail.com (Postfix) with ESMTP id EF485C0016 for ; Thu, 22 Dec 2022 14:43:46 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=aqmE+hzQ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.43 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671720227; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GckSvoHjqniPPLdJ5J0xd5iuOwjkMlztGiQNOCi8koM=; b=hNSiIsxYBzhjx9NK8JmsgPzKKym89nGx1Ixf2PLXfp7WX7vdb4Uf/9oOPqUfhLs765ZZfW CaKhR3jA/im4l7s3UQpBNWMveXPKtvuSZeMeSaKsWA1gUMBsXucsFL6xciV0d+EDks2i0k V3bDImwYVr72Cl1r5W+QZup89Mc5UDs= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=aqmE+hzQ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.43 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671720227; a=rsa-sha256; cv=none; b=HYBdhFl8k5Q9xTd7yPQQnrX4kTam6PoDli3CEdB5lbtVGTQdzxC4Nnp0zGZkuW6YNS92Do 7sMi17hYD28WmT54wgrq48z6xfLIuSAAzTFiqBMZJ+PxWtpkYq9ACdLc1zDjYd/rpza5Mg hS5zLor9fcofB4In22A9n6mdvnidZp0= Received: by mail-lf1-f43.google.com with SMTP id y25so3011730lfa.9 for ; Thu, 22 Dec 2022 06:43:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=GckSvoHjqniPPLdJ5J0xd5iuOwjkMlztGiQNOCi8koM=; b=aqmE+hzQIOMqTYVwp0p0Lf3htEdBdlXTV0IFo4kaMzM1kWqbTxeqk1ZFDfb4mdziib PnFpa2ELQRwPEAtbUBMbItXx9JnIpZXo4MjvgNwibCa02I6VkLVaGgy87VSfw6QSD2CT ppB8MH1F18QMs+id4axaVyAY+Vfm8xprNpUMkufs5mnvKZ85vRfbWunbDFPTYRO66FcP Y//n7ngNFIOewCHjXtQKRM+xWaV21Ikz37ULjSNFdAK0L165D3BgLkntKHTgOZSyVjB/ VVWSgtelywgjTXWt23QHOTLBbd1ziOK6pTNV74PxbDg4W/zHYBGBwve/XbAKMXrakUbk 7MuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GckSvoHjqniPPLdJ5J0xd5iuOwjkMlztGiQNOCi8koM=; b=cKTXX1sg+wpuR3OhZt57TznP+au+LTJYYNKjHoLJi/RUyNinrcm5wRicfoswtU2MSO SFPzYzY5bU2NBQXbG8NxYiGImcUyPIFn12NSKFlxDrrLTrLXeEht4YSM9UlhQl+3SPZP RgZhKi+l7OEYI8cfidm2W/uikNBgt31bKndFjiY2Dn7yhChJyY+ZPmEWQI+CD/54dAfH bbTBoIj86VguLBOnwMDkZO4ZQw9CEj28qHhmdrJksyVJ3JYiuroeGIwHdLkIXHiMkFKB JAxXd+E/OzN/otdyKamae0/qciTTD+JNt0wsnLcCJFmRTK+PB02gSI07qt0Z2pgn2EBp g3yw== X-Gm-Message-State: AFqh2kpOyWql8J5bbIJy2IDxj55HxvsSBiVGlE2CK3qkbAmfxOjjNmR4 SmowZvotVZcSoF3Efg2gw6s= X-Google-Smtp-Source: AMrXdXsctb6dAddiZL45gcBeQjmvOyvVDI0YyEO7TIXBY+cL+FRnHSbPXaoFoiFQ4JpXCU6f3SnYoQ== X-Received: by 2002:a05:6512:2506:b0:4b5:b46d:e60 with SMTP id be6-20020a056512250600b004b5b46d0e60mr1839610lfb.27.1671720225323; Thu, 22 Dec 2022 06:43:45 -0800 (PST) Received: from pc636 (host-90-233-218-120.mobileonline.telia.com. [90.233.218.120]) by smtp.gmail.com with ESMTPSA id v4-20020ac258e4000000b004a2c3fd32edsm87946lfo.144.2022.12.22.06.43.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Dec 2022 06:43:44 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Thu, 22 Dec 2022 15:43:42 +0100 To: Baoquan He Cc: "Uladzislau Rezki (Sony)" , Andrew Morton , linux-mm@kvack.org, LKML , Lorenzo Stoakes , Christoph Hellwig , Matthew Wilcox , Nicholas Piggin , Oleksiy Avramchenko , Roman Gushchin Subject: Re: [PATCH v2 1/3] mm: vmalloc: Avoid of calling __find_vmap_area() twise in __vunmap() Message-ID: References: <20221221174454.1085130-1-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: EF485C0016 X-Stat-Signature: 3ymwifbxpk5cdetmngfthqp3om1jry3n X-HE-Tag: 1671720226-519710 X-HE-Meta: U2FsdGVkX1/hRVbRn1UYcNsTcReVWv8reyIJaGHVQuCD+uPxWjVEZNrASSNt9FLfqRn/mBvFNnOXKrTnJaZMpghoDJF+aE2CO2r4O/pWfe2m00TAOdldK24qvjEDGiAUDsudsP7PdzaovvHaE2WxzlY+XgP8F0YhCL5euqIhFa03NojYWOdoVwf1gTWDFKAg5ZM4iUV//nlxeqWd5gVl0Qt29lm1EVsFyB3fe9WNIBEgyIn0RuOwASxteW3LRm04UYgnw5pp2pwjHqRHCX8W+ZJ1uaAWKm3rStM/MJtie6xtrmd3ZF+fUljpFC7bKyeH3dwlCCIs4hVA8LWwLj6jLz/KN2DsrKJM4NwCeTKxuj1m8ZmYYNLGqYIVOjoRXnetHSOiC4S/4q4f2Qdq51Klbs5Rip8lnwNnl9vgyMUAZFPKy02B9CaBEX65+zpFC68QBbNPSV1LXK1cngoomWZpaBORZp/1zsmuwbRjPOABMnDdoJDxMls8UdehgD0WbS1gscbL7gpO2wMWmg5FWif6/b5S+Ath3Hpc8FJ56A1FPj+a8gF+2/EFZ1ypH40hQtIpEE8MaMHvm6M1BBxldScpoN0R3bRzqlVjKEZBrrvt0PzlT7lu+EkhRZSaRrCaqkCiDOXWRQ1hO9QpY0EvAU7qJciNnoBr32fID0xWT3u84EesDCxO19kmEZjMaaTy7FkHy0uO1tUqjeKqlMrna+FRxA7WGCMPDprQ15tjfGK5f4DmlQTnDLbijAJ8+oUwNeycts6UQDLPlE+d61iBKWtiXQfzj5Ksc0nrBIxyOgdK2R1OjRZ40WcwKyw7nfetoVcJz3NKo8BYbQUcV34tAmKBa7l+NrasJBQg/wwFyJFgXAdL3sUWaoTu11XYeDNDCDlTp7gGBdLdUdBd1NURVqAdDdzZXXgHtQa6Vwgsgq8C/e7hF59ArKnj8GftDP4Oslgw+JLBQ7l11Ar3mQV0mLS jiQAbutz W0lZB8EQXpbIqIWWiSe0GuvEWl6kWL3OHn2AhntBYQ8aMPt4qW4lnCc0cNWxyo5953/3yxASoDdi4KYDxZQoKbXwt8kiTUEAH0EtGe0QRyDPb/gURz/qY+EfChBvLG3lJyN2ZTiBrc8+DGLE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Dec 22, 2022 at 07:38:14PM +0800, Baoquan He wrote: > On 12/21/22 at 06:44pm, Uladzislau Rezki (Sony) wrote: > > Currently __vunmap() path calls __find_vmap_area() two times. One on > > entry to check that area exists, second time inside remove_vm_area() > > function that also performs a new search of VA. > > > > In order to improvie it from a performance point of view we split > > remove_vm_area() into two new parts: > > - find_unlink_vmap_area() that does a search and unlink from tree; > > - __remove_vm_area() that does a removing but without searching. > > > > In this case there is no any functional change for remove_vm_area() > > whereas vm_remove_mappings(), where a second search happens, switches > > to the __remove_vm_area() variant where already detached VA is passed > > as a parameter, so there is no need to find it again. > > I like this patch. This takes off the va->vm clearning too. Finally I > don't need to worry about the va->flags clearing during unmapping > when reading out vmap_block areas. > Thanks. This patch was one of the reason to help out with the per-cpu busy areas tracking/reading of your work :) -- Uladzsislau Rezki