From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38587C4167B for ; Fri, 23 Dec 2022 08:19:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9AB8A900003; Fri, 23 Dec 2022 03:19:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 95DDF900002; Fri, 23 Dec 2022 03:19:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 82593900003; Fri, 23 Dec 2022 03:19:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7434D900002 for ; Fri, 23 Dec 2022 03:19:34 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2FC31A0ECC for ; Fri, 23 Dec 2022 08:19:34 +0000 (UTC) X-FDA: 80272871868.10.DB434F5 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf13.hostedemail.com (Postfix) with ESMTP id B938320006 for ; Fri, 23 Dec 2022 08:19:31 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Kz0LpaGx; spf=none (imf13.hostedemail.com: domain of BATV+a36cbb7ae26730e9169d+7061+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+a36cbb7ae26730e9169d+7061+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671783571; a=rsa-sha256; cv=none; b=C7wlN83v/SKfA8R0TK/Vfnem+Qt7zRgOUccyeNKeUjBsMCsHNFH0p7BdAy2CUyhQl2qwqV FxswIamp6tM7i9TebQvSmIS71VwrvF1TcuE2PeVlBPwhU033cgqK/8bR7FNrE1WbbRDI07 fScr+u7gczxInxOKj6Pn0e7kgZwjNtA= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Kz0LpaGx; spf=none (imf13.hostedemail.com: domain of BATV+a36cbb7ae26730e9169d+7061+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+a36cbb7ae26730e9169d+7061+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671783571; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=A0z7Vp7evF/eeIPMPIPG2cQWQ3aXjo4ZfAda63g1YR0=; b=wxxzzBHcXpvFQS4tdyWq5CnCHxKp/Jox1JvcNnMwFlhAIoWxmMjEaOjjMpcYjkAbLiSEsA q0E77EZsUAGUDrT4wWjXaUx/zM0dhoqvK61sg1zGhsU7zd5+a8DYSgfpsEpjeQCxbxMBU+ ihtjeVKKJKg2HwNXT7Y2imdUEmKIpBs= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=A0z7Vp7evF/eeIPMPIPG2cQWQ3aXjo4ZfAda63g1YR0=; b=Kz0LpaGxoJyNdE9herJniXgh5o PhKtbgT2ypmWtrzm0VZKQlFYFoVDtULFJ2yAjgtPWms6XH5ohTJOQz/6kem0uJCDiBstJ+6iEzie7 nj2cE88WN+Mmf/rbYALJ3QwkjIRctQYiIglerOv7pti+dUL0YRqOljigo4kFEIOCVRjoKYHH9/zka mvclFQOBpcJ8hy5iJ0JgXea3h4G6ITMNTMvENJTazKq0mjtnDxmN5pi15Dd4qlQFu1IKV6zaEnykK s/aUvUo/Jk99AJo0GH77R3CUVnpgyX1FvxA8rnXLYR9jbypIw9rTvT8DOSfqlrd/xsSckSfsH1Ncx qFyzyivg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1p8dH4-0058iF-RN; Fri, 23 Dec 2022 08:19:26 +0000 Date: Fri, 23 Dec 2022 00:19:26 -0800 From: Christoph Hellwig To: "Uladzislau Rezki (Sony)" Cc: Andrew Morton , linux-mm@kvack.org, LKML , Baoquan He , Lorenzo Stoakes , Christoph Hellwig , Matthew Wilcox , Nicholas Piggin , Oleksiy Avramchenko , Roman Gushchin Subject: Re: [PATCH v3 1/3] mm: vmalloc: Avoid calling __find_vmap_area() twice in __vunmap() Message-ID: References: <20221222190022.134380-1-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221222190022.134380-1-urezki@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: B938320006 X-Stat-Signature: gfdhxpamwzu4d5p1aw8nkra7y17mbbcs X-HE-Tag: 1671783571-563907 X-HE-Meta: U2FsdGVkX1/FHNDJnzYKXhL0mcTE5QJP9XeCGpaCLYZa/aqak3Tmhd7OVzH9XGJydUZ4BJc8TN5vTk31ZuBYxEGEulZxD/fAYcUXCuRtnimLRIsZt8YhRBpEia5/SCmcY5qdsvK+LAa5kX76jzmoXbkLLocRvW+ECiMXayEqd/G5GgtRLdU3sQZ7LZn1e7UhiMif6mS+4k4LnDK9CdZjR94sE9gjKRbH2aIuiIRmUCo0Vty0MRycLHey6/JsV5a3Yo8bzYPDx2Vr/+W1nJS+DZOm3KX9kIaYbMRgDIvi2OXNgxTY4CoUFHIhT/eBMkLh52Jz63RVwJStZrw0ZEH0k4f85rXTA2WOQwaqbihlXYFEEX1uecN0Ofvyw+vFUQGBYvC/mn0gce1mq3rXsbbN/Ohv3HI1XYtgHjktxfL+D9+hHEP6CpxXZVceJE0NMrmv0yR42LHHyNPuvxcAZAgU8M6Q6Pp+A3Slv0pfpL0yFdyzas0A6pOjk65hXxwCU6rXN6YrWOQ9n+eoMtxyaghF5sHPXq4LZk4KrsqNkUUIvjeZLaYpgZv25BYAfZUjIsOOHMhNDfsaEAG4NE9+a3Og5pFqU7rUzB8lYLX0wwwTEXcKqPaj1YKlk4BNO7+QA3CDVNgBcjK4hl1TJkcd1etg4GAOA0DG6LpkahL+JDhwtmuwpeVWnB4E8D6+uE7GOWRSZwQ2CQBkH+kt5swpdlHQQ0fOpI+m4nqV1o8twHmwnLpQgdrXr4JYaLRTgW3zuNFUXlbVvY+OvmAh3abU1LYNGBlxyx3JmrRvS1AOtRM3XEn6pBt8F3n4HXq5cZuWmPhhYurvyzLwczycdB/ymqvvZHHqXfx3zVUEnq6FWL2ClUi8BW2CPnbQm4wYFn//mbzAbCZ2FdRjkc7s0JBUtrkYcpbrguMGjuzGEm8MacFYqm8y2tTJAJXMozSwaX1s9osI9eS6m9e+ABBiDwsJ7dp u30io4xR 82j0IJIrgIqEt7iZ6r16UraPTZySEsOpAiZXgTk1xKiDSEenQuh1lTbvoswYwF9uDZcWYjI/gziEvG/Wwrtc/w/SFzo9PrAyOU5/J6AXtPPbaCh57krsXm4vEl0Y9UzMrSVqki0kDs03C8P38RR5YaQSHD4B607pz1RvxNP1r6Ra6MwlPMcu16aLgAA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Dec 22, 2022 at 08:00:20PM +0100, Uladzislau Rezki (Sony) wrote: > @@ -1825,9 +1825,8 @@ static void free_vmap_area_noflush(struct vmap_area *va) > unsigned long va_start = va->va_start; > unsigned long nr_lazy; > > - spin_lock(&vmap_area_lock); > - unlink_va(va, &vmap_area_root); > - spin_unlock(&vmap_area_lock); > + if (WARN_ON_ONCE(!list_empty(&va->list))) > + return; I'd just drop this check as the function is not exported. Otherwise looks good: Reviewed-by: Christoph Hellwig