From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C87AC3DA7A for ; Fri, 23 Dec 2022 08:21:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C4298900003; Fri, 23 Dec 2022 03:21:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BF281900002; Fri, 23 Dec 2022 03:21:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE14B900003; Fri, 23 Dec 2022 03:21:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9F5E5900002 for ; Fri, 23 Dec 2022 03:21:28 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6B08280F5F for ; Fri, 23 Dec 2022 08:21:28 +0000 (UTC) X-FDA: 80272876656.27.A2454E9 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf19.hostedemail.com (Postfix) with ESMTP id 01C431A0007 for ; Fri, 23 Dec 2022 08:21:26 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=3qgbEKZD; dmarc=none; spf=none (imf19.hostedemail.com: domain of BATV+a36cbb7ae26730e9169d+7061+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+a36cbb7ae26730e9169d+7061+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671783687; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=O4FuGc97E/9yF2FvsvebSSi8vDaekl1kBRy8Km56N3c=; b=BlFQCP4W3iGtQLScwEFf45cfQ0bcXRenUqM4rUWJ1GdK3RJUQ3u5b4tBhfkvEbDzezv3k6 zGy7WUZ9nY411HcOtx74HPeoMkip9EEcaZGRn0WCEu1tO+rDSgy2VgjuwfSxYhwq7HQAoy I63w24D0Dix0TL2vjuUfoK0WI7wvd0w= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=3qgbEKZD; dmarc=none; spf=none (imf19.hostedemail.com: domain of BATV+a36cbb7ae26730e9169d+7061+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+a36cbb7ae26730e9169d+7061+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671783687; a=rsa-sha256; cv=none; b=lISgRc7kYe/YHn9aYRQkxHPS1ch/kR0jDxFyaoiZRfJbF3MY1WxsgeG4Uzb5o5YfDKeHZl yDIVHoP9FlNJE2ZWEnnAy1sou8tq9s0sRCgznZ6B8Qx2dqXt773b1G/XoCJ0VkAvTGGOOV 08qZ/YKcyOAfQ4G6VGkRm8bMTsCrO74= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=O4FuGc97E/9yF2FvsvebSSi8vDaekl1kBRy8Km56N3c=; b=3qgbEKZDXAqmEavFKivByD5rN8 uPtjcmZ1BEJzE1/Ut0mhxg0mEj1IDScC+8c9zRg09ExE0Cjz3EJ3vUHSTUp0z00UBoXOU2unRO8J+ FPuh3SB5/TwY5/9xF61oIhRj7qsd8puDZWB14KaSk16aCP2xIXj7FodNf+RgCidYg2wrEOCsEdIiL MElHDtwWQhsnDYOi9AJEsEQ69Y58pW39fXZxzIk+Emvq2FUJbogXkTbPm+/MFb623ot3KcWR/MF5z gUHbVlEZtcZ0WaBOumS4/NWN5yRWwJDmF6xFAulir0TKAGNnn2eUHL88bIBm1rnuxr1hpfZ/3hwi5 k2nw4Iew==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1p8dIx-0059UN-Uy; Fri, 23 Dec 2022 08:21:23 +0000 Date: Fri, 23 Dec 2022 00:21:23 -0800 From: Christoph Hellwig To: "Uladzislau Rezki (Sony)" Cc: Andrew Morton , linux-mm@kvack.org, LKML , Baoquan He , Lorenzo Stoakes , Christoph Hellwig , Matthew Wilcox , Nicholas Piggin , Oleksiy Avramchenko , Christoph Hellwig Subject: Re: [PATCH v3 2/3] mm: vmalloc: Switch to find_unlink_vmap_area() in vm_unmap_ram() Message-ID: References: <20221222190022.134380-1-urezki@gmail.com> <20221222190022.134380-2-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221222190022.134380-2-urezki@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 01C431A0007 X-Stat-Signature: zz99771hy6gc1di31bwaupw95b7cs5bz X-HE-Tag: 1671783686-753769 X-HE-Meta: U2FsdGVkX1+LQRYkbtM+YOiEdljsBxquKA69oQ5PVIk0K6hopabi6MR8m8Dh7G5jsTC9GSnU+ENNg2/c1JL4TtAZfvOJFJW7H6zTv2CZS69uR7E/4/Hb7RYIFPdAxEPIC+I5KXX4q8ViQMYrFBKCe6c2wR6kGYUlIvDB/Pd1RQqx51oNoXfvpeQwhYux1/WTuCcDmywIAgliM66PoFkIKHreHxY7XvOH2hfpN9OLP8rBtUXnRacHiFOrVvQTo13ahV2su34a+XilBJwUbTg+pFChYadZ06G3dK9QVa+xX6KP9mMaNfm3A4MdFC6fDiuF2T+eR3TJipBRfqNBI7hXZwnlXtjRYbfQ00rwpwUdofjye03f/Vf3CFnZCsQFkXaEETfUJ02UDDvxSfXoajcHTeRytL5/aX+DfbRA0lUnsUnMppfitj1GDavkOpXmLjYcmtwernpYNQxhOn99THmG0E262ZlrgAnnRbB+G8fSvA51FMFHsPNZr6DPzAEPZHGL2/Ii7aCLedwPLZH67cMvijNTaRN6wGOtllrya3hYsgSUHwxjU6AkqBjviRFVJaK/vpefyGtLbL0kjUM4dN5w6WDI47UBYahVeqZDr6E6O8eZYtfqR6j5tczK+VwnwoUWEeGVU33mzmJFntz/fHt/3YceT9zwki8O9HQIHLyHwX96xsdUAQZ0ni1n2gh3gynZUIUjEfw2JRNN1e2s8+5TJv5d9DR+0UgO1sd4ScwN2fbq8m9fDHtHCMnMQkiEgxhLJY2N3SN2iobtiPG+a/TMvA+ceVvKFqjMYgnhdG/TpYS+M4EuO4JOZisZjiNH+U23qddHBsIiDnzjifGp7PeGb24muDOQA0gijuYMF8TXnvY8VPTLslNvZuP+/z1EMlLYFPQXy00VTDMSrvScNxnazYQrfIs72bLZw/uIhwrONk4HalH7I+DuJASOTRQy63JzQMlc3A1W11P0klYLHW2 xHvx8fuJ HHiwlQsfvVSg/4cPCqcNzBNsXJiylHeL8sLzDa4i6/oZhhtV7MXCRHOJsIESX93pS4ayO82vtQA+gFRL4gCdU+G8UcrphCVe8e1KJ2PK2OM+pF2rDR9MyutIdDDSDEVu1aq+NvThbKNBG10fSRfSf9z7vKJJmSKEl07QZn+yW4+K8Rm31XDiXZkGGsA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Dec 22, 2022 at 08:00:21PM +0100, Uladzislau Rezki (Sony) wrote: > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -2252,7 +2252,7 @@ void vm_unmap_ram(const void *mem, unsigned int count) > return; > } > > - va = find_vmap_area(addr); > + va = find_unlink_vmap_area(addr); > BUG_ON(!va); > debug_check_no_locks_freed((void *)va->va_start, > (va->va_end - va->va_start)); Don't we also need to remove the manual unlink that was done here previously? Actually it seems like that manual unlink is missing after patch 1, creating a bisection hazard. So either add it there, or just fold this patch into the previous one.