From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78912C4332F for ; Fri, 23 Dec 2022 16:27:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C39AE900003; Fri, 23 Dec 2022 11:27:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BEAED900002; Fri, 23 Dec 2022 11:27:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB154900003; Fri, 23 Dec 2022 11:27:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9893C900002 for ; Fri, 23 Dec 2022 11:27:23 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 532B3A026C for ; Fri, 23 Dec 2022 16:27:23 +0000 (UTC) X-FDA: 80274101166.05.5EE479F Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf25.hostedemail.com (Postfix) with ESMTP id 708B8A0020 for ; Fri, 23 Dec 2022 16:27:19 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=n7lcCdiE; spf=none (imf25.hostedemail.com: domain of BATV+a36cbb7ae26730e9169d+7061+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+a36cbb7ae26730e9169d+7061+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671812840; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tvgYFs2FAZdH+/felJr+94xqrzl/poYnFOMsR5Dg6fA=; b=GO7IHUt9ei4boVNdjjWvASyIyELGgjdzxIBFEY4Hiv9CLuEoL6Wmeu5mX5ZQDw+koon7ii Ggsa78MHMkLo+NWv7Yh7O9+SNee2HBQHhl5x/9IRzm4wlyHwA0Yn4LHHNBnAg9VEf5iiNL W6+BNwhoRPYqBiot8X4m4m3H/BYPTq4= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=n7lcCdiE; spf=none (imf25.hostedemail.com: domain of BATV+a36cbb7ae26730e9169d+7061+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+a36cbb7ae26730e9169d+7061+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671812840; a=rsa-sha256; cv=none; b=t23pvqyeyrPr5c3D+qDPdzC1hf0KBJ8jnCqWsnhxq5t27FCs10Hpp7ciXTily3P0chHYtR UcOCM7yzBOSZXdVog01Glb+Re/ReMKdqcTDgJ2kCkA+9AVDXu2UZSHefzTAYoM/VTW74OF zr7Vihqf1F0kyiG+SGbp1vRlU/CKWI0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=tvgYFs2FAZdH+/felJr+94xqrzl/poYnFOMsR5Dg6fA=; b=n7lcCdiEfcq8NCgXEDNF/0Z4ci tIOpRAdjDXVUvE+5DzvrJ/9KcCMujjvsihTERwfIZtXtW7cfaSsL8gKUqzMyoqVPAuofBgFa35SaB eQ1a1u6TOi/d/R7Vm5HFe4N9BX10usAzaGFrUU15vE/Rp65o4AsfVdY7lDi7fEDOqTAv29Gk+rfsP x0FQmjE4t+01NANuuhbsYP+Q46PaNZUvkjZbeCs5rLNn0M9gxprited5koJ9kFvTzc2h7pRCrgsrh rRT4+62twBnE/keGANDiY5jPmax6kiPnXxTrwnrL02TafuDXWZfPgmANs4Q8lAfIEfRfYyeh0pO/9 m+4fvEuw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1p8kt4-009yDY-Rs; Fri, 23 Dec 2022 16:27:10 +0000 Date: Fri, 23 Dec 2022 08:27:10 -0800 From: Christoph Hellwig To: Mike Kravetz Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, netdev@vger.kernel.org, David Hildenbrand , Michal Hocko , Peter Xu , Nadav Amit , Matthew Wilcox , Vlastimil Babka , Rik van Riel , Will Deacon , Michael Ellerman , Palmer Dabbelt , Christian Borntraeger , Dave Hansen , Christian Brauner , Eric Dumazet , Andrew Morton Subject: Re: [RFC PATCH] mm: remove zap_page_range and change callers to use zap_vma_page_range Message-ID: References: <20221216192012.13562-1-mike.kravetz@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221216192012.13562-1-mike.kravetz@oracle.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 708B8A0020 X-Stat-Signature: byh99qj9jqknhyh8mtmm8do1jsf3uji7 X-Rspam-User: X-HE-Tag: 1671812839-474884 X-HE-Meta: U2FsdGVkX1/OeSr6EttTO4PNgEDX4rplqzh4S/avKXR+cglykgdGOSblbvckLHe61ckoAwHPQ5/A/ZF4GI5dWF7XnnTn1VOYch+IJaLsiloXoEt47Rfmk/0/ZSu4z3eyA/pO1WV/ys9hec4KTRHtlPmOsU3sJo5TJAo3cuuIayISikZQgF/X3cwVrHFCWDYWnTLP2imZ5Nm2SAuE0WG0COA+SSbYWSSaiO5nKnze0orT6oaGykmI7tVpZEGR7dzKMRDSkLzXezmKHzGuMc6QzPAM5BCx0FHRnyaaBOhWgtuIWE8nxudxrVAw7uOf/ZUF7dRzKLHt1t8cZEXfMbmQiVzJV+CF3s8jyliCH04A/1/Xg1q6GSMsptVE9pvnYQ3E2v+01jmKWBVyhlEO2SAKg9FuBDa6gw+yaB4pq7cpL39Kafvl5BCAIr7uacn7u7nRfg6bJIM+EvhNKNxkWG0afJTBEEbL/+nbbf665TzMgyNN7empK6bVxjZ7EFDJchzWh0XDSyXYQkyBXUMaTF71qgwSFweUzR8GVCgoCS/JxGbBWgfT7SrkooSZP4d3PuJVz8Vq0SnZw/XXdROkOD7Dy9WNnVNCwi6UQ8iTPrr8hKdJKg01T2LB+ZmQDcIqtTgqO6mdbOktraZY7oObuf0TveSc0yvLL7u3xfrxeHEzT0l2KJCPfsRAQEf1yulFSpoIAUqw20ysU8Zv1R+WsjA7y96+PnFM5vp6tnWxa+hcZkGlCssMuTFaJjXKjjCFBkLPwo/R6yu4KJIgFJMX6+uouWnQ/i0uNMWeI4JfXD15o6+XoQpmxubR1jHbudeGtmqWUvJ2mC6rZa1AjRpsy+Gp6JImKoUanx/+cu2O9TxZ4612ooSL258UqrAX3oTEOtTLUDBw1XMbDgfnRTzfcxXcnS6oe+uh70q0XWDPfvjgr0qM0U3SK+tI5ltjS1LOu6ZOnny6NfOouLjPiz0WAcU s1cqJqfA S53+23yvoKjGqkrkbfmutopbQJbTjdzaxtkkV/To1UyMOFe3vQrBeUwndb2PvAFUHh0ruKtrSt3YxuQZhU/fSTkEmK6szMAfQfyBkCnCs1xiAkNA/Wi4OX0zS2ae80B9/ZPh/A66YW5XEXfE2E1z5k6bxhB/ypWsfHJaBgptbv/P1wM2BAezjPrRq9UVrhcVHZgcYz6bBhEeaXWfZgZU1C29qvJYCxKmAKdxw+J9mE9O4g/1fnMHl424Q/0PppoVvaG0f X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > unsigned long size = vma->vm_end - vma->vm_start; > > if (vma_is_special_mapping(vma, vdso_info[VDSO_ABI_AA64].dm)) > - zap_page_range(vma, vma->vm_start, size); > + zap_vma_page_range(vma, vma->vm_start, size); > #ifdef CONFIG_COMPAT_VDSO > if (vma_is_special_mapping(vma, vdso_info[VDSO_ABI_AA32].dm)) > - zap_page_range(vma, vma->vm_start, size); > + zap_vma_page_range(vma, vma->vm_start, size); > #endif So for something called zap_vma_page_range I'd expect to just pass the vma and zap all of it, which this and many other callers want anyway. > +++ b/arch/s390/mm/gmap.c > @@ -722,7 +722,7 @@ void gmap_discard(struct gmap *gmap, unsigned long from, unsigned long to) > if (is_vm_hugetlb_page(vma)) > continue; > size = min(to - gaddr, PMD_SIZE - (gaddr & ~PMD_MASK)); > - zap_page_range(vma, vmaddr, size); > + zap_vma_page_range(vma, vmaddr, size); And then just call zap_page_range_single directly for those that don't want to zap the entire vma.