From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3388C4332F for ; Fri, 23 Dec 2022 16:41:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D755900003; Fri, 23 Dec 2022 11:41:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 66055900002; Fri, 23 Dec 2022 11:41:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5285C900003; Fri, 23 Dec 2022 11:41:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3F349900002 for ; Fri, 23 Dec 2022 11:41:55 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0BF7CAB5A8 for ; Fri, 23 Dec 2022 16:41:55 +0000 (UTC) X-FDA: 80274137790.04.891096A Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by imf09.hostedemail.com (Postfix) with ESMTP id 4F50E14000A for ; Fri, 23 Dec 2022 16:41:53 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=VwscvEKS; spf=pass (imf09.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.42 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671813713; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MmhfakGpyVCikNZqo5vA4AVAUNDRZRX05/SqVLdJr/8=; b=NCfYkBSqRnlG4lRhRXDEK6lFl8n4JeDrjp2cQ1Vfp1pq0AoIIvi5Z/HVSXsVAdE+PsoYLr efVGkaAjQKU/4gOHvuTpRg62wB/qeunLPu+5GzqqWQacmvCRQCnVr6tFni3yDC4VQNFgWl J656c25VYnEQCM9ShVyl2guH9ppA2S4= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=VwscvEKS; spf=pass (imf09.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.42 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671813713; a=rsa-sha256; cv=none; b=1uLNFHMZRcfV67G3Z7/WPBrsGMUKmCStb0eLd2rAKIDIgM1s/CjTx0gYd2vyA80Z8cU+iT HDMFbSMyRStDHH28AoRxXE6cHBHK865bsBK2/ObcD5H4nhtL6rAQSWoZTMDYNC7dVS/L0W cTBIj+CYA2WWX0HxxsHxB4xASA9/cdA= Received: by mail-lf1-f42.google.com with SMTP id b3so7722466lfv.2 for ; Fri, 23 Dec 2022 08:41:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=MmhfakGpyVCikNZqo5vA4AVAUNDRZRX05/SqVLdJr/8=; b=VwscvEKSkFwYmOi31z1ts+1/id4+H2UeVemaweigQNsCyC69YoLeOAXw6m4PwBY/83 0UXzpJe+RGOWVJVPos5lj74DqYcPoQ4Hsz71hvvIxuu8FBi4Q2IO9wHaEkYHNT2zXiaY Z3DeFY7WrNHSg6xpcY2z+BsvH3LmqSEggPI7aVR7ZVVBjATyljCTg75ma3mTx0fCBAdZ 2i/Rqk87kcnPLFJW6jpjd6ddFQZqls4k0UW2ucVIJ/CIswN4IlyI+KVUgSHOwNRLrNwG BMPGZ4FaGIKNtVlL1u1UCdU3pC7PSe8Iv5dIb91adP+sohb1M+8vTqMR6k8YvGPlMIUU GxNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MmhfakGpyVCikNZqo5vA4AVAUNDRZRX05/SqVLdJr/8=; b=oHC6WieQ/N8s82TaUSYMyfwJG7QIfRztll+FflTS8Qr7kj6DJs0dcjzsUO/LZdMFnQ WRbWOoN2ZXllhmAF5AK4Zp8aQu2nBu9nbQJpgubjSQJtttToHhxc/5uC4zCmevgbm6iN +8rLv4W/0SXDg9Lc66Rs9+CwHNAWpSmjCKem7WTkBKpJZJ4owM4febGe6qfV9y39/veg 09hYTcSXgA4c44ZPjvcFL2+2FXsl2eWn7C+rtv5G2VxImWplrOWjkEb3IFwj4wlZ7pYV 2c57iGTKsmb9udOQwpb3Px7KXY54vJCkB7PHyDxWbS8baJq3uWl1/6496pcPjsyTFBtb /QxQ== X-Gm-Message-State: AFqh2kqy98lNAWZ1La5khjOr5J06oS7oWYW4AY5CeBga/4Om2rpu03mZ QqAfgA2f5nMPhqNgmT2NmLE= X-Google-Smtp-Source: AMrXdXu9m9TkG5fdOfvdxJzH4AT1SJRyP9f37iVtxBdUn2ja7OctXgAcq1RTtEEgAap+SQmQRsybiQ== X-Received: by 2002:a05:6512:2624:b0:4b5:8e1e:867b with SMTP id bt36-20020a056512262400b004b58e1e867bmr3377028lfb.59.1671813711494; Fri, 23 Dec 2022 08:41:51 -0800 (PST) Received: from pc636 (host-90-233-218-120.mobileonline.telia.com. [90.233.218.120]) by smtp.gmail.com with ESMTPSA id a16-20020a2e9810000000b0027997d00fc2sm500724ljj.21.2022.12.23.08.41.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Dec 2022 08:41:51 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Fri, 23 Dec 2022 17:41:48 +0100 To: Andrew Morton Cc: "Uladzislau Rezki (Sony)" , Andrew Morton , linux-mm@kvack.org, LKML , Baoquan He , Lorenzo Stoakes , Matthew Wilcox , Nicholas Piggin , Oleksiy Avramchenko , Christoph Hellwig Subject: Re: [PATCH v3 2/3] mm: vmalloc: Switch to find_unlink_vmap_area() in vm_unmap_ram() Message-ID: References: <20221222190022.134380-1-urezki@gmail.com> <20221222190022.134380-2-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: 8hzocbq8e6wem5qqmdczi5uefompoctq X-Rspam-User: X-Rspamd-Queue-Id: 4F50E14000A X-Rspamd-Server: rspam06 X-HE-Tag: 1671813713-637615 X-HE-Meta: U2FsdGVkX19Vj1Chw+xw0bbQhueRk3d3IwBsBYPpuckmmQAkKLoJbsXshe/LczUgBO5B9bavnuuI+LM1wfNax9dsOD4w/B+WS17e6L+jxZYwXC8e8/WID+XvTfx5RpWW4SxocUOFRv92IaK6rji5t44B+GLs8jdbeY9Ra+VwAQlSa+/7rD8a6WR6Acb8WFqlhN/nWJIdUrZgBMkLfvWTMnOwByBUAqX89DDlBRzhdLdgUTp9GKJu4diCq3oKMQZTJD4LBhB5KACE8+H/BhH6FlDgJliXcPwtQal0uPx2YknDuCL71qVA8L/KzGhW8yTVHRjyQIu23fqq66lNcE+arY2jQp8JHKBpHrONxXqHecuugwBoS6gHDz8JbB5NB0GOBfg5+P+eEzvGjCFrTF8VIX7hfqHDU3nsqdV2ap5GjkPQnuis6vf/BNUDjn7ugfVZom0WHuqshqpvBl9Pd2CF8OIjDezwsn/xTa2kjuDgB/gW07pl5UIafcGIFqzGEpococUQj7ikOcoQKG/1I5AVd/wxAosf/tQ5rzFkTUzejGnNTnkNfBjMTyFDDEY0Arbg4qZSf+It7j7h0GRek3COnhkcpcmwfXfII13TH15vmKTvmVrPjA2wYEhmyfsnYdqeAHXndgN0S5XXdBuYS473AF2oHEQ8CuuJocS7mYGbWPraeZ0OalFlkNjZ738STrao7X9M9QAuxw7pWhHQKQX7fMNBCoREiB9zYvsmiqeJzXm3kCg5ywM8o2zW4aBBpTTySDS6/YL0cncb6AIgyThcPkXTRz/E6zjOUqX4i4TKWSIsMi2lzFUSAiFHdMrvdFbkuKjG967LI4dQiaQi7z2GpF+LkT+k9eIDS3v+aFodxNROk2LMUywyCvHyTT+zCb6bNAtAe8mFI6/nbHoKpNTYd6uuqJ/Uu2nLhRXu7X7329nNS2qKplTkciXx/EMEjZnWHHGX/RBo+s0NO1GKZxN 0LF9bdXs ulSW/HbFv9SgnzyGXf1SXoYiuN89zvClQixpes2tK7vYQmDBtlmQgahRV2C/cLiiDBihk09e6piS0TX5iDjNXwm2pziVJY64UHaPb7mxEZc3iGv7edo8IRXoVvzpNC1SsR5UV3Wf+wnvO+Q0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Thu, Dec 22, 2022 at 08:00:21PM +0100, Uladzislau Rezki (Sony) wrote: > > --- a/mm/vmalloc.c > > +++ b/mm/vmalloc.c > > @@ -2252,7 +2252,7 @@ void vm_unmap_ram(const void *mem, unsigned int count) > > return; > > } > > > > - va = find_vmap_area(addr); > > + va = find_unlink_vmap_area(addr); > > BUG_ON(!va); > > debug_check_no_locks_freed((void *)va->va_start, > > (va->va_end - va->va_start)); > > Don't we also need to remove the manual unlink that was done > here previously? Actually it seems like that manual unlink is missing > after patch 1, creating a bisection hazard. So either add it there, > or just fold this patch into the previous one. > Right. In terms of bisection it is not so good. I think folding is the best. Andrew, could you please fold this patch into the: [PATCH v3 1/3] mm: vmalloc: Avoid calling __find_vmap_area() twice in __vunmap() ? or should i send a v4 instead? Thank you in advance! -- Uladzislau Rezki