From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A042C3DA7D for ; Sat, 31 Dec 2022 14:47:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F141A8E0002; Sat, 31 Dec 2022 09:47:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E9E728E0001; Sat, 31 Dec 2022 09:47:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D643C8E0002; Sat, 31 Dec 2022 09:47:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C356F8E0001 for ; Sat, 31 Dec 2022 09:47:32 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 67A49A03A4 for ; Sat, 31 Dec 2022 14:47:32 +0000 (UTC) X-FDA: 80302879944.22.52553C9 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id EC0CA100002 for ; Sat, 31 Dec 2022 14:47:30 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lIY7vzm4; spf=pass (imf05.hostedemail.com: domain of jarkko@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jarkko@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672498051; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mlJpr/5pf4W96pVMjYJBMPpmReNCN+e5FoUuFRM1CtY=; b=dPkiZoaGoUOVm/eMFWx69YJwFCJNvUQv8KwjUIyYHiI9rAoPBzkutG6SsNfhpd9gQkodbb Xho9F/TTUsy3c2+AJtCdtEcaES0KLkY4S12UKajY4JwCXZ/ZrKR/r//UOMK15jAozgfMrC DGgxJNZx/zpdyJFfD6e9mqxVnXDvSTg= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lIY7vzm4; spf=pass (imf05.hostedemail.com: domain of jarkko@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jarkko@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672498051; a=rsa-sha256; cv=none; b=shnU98xlm6QRi9/5M+QuwZEO9ggLlruYMZ0ZjdXb0uQ8lnbE2/O63vSvuGfwgHwudJ55kH GM46AfKV+GGH9PdynES0s/KpqFjydV4VUstkWdaKV1DlLSgButGhytuvsMx+cDcUD105R9 zF3gaxCCt/P4aVmYo5nH8dpKPZriyBQ= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C7E7E60B88; Sat, 31 Dec 2022 14:47:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A32DCC433D2; Sat, 31 Dec 2022 14:47:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672498049; bh=UGpp3BQnLywMc+IwqrXFtehnt+EBA7KjAILtO0nqptM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lIY7vzm4K43+75icSufgFEc0kgcxL2ZP8dUliPhh9JB3duD9CTs54u3AOOMSQZrF1 UQB2f1IN4ei+bZrUQO6RRgzYAJTMGZaiWxOV2kgOPz9NnUaL2vB3NR3C+Oxse4t5h3 eUmyO61nSBc3f9D7AT9EkZF05YJciNwhIYsEZEX5NXEzhLYNPDq/8HLAp+Icv5mZEw +ubE0VsZPeljN6JV9IaKmAs09D9G16fHIV0soh8ihctsw2rerJI5kZwLl0wjIsICX2 QWmBwxPPcbOri1mUmdut0m6WXealsXERwCa7G4O0ZYUazbiSZu40MOJZTs2kF3PNWr fdHIZfRHyYX9A== Date: Sat, 31 Dec 2022 14:47:26 +0000 From: Jarkko Sakkinen To: Michael Roth Cc: kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, dgilbert@redhat.com, ashish.kalra@amd.com, harald@profian.com, Brijesh Singh , Pavan Kumar Paluri Subject: Re: [PATCH RFC v7 37/64] KVM: SVM: Add KVM_SNP_INIT command Message-ID: References: <20221214194056.161492-1-michael.roth@amd.com> <20221214194056.161492-38-michael.roth@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: b7sfpq97zu5hppg9iwt7grsatnbw6uea X-Rspam-User: X-Rspamd-Queue-Id: EC0CA100002 X-Rspamd-Server: rspam06 X-HE-Tag: 1672498050-1981 X-HE-Meta: U2FsdGVkX18vBbIIa541IjKEu/RnFhUlEfsv6W8Gtv0nsFQiypXOhZrF1Uou/DeiodQ0INLZOy+piBp9I6uMIjti9rXwos2qG+BfoxbzJkf/WzDClcnpGpAk1OohpSgVHET9rWU38EWUPdp17RogdrY2Aj/8GcT+H0IejEbn9DY8HsJiEN1oLbOQXb3u+EiVDPUgUm32k5pNPhI3rCT/114luNfFfGKLWRkM3A11VS59Z20fR02pIX2LFbYS522RtzGTKOZ6E6fP43qWmcQ9AMZtVd9HrBPReDUHSSIcdxy/sRKW/GAWCK9PMKcMI6A2y96Bx5PaoDBhbleGBsk5AYeZMeOtx69Ontjfx8kTqlam4qCXUtamQCD3wnX1/2d8kdlalj87rYd/vIRxCVOI0M8BT6SJ3k3RFolqTT417+NMqgAGo3twHV9i+BrHktqKUf86dNzD0m7gEB1AYg5hMCkuShyVEnKk2mGv5sjtOMo3CluWpVYwIbvCWgQyPzRGMOWjpTKe//O3uF4WieMl8Ms6YkTI1qrC4qH9omagZj+RznTuu6HT4mOWtm8XvlMlGgd5x39c73lty1WrN/fK3enqrH6Zb6Rsaqj04mKrkLmq1IbFk+lOFH3a/UtBBP/ArnBuTKR4aeM2Oh6IQkNDUiIb+h+JdUDlVmBvrhzOUAD50k0enmKAw/2oxDD1hogVLeSlKxUTwBMu7DapiAMwl0rM1byK79O32PHz3s1hNA7JPDHzikwidjoew9H0WD9d6eI2KYLDOYfMqtQ3el8WQCpOLq8K18w8/H11CPRlEjxDDvUULmzK5usAKNIKOoyS4A4WAn6MrfV4UVecJhpXvhbRBTEf/tKT5MSHTLVPqYZjReqJ3T4if6Hy8r9+xVfrfqswRlR5hdr9ZXhiIegctErxlCxU53qz+X7xCYMdkynOs+k659qa5kGdHYpeAIM6uIwGMAguCemm0p4InhQ R6OKaJx4 HAaG6b0bl5OxFOeA0UX/QnV51CeHGUypC0Su1ZoAawZ1urgDwUUfJszpZIXGhENppkDO1QBFGjhWoAuN+jf83LxkoKA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: A couple of fixups. On Sat, Dec 31, 2022 at 02:27:57PM +0000, Jarkko Sakkinen wrote: > diff --git a/drivers/crypto/ccp/sev-dev.c b/drivers/crypto/ccp/sev-dev.c > index 6c4fdcaed72b..462c9aaa2e7e 100644 > --- a/drivers/crypto/ccp/sev-dev.c > +++ b/drivers/crypto/ccp/sev-dev.c > @@ -1381,6 +1381,12 @@ static int __sev_snp_init_locked(int *error) > if (sev->snp_initialized) > return 0; > > + if (!sev_version_greater_or_equal(SNP_MIN_API_MAJOR, SNP_MIN_API_MINOR)) { > + dev_dbg(sev->dev, "SEV-SNP support requires firmware version >= %d:%d\n", > + SNP_MIN_API_MAJOR, SNP_MIN_API_MINOR); > + return -ENODEV; return 0; It is not a failure case anyway. > + } > + > /* > * The SNP_INIT requires the MSR_VM_HSAVE_PA must be set to 0h > * across all cores. > @@ -2313,25 +2319,19 @@ void sev_pci_init(void) > } > } > > + rc = sev_snp_init(&error, true); > + if (rc != -ENODEV) if (rc) Because other wise there would need to be nasty "if (rc && rc != ENODEV)" so that this does not happen: [ 9.321588] ccp 0000:49:00.1: SEV-SNP: failed to INIT error 0x0 BR, Jarkko