From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5171C3DA7A for ; Sat, 31 Dec 2022 15:16:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A11E8E0002; Sat, 31 Dec 2022 10:16:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2512D8E0001; Sat, 31 Dec 2022 10:16:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 118D68E0002; Sat, 31 Dec 2022 10:16:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 02A318E0001 for ; Sat, 31 Dec 2022 10:16:53 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 71B931C60AD for ; Sat, 31 Dec 2022 15:16:52 +0000 (UTC) X-FDA: 80302953864.12.6A91024 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id E3C7740011 for ; Sat, 31 Dec 2022 15:16:49 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=MSqK18kq; spf=pass (imf01.hostedemail.com: domain of jarkko@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jarkko@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672499810; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=U6wBI4J1hl6vg+OhVLDsZDGkCmTqz9MNCxaJXngVatA=; b=oLtW3785zx0TgD1Ldr5lVvKcYgQMI/+Yq0/IJH1+OVAnoKwnx/vjpEZI3/vS0TL7UOSAwI Lc6t1aGkar6u6rtA0TdYJP1D/iyD9lPzV36qKBeQ3tfbfAzbFtMYedGzKekWh9g5JQZEZX clTaH52E5XuEBmbfbCr5Kmh2Ap9d8OA= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=MSqK18kq; spf=pass (imf01.hostedemail.com: domain of jarkko@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jarkko@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672499810; a=rsa-sha256; cv=none; b=L/5GrFksSrgTtckqmDupe5FADZJPLRRFzKzunfucpefWnTBaXa2R2shrozyhdmBP/577Kc d3+o28xOMUVHR/93yT47eeIV3xW0udts7+ZmdK02vR8OgbBin8wLocA01rc31EUWLQ6K3M hr6xJvYtgsr51gSfU6r5sWU8zOEPAYc= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D5E5260B88; Sat, 31 Dec 2022 15:16:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C0190C433EF; Sat, 31 Dec 2022 15:16:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672499808; bh=E5b0+Tex/od7yWpcV4nYzqZ1OMql0EqcYI9TkDd+6UU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MSqK18kqooBPs0gssQK+KGvL8ppzWQrcmlIRDw0J/x8gYG5zyYMHMmw5BQYmcBWfA 1RyeGCz4cwim395EYMRaSgqL8Y4a4bJPRO101rH9ojdrTKeLT0drBEX9/aGJFAaPfG mWL5h2IbMNUzK0m/urKGC6o29WOl82x31dd5QBFkeYNoV0DrJxnHQo9JXXJ5SOsYb+ h80eq/BXfRnnOcLjtJJsk8f2Dbi6ia0G9j8hv7Z9eBQ1QNPOPOG3ztSUsYfODODaau EMwKhhnmD7WvxIKcjJWWTwrtxdnpWTbvIHSoHu6OQuER6RKfkwZyYTRc9Ida/jxpWe WX+rIU11NRcJQ== Date: Sat, 31 Dec 2022 15:16:45 +0000 From: Jarkko Sakkinen To: Michael Roth Cc: kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, dgilbert@redhat.com, ashish.kalra@amd.com, harald@profian.com, Brijesh Singh , Pavan Kumar Paluri Subject: Re: [PATCH RFC v7 37/64] KVM: SVM: Add KVM_SNP_INIT command Message-ID: References: <20221214194056.161492-1-michael.roth@amd.com> <20221214194056.161492-38-michael.roth@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: E3C7740011 X-Stat-Signature: djkgugzqb5yoxu3bobbu1rf5t3k4na4p X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1672499809-93139 X-HE-Meta: U2FsdGVkX1+F4Qnar93uXtwqmjWsiNSVa+uBaWsNkqEn/pKhKGbaR2Fzzfg1jLlEUq5/unrn7Er/PSOXRAX3VD4TS1M5fNR0ET+V6yIiblcIgxlHqkPjlUhopxfCbfXmKVgzxDdYa2X+SjEX06z8iGxc0Qybmu+/b50AM9FvZTCVK9M1g/pAtwyk0mzMjVmUPszxwIgDSZ/OT8z2K7Kc7T0CLH7UNCGfGq6V8Cyv1NxrjmKHbHvev5I0AD2CzAlC04whvT1nWgqqE9kwsnvgLHCWCq7bfUSv7ANIXWX0XDYYq6FAnUpfCsGPbo0phDa1+BsP8HXzaY3mRshkKzlR3GtVhRK3Z2q4tfez93peXYDnLn2QGf96ENasbWnSsuuSvhX302UmhPkace0FepPKWK1bDUGRROmxJIMRoElJ7ovVIVP+HajgKNseScea94yEa0LOF0drlc9By5/7jwbGlxrELFPD22WoDNhTePfTgDIXjNhS9kpy3OsFGBkDAEBx5+62TXfNrbR18w7WFxLHjMRVTbFjpZyxcdqA6O0MVSftUR4pOLwbdxii4yGH5pHiyy76LuM1idoIPb5GUdBLTUY2PjxmjP1H9cpIp+PJfXw1JI2gwe+gKipe0LLDwT6Hsc3PNUfnSsFtoteRFGSJE3Mo6p4Vkj1017RsuRBwMpA0w2gQEmsfTDfnCYCo4vdEVJ7giSn5zvn6bxHt36PWtZ5kfMFkQP6teMiL2CFMR1UOjvMkwPXyRnq2Ar74XZ7WA8ObrYLxGdY3rqDwSsP/L6k70TfFWwsHmjkRjyXHZZN2U6Ba45Zgl8BIkLI2R20kUNmaEEFK/SwXgN2bzx5HmQD0bG76zeBMy8wEgmRtt65GPjslYGCherzAS2cQSlcT7boMI6ABEmBTqowwD0yeClW8RYe64XxXkmJr3Rh4+oGb5NwT75efuvBTptovvuTV6COmFW4C0T9KBYKZ/NC isbgZzaK WLRv0lQSAPcLsfwklF8YqYL4k+rcNluaJYpVo3nSPgIbDE/e3AXtszr5I53OqG27qZwNzh9oH50Zzrngj/u6TE/9h7g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Dec 31, 2022 at 02:47:29PM +0000, Jarkko Sakkinen wrote: > A couple of fixups. > > On Sat, Dec 31, 2022 at 02:27:57PM +0000, Jarkko Sakkinen wrote: > > diff --git a/drivers/crypto/ccp/sev-dev.c b/drivers/crypto/ccp/sev-dev.c > > index 6c4fdcaed72b..462c9aaa2e7e 100644 > > --- a/drivers/crypto/ccp/sev-dev.c > > +++ b/drivers/crypto/ccp/sev-dev.c > > @@ -1381,6 +1381,12 @@ static int __sev_snp_init_locked(int *error) > > if (sev->snp_initialized) > > return 0; > > > > + if (!sev_version_greater_or_equal(SNP_MIN_API_MAJOR, SNP_MIN_API_MINOR)) { > > + dev_dbg(sev->dev, "SEV-SNP support requires firmware version >= %d:%d\n", > > + SNP_MIN_API_MAJOR, SNP_MIN_API_MINOR); > > + return -ENODEV; > > return 0; > > It is not a failure case anyway. > > > + } > > + > > /* > > * The SNP_INIT requires the MSR_VM_HSAVE_PA must be set to 0h > > * across all cores. > > @@ -2313,25 +2319,19 @@ void sev_pci_init(void) > > } > > } > > > > + rc = sev_snp_init(&error, true); > > + if (rc != -ENODEV) > > > if (rc) > > Because other wise there would need to be nasty "if (rc && rc != ENODEV)" > so that this does not happen: > > [ 9.321588] ccp 0000:49:00.1: SEV-SNP: failed to INIT error 0x0 > > BR, Jarkko This patch (not dependent on the series) is kind of related to my feedback. Since platform init can span from quite many locations it would be useful to get errors reported from all locations: https://www.lkml.org/lkml/2022/12/31/175 Would be IMHO good to have this in the baseline when testing SNP init functionality. BR, Jarkko