From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72020C4332F for ; Wed, 4 Jan 2023 12:01:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DF3648E0002; Wed, 4 Jan 2023 07:01:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D7E888E0001; Wed, 4 Jan 2023 07:01:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C1D208E0002; Wed, 4 Jan 2023 07:01:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B32F98E0001 for ; Wed, 4 Jan 2023 07:01:14 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 74264AB0F2 for ; Wed, 4 Jan 2023 12:01:14 +0000 (UTC) X-FDA: 80316976068.25.C4EF64C Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf14.hostedemail.com (Postfix) with ESMTP id AFE7710000F for ; Wed, 4 Jan 2023 12:01:11 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AkDX3AW3; spf=pass (imf14.hostedemail.com: domain of jarkko@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=jarkko@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672833671; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gyThIG2e5Nuis/QgAuN3yERUQBkbMWISTq+6xkKDJhg=; b=feQX6J5xc07GR058Ym/IV43Gy3flflD84y78Jmn6scmC17JgZFCIqd/2Kmt7D2LClratGZ JXIiThxHnbUrY62ew3qB4fHLlq0CT+mzwZey3TboFqxqxwIFFO+Ek+RKVRro3dCCMa6VWH Qh1VMlgH+ofwxA5WDG42JNm4s4eqXnE= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AkDX3AW3; spf=pass (imf14.hostedemail.com: domain of jarkko@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=jarkko@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672833671; a=rsa-sha256; cv=none; b=5brUI8vuvAjs0Ewq+Y1b0HCgiIsSDP97BnS4gCmffn+DJGLN39CWEUds3ex9RwkhBb/GdL ORDHm64m/pbtNFH2rE+yhXKCRD7Qv6w3T/7QddvduJxUmWtfkycta/DINy2neRa6J18grG WNelaoii+rIq6Im9NGZJVVa03pdgzTU= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D6853B8162F; Wed, 4 Jan 2023 12:01:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0C3F7C433EF; Wed, 4 Jan 2023 12:01:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672833668; bh=AdBBHs+vk1+ihc9nifYgy4qWtVZl+0uaE+N5wIA1lqc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AkDX3AW3ufOyf1t0bKZaO2Gtqi7D7Wz54W2mFvnJH9m8ej+laXvXn9GSBlgHIICxm w0U56pDRDj0LdPBkcOArbb+3lN+0IV/Sk3I/EXEPtlZqWN+7XIdrxcuFbQ/No61WEj 62FOq83Fp+bXKmRWVaSVIKFApzZdWcirAFHKVfLVTVK7eaL7Wk0BAtpBg3a3wgDG8t O4Z4yfA9JIUGiWo5d77UocfLCSxCov/XUKloGPNhriB6Fkl/WmmJkbRNcslivZI2eg UPHeUy+YcAAikJyhIDvoCVN7MDFvYG2xARtJwPEdQp3HylEuFaYbaswDsXg5DbcH6r xydmzduMxp9GQ== Date: Wed, 4 Jan 2023 12:01:05 +0000 From: Jarkko Sakkinen To: Michael Roth , Chao Peng Cc: kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, dgilbert@redhat.com, ashish.kalra@amd.com, harald@profian.com, Nikunj A Dadhania Subject: Re: [PATCH RFC v7 01/64] KVM: Fix memslot boundary condition for large page Message-ID: References: <20221214194056.161492-1-michael.roth@amd.com> <20221214194056.161492-2-michael.roth@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221214194056.161492-2-michael.roth@amd.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: AFE7710000F X-Rspam-User: X-Stat-Signature: cdjmkufkfzrogkaddr9kbgtxc3fmuaw3 X-HE-Tag: 1672833671-825181 X-HE-Meta: U2FsdGVkX18xM+mX3CArOjDdeggPGkLatqejhRlJLu2nAShXdDWk1+3plbeft7bkP6VVxw2cgMEnowd5JMAiPh1uE660RQb8CEnxyF8mF8Bhd/2ZQrwDASMfsPrBYRfB78H3arXi/wQhhVnqFU7s2iG/vCPSwQbC6phpg4SBtxe4IdQbr2/tAjeFVjjK0YHF2hibzJNqOu1QrXAkFHjyDObGjErUflH1Qlr9D72z4isNY7FnFMF2Hu4I7oYm0CHI7vCwoqpxHPGk+xiKGhB11j/RFw31+lU0fiCo/EMaaj0Dm0Yd2uZGI8ZEVfTbg1AHBGnmTgVuinCMDhjSCpvMeTwSmAYNevORcoyTzvL0EyEN8ynLqdMbKdlb4ATUJnVVAwhPqVMGtC95N1EZaWfdh1WmZGsM5TdUlO0uiH9FtWXl1ymfF+ijoXdSh2y/S5aNvN0XiO5/6Pn1ZPacbaryojyV5kG3+MyaQkjAipmt+0Bnahksnf2qju3qDdNqHdfY8foc0kXMXucAAO3GaM+636lsxVJ6hjikhpjXc3BcKiprSCfEVTUVNEKjCgrQR7HXUn7OI0y9GudYrP6+T2+hL+tQwhrzCz38C0h5lvQ9axdACcW+xVk0unmpqkj1qwa+OA0Yoh1X1/wssmll0vLAFnh6GUKrsmFrY1ZYw+mBLiMj1N26Lx7WLJZi7xIQKZ/1sme6TJzj+IXlmPcqJbSV27gF76W5CSnDAbu0B2ExI5BCSyn4owmL4UW+HV8YSHn7p4s99/0Ce9kM6N2BP+5/Juf3VOo0bXhUU4fOVk2N6cBWKt2+y696TZYNeMbG55i/AaYmYQ1BteuYeAS01dzDH/XR0FR49kqDDpW6S2C3h6b/RZBK4cCsZR2koyClFHpU8XzXiy8bhTE1wqLl5ifk2bSV9t4YTL9Rj77k+XwILnjTKmtTZR6GQMW1Iqwfm6E/O8f5jl64upLacdjiZvu Queq/FB8 7vRhbIrMgypPMNIYdaHBT1iPbd7cqTlyqk5ZZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 14, 2022 at 01:39:53PM -0600, Michael Roth wrote: > From: Nikunj A Dadhania > > Aligned end boundary causes a kvm crash, handle the case. > Link: https://lore.kernel.org/kvm/20221202061347.1070246-8-chao.p.peng@linux.intel.com/ Chao, are you aware of this issue already? > Signed-off-by: Nikunj A Dadhania > Signed-off-by: Michael Roth > --- > arch/x86/kvm/mmu/mmu.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c > index b1953ebc012e..b3ffc61c668c 100644 > --- a/arch/x86/kvm/mmu/mmu.c > +++ b/arch/x86/kvm/mmu/mmu.c > @@ -7159,6 +7159,9 @@ static void kvm_update_lpage_private_shared_mixed(struct kvm *kvm, > for (gfn = first + pages; gfn < last; gfn += pages) > linfo_set_mixed(gfn, slot, level, false); > > + if (gfn == last) > + goto out; > + > gfn = last; > gfn_end = min(last + pages, slot->base_gfn + slot->npages); > mixed = mem_attrs_mixed(kvm, slot, level, attrs, gfn, gfn_end); > -- > 2.25.1 > BR, Jarkko