From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 182C6C4708E for ; Wed, 4 Jan 2023 12:12:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A8F7F8E0002; Wed, 4 Jan 2023 07:12:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A3F8A8E0001; Wed, 4 Jan 2023 07:12:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 907938E0002; Wed, 4 Jan 2023 07:12:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 807248E0001 for ; Wed, 4 Jan 2023 07:12:47 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3AA3080C1C for ; Wed, 4 Jan 2023 12:12:47 +0000 (UTC) X-FDA: 80317005174.05.680E510 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf27.hostedemail.com (Postfix) with ESMTP id A219540011 for ; Wed, 4 Jan 2023 12:12:45 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=hxEg5IlT; spf=pass (imf27.hostedemail.com: domain of jarkko@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jarkko@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672834365; a=rsa-sha256; cv=none; b=b/c2hRYGtczGSMSmAPXkOc4snF7aqmmNsvI/oIOfu8vWbe/Q5NTzvsvBdNkGUUQrdv6xxE r0PFoPuOxwG5dkzH+m+ZdXJeEB2RJepaImCH2ZsjmDVPZyTd74UYJn7aVNrC3UIUELdPZc riiUlMYSpqK38m7sQo8+113GQ0QQqNI= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=hxEg5IlT; spf=pass (imf27.hostedemail.com: domain of jarkko@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jarkko@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672834365; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JNR49AX+amYSrUq+UhmwEBhgRF1NHWvhOOW6cEEEJCs=; b=kLfl2jUjGrlCDzkfrNrdb69Y4VbylyUYYzdcNyoia58kMeHKE9T1KYg7JUt5142lPoMmzQ Bd6AxLVGK6Th172vPSSIbSLA8Ru3QJaPO2TuFOlL6BLrAJ3Bi7Fvq5YcDFpPSkazP0vZk0 +ciyEAhVqM42gNJXxt1Wkv2ByG/8ZMM= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9CED361259; Wed, 4 Jan 2023 12:12:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81AF9C433D2; Wed, 4 Jan 2023 12:12:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672834364; bh=2LM4YgK9ZwjTNPSN2P5IZrHlicBcI8kTMt/REMjAc98=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hxEg5IlT8BNPimyBbh61k0QbFTkMWB6pALC5qBmzuPUzhAdJ1O/ps1/S01t9QoWnS DKlg3hsfGR5luWLAzrWvAPMKOmvpI4FpujQm0KyLWz+wmdCOxGogmTuXaGRSh8i3ZE 8FxegDtxke3qT2hG7LXmpGdVUfxh52Oy8IXMcdUCUWwN5qjmGAII4YR79t9HIyaBqP EZm22UrAk+EE96zWeivUQMtyd/mSynCnyKEsDOw2h3IG7YZnlpeXfAhVmyG7t7gbX5 lO7Jv04rxaWxZXFGQwf3Qoat9E2SiOG1V+If8r7fRsnZBhtsjSWs01J8sP8hqMDf4W k384F7fvHfOCg== Date: Wed, 4 Jan 2023 12:12:41 +0000 From: Jarkko Sakkinen To: Michael Roth Cc: kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, dgilbert@redhat.com, ashish.kalra@amd.com, harald@profian.com, Brijesh Singh Subject: Re: [PATCH RFC v7 25/64] crypto: ccp: Add support to initialize the AMD-SP for SEV-SNP Message-ID: References: <20221214194056.161492-1-michael.roth@amd.com> <20221214194056.161492-26-michael.roth@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221214194056.161492-26-michael.roth@amd.com> X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: A219540011 X-Stat-Signature: r4sju58pmstqx7jmqi5aq8uj6x8qxt1p X-HE-Tag: 1672834365-949260 X-HE-Meta: U2FsdGVkX1+KUDkxvCJjjJdc4U99j4tHRDJl2CLfKIFebgf0J3czR0RPxu/nYwzIMOb/8EGNteVj/jFxdCKB8FMmbICPwtVJLZ6oJQf2RcdwhJ1FXf9dvrWXgxrzjPwu95Z3WvIwfMrvEI2ZaGRfUyTrprjwKO/UpwKVtkwSlt+Q3tTHBDGyvHJjA0cXbj5PU5n6hAqxIslqo/prL97e2rx4bXjn/pvQQXjSDpUxZZEPJ8rBqx+KWXacP6GqvU9Ykbrh1t7GXuNjI+RACNO4nJnicYhjM2a50OV+6HawxI6i73ZUwJnyH1NERvPDls9EkmB5CgYGjaPkcH/etbc/rKLD3ltdf0mrdYFjtEPjhdyHy5mHb7EJtIZuwkNjUPUoXo+CJ/kIvXYp9Mq8xg0JNf4pkFNz9ywvmCLH4GtH2bmr8W+z1hodymDyNIqoRTrDX1qs4zMZzhctJoFcajvC3aU1RETxKe+OVeT/uwuTd1wD+rhBF8HEVViI3RhXKKIyu6sWh1GEG4e0Lp/8qeFx8YWcR+GQ96JpLFhb7Un3cFry+MEbFrbKCBY94GKXcDUM+uUm6JvRUlDsH4DMsDEcvGJ3fslZd1G87hm/FsmC4s7/EWEqY0f+RhR3VnRRUOiaedA+micFzh/eifxmjW+Gfy/WkMm7SESAc2KWwr7xvp1icEcMUb+rH/IB4rxOLpbfzV4E0SL6FDxzfi9PPC8D7U131HcJMJgRf1duopUTwaXrPStlPpMpYEhgg2BjcPfxitPTSf8IKUpy+NFJUOgFxm0/G68gl98C+hozWrvkBeWCjKN1PmXj2r25xhwLjAhmevZXeXTS724sqizngrrAC67RLLCO0w0zQ7KFwo/3EbInshhB4vEZ+dS63zY4Mu47cR5vb1xMGQ7Na1290U5gD+e8IeTdDkG9AstQwAovZMRBuhZzH7XiLWX8Usf88KC0LfiocNiAzFY6PzZgUf9 VP+/XTsB ltxXSeVxnCL0dgRBkam0P561w4sGeEX+IAyY4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 14, 2022 at 01:40:17PM -0600, Michael Roth wrote: > + /* > + * If boot CPU supports SNP, then first attempt to initialize > + * the SNP firmware. > + */ > + if (cpu_feature_enabled(X86_FEATURE_SEV_SNP)) { > + if (!sev_version_greater_or_equal(SNP_MIN_API_MAJOR, SNP_MIN_API_MINOR)) { > + dev_err(sev->dev, "SEV-SNP support requires firmware version >= %d:%d\n", > + SNP_MIN_API_MAJOR, SNP_MIN_API_MINOR); > + } else { > + rc = sev_snp_init(&error, true); > + if (rc) { > + /* > + * Don't abort the probe if SNP INIT failed, > + * continue to initialize the legacy SEV firmware. > + */ > + dev_err(sev->dev, "SEV-SNP: failed to INIT error %#x\n", error); > + } > + } > + } I think this is not right as there is a dep between sev init and this, and there is about a dozen of call sites already __sev_platform_init_locked(). Instead there should be __sev_snp_init_locked() that would be called as part of __sev_platform_init_locked() flow. Also TMR allocation should be moved inside __sev_platform_init_locked, given that it needs to be marked into RMP after SNP init. BR, Jarkko