From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0B5EC46467 for ; Sat, 7 Jan 2023 10:40:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 134CB8E0002; Sat, 7 Jan 2023 05:40:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0BEDE8E0001; Sat, 7 Jan 2023 05:40:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA0CB8E0002; Sat, 7 Jan 2023 05:40:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D7FF38E0001 for ; Sat, 7 Jan 2023 05:40:49 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id AA62240493 for ; Sat, 7 Jan 2023 10:40:49 +0000 (UTC) X-FDA: 80327659818.07.927CE0B Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by imf05.hostedemail.com (Postfix) with ESMTP id EBF4E100002 for ; Sat, 7 Jan 2023 10:40:47 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ZLxygyA9; spf=pass (imf05.hostedemail.com: domain of mingo.kernel.org@gmail.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=mingo.kernel.org@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673088048; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Q7wsnRffu5O2RWgyv3GZ3K8cLeYYuVq6dZD0H2Sa32E=; b=ow2B4GhTP/So292n9QftctHZ4RQZV7HrkM34DjjKaReNs89oixN09+h0aKalxGSIP1lJhV DgznghFsL//63S80a6PRliC35d4zX5heYLr4/EsdcKKyBltGJB9zrp1z0JgokhyvSrUFGC gINZtInG2DhoppnaIZEoDpPICHm0h8g= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ZLxygyA9; spf=pass (imf05.hostedemail.com: domain of mingo.kernel.org@gmail.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=mingo.kernel.org@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673088048; a=rsa-sha256; cv=none; b=AUEE7AfBhrRjeth4c2GjK3wMkq/yEu5RZCikcQ9Bgi5hUSQvvxPmg8ntvH4hJTdvzAEmTW YBB91KEDDZimlYjTzgc0xdrcKu/FbjbUHldgjLid/zfu1Qv5NgP9u+5Sm6AH8AIMrmWIzi 42IQyH6f2rN2iE1IJYeFweIv2Z9b+UE= Received: by mail-wm1-f48.google.com with SMTP id bi26-20020a05600c3d9a00b003d3404a89faso4676870wmb.1 for ; Sat, 07 Jan 2023 02:40:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=Q7wsnRffu5O2RWgyv3GZ3K8cLeYYuVq6dZD0H2Sa32E=; b=ZLxygyA9kLt9+RMfDbWEaTfO6aYKJ113bhDgVMRWwq+CqNgPufmOTCjuVZ+r9LkSQF TlFH4dlUugnM3xwRicIx+ni1A6QtYpvbkcGMzIkOEFa5tyZhwsrdc2Gk7wULwUa1T/TD k3mW7KKISxXn1Z3ujcubF278OW8DVEveZuiowjPSwzAR5ePpY6gj9GBpPMbv5w0wPNFe pMCi+EH+X2fGAuR4dMac2XNWHrOC/ZOmtfZvqMDPP91zVNtn/0GxU5Cnk/AMgT+uc8yX pF8IEuW6wBJOVfwmp9zFTtNzdk5LmSQRHTsmJKj1R/Vr1dQQicljNxp3p9qsPwGgIuWa CevA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q7wsnRffu5O2RWgyv3GZ3K8cLeYYuVq6dZD0H2Sa32E=; b=EpPEmVwC+dM9dQzeN0A410fm6glXnb2OJw3XhHpwBA5MiCoaGOG1O/wWL+xaoCuaH4 F5ArYjtlH0Q00FfGDZyeZtXTOc2hyFI1zA7ldAl1GvwRw/FgT3V32fEHyH9c/aFCa2Xb wDadiW53lfqRoxO7Pb1lHisQWBqPl70C5nQBcH6ZCL64x+m0FnaKpuq4oWPQMuEB3wlK s9jDjvhSTwkt1yYhTad/ytVNIjYr633mIIx56QWCmyHPTc0iBTd9wQuGvVm1f1cCI5Tq vYXshdbd9SRWCHDHuUJnh7e09YawJuexFokc1T8YsPsfInMnwL7kp+gme9yusfYaPf3Z 403Q== X-Gm-Message-State: AFqh2kqYAdhlm/oROFRL2QXu7i0T3VikWxk4vxgzLIx7iMDy4b+tMexa XebmnjLuI+CvqBvhw3ixD3s= X-Google-Smtp-Source: AMrXdXuq+EWlBkcohRlbrPONGYn5FEPQFIlh1f/oLALicT3AP+m1ni8UQ+QudfRzNpxDC72kSlEnnw== X-Received: by 2002:a05:600c:2d07:b0:3d3:5841:e8b4 with SMTP id x7-20020a05600c2d0700b003d35841e8b4mr40607615wmf.35.1673088046544; Sat, 07 Jan 2023 02:40:46 -0800 (PST) Received: from gmail.com (1F2EF507.nat.pool.telekom.hu. [31.46.245.7]) by smtp.gmail.com with ESMTPSA id l11-20020a05600c1d0b00b003d01b84e9b2sm5377974wms.27.2023.01.07.02.40.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Jan 2023 02:40:43 -0800 (PST) Date: Sat, 7 Jan 2023 11:40:42 +0100 From: Ingo Molnar To: Liam Ni Cc: x86@kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-efi@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org, kasan-dev@googlegroups.com Subject: Re: [PATCH] x86/boot: Check if the input parameter (buffer) of the function is a null pointer Message-ID: References: <20221206125929.12237-1-zhiguangni01@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221206125929.12237-1-zhiguangni01@gmail.com> X-Stat-Signature: 61331dfdnqako4h4aous4qkopgmewqrk X-Rspam-User: X-Rspamd-Queue-Id: EBF4E100002 X-Rspamd-Server: rspam06 X-HE-Tag: 1673088047-297541 X-HE-Meta: U2FsdGVkX1+ZDG6eShhigT4/u0/MiG/QYFOlciS7iGS0Zw82NyqsNP4NFdP3ta0VYQm93H8Ri34Fsra2/iwVb5ihCUG8X7ItxUWyvQSLUW+HTvVy9iF9pBb1JECo3dkqbMw6aqzHj0XGS3pzV2kXdpxySsD1bt89cnAKJ1Bvfdfa0f7ZQ0xgRSa270h1p7Q+wRPK8cCHQYlPyLhkSv+uimRGgECv4fWohqkdmf0vgCg4vLv2+vu7ySnMzhF7YlOEBam94WJG2xfzhxpBYI3cvU1GEEGOgCjrm1R9E8raYK4RZQvdN3JaRwhTvU7wI4auocaGGxLe3WduKVuWXBwwNt/dkUmGHoDp3DneiJcNOdr3ZU6LxEpdlVligaKBBqTjZw1RcjB80F8PMEqCtIB/1CPULG869uQAUUtoIvPb1Gd653uzGXzev3yvBbQVdmsfBG5JdN8t9kDJMSWjSruGCnlmKCAuY6sEIsl/4I0yUVw9JJaZYYeD/pBml/2BdCOPnCAQTkKsXa99eyQuAZQeQeKGjn9haaIKbDMX5C2mn+bxrZrBlSWsNiL9p9iOVE/PQLWiE+btthhe66NsMV+qKsTlmBfnfttfJzrqNiGwf75ZPFr9OJo8TgksfuUODxNi6s+0PdsJ/xpvXTvpDsxUnD98WI2Y499Zrs0zmeSox2laWEcfcoAlYg+U9acFJRj/CzMplL70RuTy9NNo2nmhFHMjStIW+XUl2SKA1zKbrL9XIcEJZV4cB5WUAnioSGQALp29/k+HzQ+Xu0pK48sufMoSSoIpLgGtLAbWAckdgtnOpfbRTdZZxyGsCFWGpqyZ5VTu8ub5yACb6QtaHIMb2Y+mLO9AnVHl9O6Ut3MSB4sA6A3J2AtcnJCOKQBGT6b9WYKIctqLpoe6JK1ZiJmOfq+JyF+kMIhG3+6Fs5RKWqOKLzcq2N45CfvHCMW96GST+y1NhV44akWebUhPkUC Yxkp9Ni5 GATTIHyaAiLFVsTptWMAk1lNehbrN9BghfRHc+lU2y9hQVOvHaDDSjgUjqTsBsX7n0FzME9bSXQ7Gyaz7gWOvKSUorSAbrJnyRYzT2ZsQBLthfKGtRrqPtm6kCA7hrI+4GFNBEy29MliG1VymcKhmwpurS4R9wDL3mfjxhaKCMrf6iYwCJKedIRXFYxpizd3X1FpPo/s4gXgg7nzfL7jzgGn8peONIlmFMbyo+GWmF4XlvqFP0dCNIsY+rHJfAxJGCB+4QMtNNyzTf+YXknecPeNBXQugXfZ1X7iO12BSNReuIA5BmSd5V4VzkT1j9hkgYldhD/8qOq5jFLrXtRZJYbGYkQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: * Liam Ni wrote: > If the variable buffer is a null pointer, it may cause the kernel to crash. > > Signed-off-by: Liam Ni > --- > arch/x86/boot/cmdline.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/boot/cmdline.c b/arch/x86/boot/cmdline.c > index 21d56ae83cdf..d0809f66054c 100644 > --- a/arch/x86/boot/cmdline.c > +++ b/arch/x86/boot/cmdline.c > @@ -39,7 +39,7 @@ int __cmdline_find_option(unsigned long cmdline_ptr, const char *option, char *b > st_bufcpy /* Copying this to buffer */ > } state = st_wordstart; > > - if (!cmdline_ptr) > + if (!cmdline_ptr || buffer == NULL) > return -1; /* No command line */ Can this ever happen? Thanks, Ingo