From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D3D3C38142 for ; Tue, 24 Jan 2023 13:18:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 270A76B0075; Tue, 24 Jan 2023 08:18:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 220276B0078; Tue, 24 Jan 2023 08:18:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E7F66B007B; Tue, 24 Jan 2023 08:18:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 00F526B0075 for ; Tue, 24 Jan 2023 08:18:23 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B196D120AE8 for ; Tue, 24 Jan 2023 13:18:23 +0000 (UTC) X-FDA: 80389746486.07.3EA5526 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf03.hostedemail.com (Postfix) with ESMTP id 1AB0020010 for ; Tue, 24 Jan 2023 13:18:20 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=GhSP7kMT; spf=none (imf03.hostedemail.com: domain of BATV+3f260f0a54c0d014680c+7093+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+3f260f0a54c0d014680c+7093+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674566301; a=rsa-sha256; cv=none; b=CW30nqTWgLnmUY/gV6Q8qlCriRaHg4Sf02XgiYINtVvdBhn3vm7CcLCylqYCh45eA0wyf9 hyQWYhnYUz1qpkLYD5i3gOOVToVz3ZjY5agS3J/NYsScvTDgSE8tKc3jsvvvPNiLYyKymh uXyk0ic7YtJ1x1DlKPOCZLKGFMM5wq8= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=GhSP7kMT; spf=none (imf03.hostedemail.com: domain of BATV+3f260f0a54c0d014680c+7093+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+3f260f0a54c0d014680c+7093+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674566301; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HTTBGfjn7nRkSukN0saTCzZiE/bxcd4l/l4Ax47zdsU=; b=CtTnxlsJrUuvl9Y3HKumtuJ8DMEgA05QJ3O/wW85PcP140675E8njWSUK6VT1swsjxf8Zu MFjRVnHYlfv5HR8IVqWMLsqBPSqlEGJRDzeqMSAGYTybNc1+CrmpeAkevfUka5VP2fY7LY 2UEesFqSGevFDZq1vwWtfDMijtR+xsM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=HTTBGfjn7nRkSukN0saTCzZiE/bxcd4l/l4Ax47zdsU=; b=GhSP7kMTmQvV91SOWLa+z+5Wfm DLMaXzL855XpJ273A6saQAsgAijJyKQuGH1FMtelh6lfkjN/Xg3BSVnWRTubPM4QVDLVrBvUEAzcp xt8Nkkr4ntZLRjTvdZd6uvckAq0XupErlSbwg8lQKTLWYibyFUDWs1iu/+Gvu7P7wfZ9siBeLMyir bAydGKjzGgMknI6XORTajsUe0zCAfpsMZcjl4Xj/n6R6ko5/Tr29TfeBROUw2Z0JZwW8qBENvQ4D+ 9JhToKv8qUQ6AgZ5WwG8boOrTzibQaFmFgal5rIFH6XPCdExHFHiVLst6rqJ/dZBbT8MGI7BA398Y vG+84tiA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKJBf-003vM7-PB; Tue, 24 Jan 2023 13:18:07 +0000 Date: Tue, 24 Jan 2023 05:18:07 -0800 From: Christoph Hellwig To: Jason Gunthorpe Cc: John Hubbard , David Howells , Al Viro , Christoph Hellwig , Matthew Wilcox , Jens Axboe , Jan Kara , Jeff Layton , Logan Gunthorpe , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig , linux-mm@kvack.org Subject: Re: [PATCH v8 10/10] mm: Renumber FOLL_PIN and FOLL_GET down Message-ID: References: <20230123173007.325544-1-dhowells@redhat.com> <20230123173007.325544-11-dhowells@redhat.com> <31f7d71d-0eb9-2250-78c0-2e8f31023c66@nvidia.com> <84721e8d-d40e-617c-b75e-ead51c3e1edf@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Queue-Id: 1AB0020010 X-Rspamd-Server: rspam01 X-Stat-Signature: ynke1s7ea9kneip4o7q6ybqu3j1yzkrn X-HE-Tag: 1674566300-804018 X-HE-Meta: U2FsdGVkX18OrcCU3zKVEzAtkehT1snBtL87uHViysLwO7Dfwk6RGFqHbYMoUg1FqpaMo9sl8pZif3NCBi1eVua2T3ocznJiOPFoBynDgWdxegscKp771jus52eBc23FvkEkSHD42EwiR8CAK8SiXHXLu7IQYR0qvPF22m0yiYaAj8+7dFilB7x2BLjaXRn+tVsTAkMn2cbo8DhfbicAOx3xgPTaBBNRJTwG1ZXKS9MzGQ+F6Xb610Dqk1B0OcJUUBiQ6S05+G1Pnh+DvkrQhvk4I6jUTfbm8xRXd/jkZeR5eg7QH8LOxH2+cVwZ6hYy6xC9uTeZksVPNENUkgw8DQa1TbwkxiAdRdCPithBqO0S4lcohfX/+bJ+UGpOnQKZZ6xahvsIx3/y1kf9aQpvNKA9h+ij9MAgZSrjyTsuqTvplBlZKG+3NOYHJwS3g7Fvht9mOXvOZsE0N8V+i2Jkv/TPSjhLBEh+Z5tsecVBs4GQQerkc6c8JJF22MO5LCft1TzsRNlGP7TZCRV+UnDmQVL/qtnNxv2U3ZZ9TNJPdOg31WWlOopugf/lUYogryFRbqGzZDjisnAOtW5ZH2V15510nLRDfGYEzBH+RRtvXFxSRTviE5lDt10V29Q8XlBG+4a9GKnTVQ5cnay5Bv5Efk5KF8x8c5Se3JOOudaQU9Z2FsTHoNbudVzNSNDLkmaW5YBHCBLm7vOKZd/rdVEXxB5WN3arfBp6u76xhuROZRFB/C/SkGhIfKdtufjYNJ9jVADslV6eZ7YrA+klJE5EhX44AEeIBpnrXcUU1EerR7NhOiBw21aWW2QvWbGDafJ74NcGatPUNFm+hYrWentzfxGNzaqNIirgaDRaA9W7vCi1xKBpAni8egS1vc8sZQYc/em5yLhmmnWv6sYYLFj3+oedhM8zvmJxlJw4pe8DP1xFDnyFM2dUi94ZQ7xuaawxxjXesTNsS1rWRXG3SZj ihYUZyYP nEunVHG8Lcr88w4uH3eEpLfIlQOYMbN6TOy3RfIQs33zIBlTRTzcF8mKVC1BrfRWG1JLLZdIyxF3e4NyHHmL0lA/mLILL/HVd/oXEMD6tbHFWtr1aKJy6jOQeHd3gaDD0I+p7ce7eGSYgtk+tB8jXniOeB4MrD0utNESZIHXGKuz5OUcIqQumzap7BmrCVg4L9pDQ0Lv+gSb7iTN38LvJqwwYrxyWzByKooWcG2b+CW3aCc2Zk0RYWzqLA0bBFjgFMQ+u0G0x/kFruhJ80EFWnwn6juG+JHUQpcPyn5L99mCCR3Xi89zuQpfL7bCvUha89HVBfNP+9c4cqYZ8bw2Y1Efp1QmbJMMYnSBKzL37l16/OJct2R8xQjZMjD8WACtfGM5OLCCEX8UQqpdyCMjNUi9qB2mr9PY+482zx9L8RraKiA7jBDhCayNa0j8Pir878XS9blvwMI3B0Z0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 24, 2023 at 09:13:30AM -0400, Jason Gunthorpe wrote: > Yeah, I already wrote a similar patch, using the 1<< notation, > splitting the internal/external, and rebasing on the move to > mm_types.. I can certainly drop that patch if we'd rather do this. Given that you are doing more work in that area it might be best to drop this patch from this series. > Though, I'm not so keen on using FOLL_ internal flags inside the block > layer.. Can you stick with the BIO versions of these? The block layer doesn't really use it - the new helper in iov_iter.c returns it, and the block layer instantly turns it into an internal flag. But maybe it should just return a bool pinned (by reference) now?