From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6E26C38142 for ; Tue, 24 Jan 2023 06:29:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0BCDB6B0078; Tue, 24 Jan 2023 01:29:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 06D546B007B; Tue, 24 Jan 2023 01:29:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E76D06B007E; Tue, 24 Jan 2023 01:29:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D75E66B0078 for ; Tue, 24 Jan 2023 01:29:19 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A78CA809C0 for ; Tue, 24 Jan 2023 06:29:19 +0000 (UTC) X-FDA: 80388715638.09.F4652E2 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf30.hostedemail.com (Postfix) with ESMTP id 328A980009 for ; Tue, 24 Jan 2023 06:29:17 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Y1N1Bp85; dmarc=none; spf=none (imf30.hostedemail.com: domain of BATV+3f260f0a54c0d014680c+7093+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+3f260f0a54c0d014680c+7093+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674541758; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4u7sdeygL2SI0vuOn3AQXqOOeojipj5nJ8JBXiSMSP4=; b=bR5O0wr04n1seTXJ3Xlu+luReBLKld8Yh6wx3RYwB11VetnCMx5m0GJI7yMEiMT/7z2/nS q4yoMKIUTVEwxMTNkM4hNQhoaLFuxU+X3U1Aga1+/j74m4SXkEf6j421YkvnKW7pjzeaAm bt9irYIl2mZhAcOoAyJsfKs/64szwpE= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Y1N1Bp85; dmarc=none; spf=none (imf30.hostedemail.com: domain of BATV+3f260f0a54c0d014680c+7093+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+3f260f0a54c0d014680c+7093+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674541758; a=rsa-sha256; cv=none; b=CYgq250y28NCV/7kRcwCPzLHRlzeiamtqxeWJfSCOfksHWb6I56jHj74NbPVZ3pkg/punK TOhazhTYWtxbA74WqiViTxRo+/PHCCShsffF2uEsnJ2/wp5ICzhrH+JPnOmIDwGTX9ay/b u5LH3lO9fUwFIIE1ZprxDpQJtjWlx/g= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=4u7sdeygL2SI0vuOn3AQXqOOeojipj5nJ8JBXiSMSP4=; b=Y1N1Bp85zWT1Yc4mWO5RM/5swn z1s/ae7nZBU1XI2LeDBAOv+06U0Bu1PJWHXCDrEjlbbph1xr+oh6cmoXIod4hdcTSIhg05KsUMsH6 Mt0SAUZbeNMdj95LikeyPio6/J/WyHzPQbupOE2KMJ+OXZv8xSLLdBNtO7Ot/A8dx2JalSA7ubKi2 aFuBB1XW7qW1wiu2y2b/BJd4x/N6dLqevlGltWAruZGC7j2J5NPe6Xz6f5IgVH1uIF87LFk4mGzQ9 1iI2DWcT8gQ30YpVU8YQ5BM2WIzRNm5oNr5lR1NU6lLpwGy0B15qzrZcjDOK9MRUi3zNGYFfM5749 r4m38yZA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKCny-002Vim-8c; Tue, 24 Jan 2023 06:29:14 +0000 Date: Mon, 23 Jan 2023 22:29:14 -0800 From: Christoph Hellwig To: Alistair Popple Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, jgg@nvidia.com, jhubbard@nvidia.com, tjmercier@google.com, hannes@cmpxchg.org, surenb@google.com, mkoutny@suse.com, daniel@ffwll.ch, linuxppc-dev@lists.ozlabs.org, linux-fpga@vger.kernel.org, linux-rdma@vger.kernel.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, netdev@vger.kernel.org, io-uring@vger.kernel.org, bpf@vger.kernel.org, rds-devel@oss.oracle.com, linux-kselftest@vger.kernel.org Subject: Re: [RFC PATCH 01/19] mm: Introduce vm_account Message-ID: References: <748338ffe4c42d86669923159fe0426808ecb04d.1674538665.git-series.apopple@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <748338ffe4c42d86669923159fe0426808ecb04d.1674538665.git-series.apopple@nvidia.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 328A980009 X-Stat-Signature: tb4tns6nx1rcqpoxbxzk9r7bj3kjmkpp X-HE-Tag: 1674541757-922444 X-HE-Meta: U2FsdGVkX18ku5s9XCJLKccb7OO7XMQmSvAD/Vy2Y/vjHZQSM5LAfE2z+EEEzm20eEsNSRVwjv1ztRZxsVsxtKNfYD7HU0QV9Hw4hK2oRUyFyYvQbVg6N1stpMZPRZ6vqUDWE0rRyLSQfdftrKterCySwFXB0tdIwIOC4Wf4MZGg4/VMcmyCV/GywV17GEWDZYSrniUP84CIJq8WXIZE7OOlnkHE+ty2qvd7HZQ5Gyy2ZVtFZtc4cNZOrZb2QFKe2tNI2luJyxigUyJYhSBUEjdR8GgtnBSHAjzUlNBzm5nbFPWNuq2w+VC+58cyLIWrr52h17DCXILAqysk5vJ4Aerj25zMwNYUwRS5+ClLKe3nJJdHIVRyFWfmtkMJ2RzKt2kpKkM3VK8qTmbPjjGQ5q+tBiLtx7ZKCMpkt8Gr+z2BtIxsaA0Jal7LHW0BWfG3nkym0jRkhoJowQ9cMtcphbmmvT8a0twUttrxIz5V/boY49e9J6+Nrdj/uyK4BpjftaObS2MY1HMovDr/PHe06rVtjMh20AUb3IDHa9HYIH/LOJYmNaLa4b8nAd1xJxNv19WIs9yeQK89H4ADrthxuRtqO5J1XwzgJv+cjY2mxNnI8Ix3dYKi2tWFQnn6B1h+4g/Z0Eg9nU2F+AVfyry8v96ZU1echZzbgYG08Hc6/k9vrUd1qXyT0Q9lavRaYfN5jjwcCstvqWmyRY4pQjEjT+YqVJpPfpcZ4OVKCOumUAOn/K54zyPT2um5vR/azjQ8/H68pYLwVIPHNSfn3htIt/mstwXULy/SxeHu96PiOz7HTXiDz2LQTsRbSzNltu1vnpn4ZspKT1DSMA412RHcF0GY/kh2TP4vtoJJ+qhFbI3Tiov9+yc5yvWeBoLjJ78DZu2LYQzplaBbPYQhlVbwRckgQDG+uKq0Aa0d+y3ZaGn4PAJliA+DLkbGrGmvp+K4I/ujFZWW3MEU21QKZ2m w1dCc0la NJv4MIbmUrRewN8V+3oRCQ8JnEG19uaqmNDrPzJzy87KYGibeneGQKDdHAxBEpDas4gwbWmQCRE0lwGSWocYHe1rZvEqUVYYiITs2B9tfMVtsf1D48IhjS98kBlIPlwLGya2fV/9ph2khJWOQhCRIKN5RmCTEz/FnLkuCclfzphOYfJBvNZDJcwGWXF59S3u8xXmwDftsCO2n2pODezkXWmw6q8RSQuUybG3rD+a005bn/o5uhH6Z+t/vYxsi2IlsHjlX4zqi/tTQwVxGk+ywupIDCxX6rYZ3UBKse49bTP1iveJMQYOYHyQVjveji2aRjhMcqXwxKYNrd1X1A4iVVyOLJhe7E/YjQuXTMMEPbBjzCmbuUWlxsY5ot/NxTRle8NQDEBA4AsFx/XSDOimaV+YM0tzGh10zlwv7drPhpgMrymVa+RyvXoNm9Mj+OIJZ/tB0VZ8ppdBFOSM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > +/** > + * vm_account_init - Initialise a new struct vm_account. > + * @vm_account: pointer to uninitialised vm_account. > + * @task: task to charge against. > + * @user: user to charge against. Must be non-NULL for VM_ACCOUNT_USER. > + * @flags: flags to use when charging to vm_account. > + * > + * Initialise a new uninitialiused struct vm_account. Takes references > + * on the task/mm/user/cgroup as required although callers must ensure > + * any references passed in remain valid for the duration of this > + * call. > + */ > +void vm_account_init(struct vm_account *vm_account, struct task_struct *task, > + struct user_struct *user, enum vm_account_flags flags); kerneldoc comments are supposed to be next to the implementation, and not the declaration in the header.