From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD423C54EBD for ; Fri, 13 Jan 2023 08:47:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 49E4D8E0002; Fri, 13 Jan 2023 03:47:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 44EBF8E0001; Fri, 13 Jan 2023 03:47:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F0958E0002; Fri, 13 Jan 2023 03:47:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1C8428E0001 for ; Fri, 13 Jan 2023 03:47:38 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id EA0574035C for ; Fri, 13 Jan 2023 08:47:37 +0000 (UTC) X-FDA: 80349147354.13.659016D Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by imf14.hostedemail.com (Postfix) with ESMTP id 379E5100016 for ; Fri, 13 Jan 2023 08:47:36 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=FA2PkXo4; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of bagasdotme@gmail.com designates 209.85.215.172 as permitted sender) smtp.mailfrom=bagasdotme@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673599656; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SfX4E9lAQTiCNe2WNeORIp1pzZfAvGpZpdGEvbDnlyc=; b=g6Hc0wfqDvVJ7xCU6f2yY0dlmBfZZCx07zazWsvl69/cTnWelpKOUzJAUWqW65wZL+eOvl n7eJdA+R6rDXm0nD3fgzi/oSKBQcw+5iyh+Y3EwE/xk3uPIhU9trmPvv+MzhKWrxnRDtpQ yVpvdoYoj2PxxP7ZZozTO8PcHc8Wnm4= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=FA2PkXo4; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of bagasdotme@gmail.com designates 209.85.215.172 as permitted sender) smtp.mailfrom=bagasdotme@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673599656; a=rsa-sha256; cv=none; b=cAYELEcbV3Leffu1XCMN3oaux8xJZss8rdjtkMmD1Z3BEg0+YFZo52GylhXLQVEoYuAVFa JTmREX2DvlPu4isvBLUUvGAtZ4JK98CwDHRIb9ymPO5c/d7pc7AUfDBEYTZitHoKvBBTRf N3gPPEkKLZhn9kGlB/DBQbT6OamuX30= Received: by mail-pg1-f172.google.com with SMTP id r18so14512512pgr.12 for ; Fri, 13 Jan 2023 00:47:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=SfX4E9lAQTiCNe2WNeORIp1pzZfAvGpZpdGEvbDnlyc=; b=FA2PkXo40PTOZYx3fxDCAEVYqqt/aJ28vKXIT+/OG5gG88oxA3RIVnETZN+bp4ZJTF kyF53YHEl9t40vrkQqqETXN8inTGS/GMe4EEoLUx1hAkkkolxbDvYy7ArOSeRzTrAadX +xgr5ndeAafzqENk4iwuCSTvmiDLL5OiXiR0OUihm8UcITi7ymzpemY+6Xer5O3Bey9H q8pIxE4lqxveTlM1QggUyhuwQfiLJ6Ppgj4XjWH31yT50NbXPUg7tNMEuopybjx5R8xj 8+l3dlLWgi5yioVMx+L3/6c8wMfp6k6Z65rS9ls7/E7LK6bz5pM2xzMtlM/clvCG3c40 A+9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SfX4E9lAQTiCNe2WNeORIp1pzZfAvGpZpdGEvbDnlyc=; b=T/0PY2k6uzQevBPg98Vb+NXfnXZpEi3cIc4/cAL/6ekc702SSa3hgtbgnFEPkx3dqk LrNJPaGTDeLImzxYyDT9+K/xJg0+7rJSsOO0jpIPeg/fubg5BnZPWrMTQRKIaN7xYicY FY273pStjHs6FQDjoO7IwL4WyVDYIdYcJx8S8jQWoDWKJ2kSTuUbHXtu/SCke48PI9mC /SgrSegpZWQDSWgMZar/X625daCgHRXm0AmPTXxaS5gW8K1VTdQmW1qhVKOxsYRzjqRP UuZI2FGRmO53nE0WEgUAlSq+DIbRdY3JkMXZEY8wY+UxCYX9Hhwxn4MWTH7KwfmMmJxl SGdg== X-Gm-Message-State: AFqh2kpbSm+A8NG5tLID//xLYZ2EmvVntRlEbBKD4c4o41/ku6X8fZKy rKKlKeILGW4PzlYtrd1ZW9k= X-Google-Smtp-Source: AMrXdXsIT1IpsscVvp+29qA/1VxuWJa0lYCge8Y5cmbtwzE4RDuocftm8wsRks7SHyZbZ0aidvMNyA== X-Received: by 2002:aa7:93cf:0:b0:58a:f300:42c9 with SMTP id y15-20020aa793cf000000b0058af30042c9mr13405587pff.22.1673599655122; Fri, 13 Jan 2023 00:47:35 -0800 (PST) Received: from debian.me (subs02-180-214-232-12.three.co.id. [180.214.232.12]) by smtp.gmail.com with ESMTPSA id x3-20020aa79563000000b005815533e156sm13197858pfq.44.2023.01.13.00.47.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jan 2023 00:47:34 -0800 (PST) Received: by debian.me (Postfix, from userid 1000) id A121A104D0B; Fri, 13 Jan 2023 15:47:31 +0700 (WIB) Date: Fri, 13 Jan 2023 15:47:31 +0700 From: Bagas Sanjaya To: yang.yang29@zte.com.cn, akpm@linux-foundation.org, hannes@cmpxchg.org, willy@infradead.org Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, iamjoonsoo.kim@lge.com, ran.xiaokai@zte.com.cn Subject: Re: [PATCH linux-next v2] swap_state: update shadow_nodes for anonymous page Message-ID: References: <202301131550455361823@zte.com.cn> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="FfqVFWjacRZfxsuZ" Content-Disposition: inline In-Reply-To: <202301131550455361823@zte.com.cn> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 379E5100016 X-Stat-Signature: xhwfncmzoopoeyjxfuqdjmc3q6ux6ohn X-HE-Tag: 1673599656-923364 X-HE-Meta: U2FsdGVkX1+tdhWg137CZGNgF7U5tdqlKcOA4zoZVG9mGpWczU3SJnP2CfHgkEPMFmVSS1+bkKibE0AmvVF4cDC8B9OdQ9fJBUPw+wJB6SiCwt9Sft2oaTxzTu5WCGlZGMFCcBGZ70bQFohbTSyuGBhlNAFh92z1vBCN1sQHzJoz+WmiBx3AAUDfKfKYGsVSpeDNgYfKnscT3b5bDDz8HjFV8OWBLL0h13hb95nbcy2drqSUEhyagGPn/WrI4mzC48W1IIjC/6B+butRYAG9kQmJG/lRjWIYCf36+vIxRZk6v3glg7ZKrJFpbdKbSdnjOPkNWDxgcYsvLStkXJ25CYu4/3iQ2b1P/ZmwUDoj6xE02nTLeZskL3GEEEmFCjzPzPDo7Eknr7N8AAkn20AC/f6uwYuf64X/3r6aiRxJpDWln37ZBo2tHI8LZpKXhty4zyfMMnNWXrx+bWj4qXVikMSmsNWIMZplySajEsmR3A/5Fr6mTV9mRJldrwDCRI38qqshyPJMSgiw4Ac03UIxAKvjVGB+uGad2wBhEnDzfX84aHBtiVXn3gEaDv1rkVo3i5vvp8OAfrbRxiMFzv/HLCEFIl16C8/UoX07goMmZqfsV4qHoLWTapJrCoTvDdCEausn1VPjEg5bhjVCmLvULiJtJhg4FGCAOmZaKX07gbfeh9TvyANnPSK5QEOFaDvvQz9ZzrM/YyK1GOc4WootzC4oVj/vKQYgOK8sxjYvvDGVPjNdXem8jdacqq5ZW/5qZwfQPXFkpoQ1JdVd1nW63Pagq4vOEj+dKO6fr++ofQt1Xx+EiCkXO+1jRbw8AnCdmJgitTaTCAuySW1AqSEaSL0mu9n6wmf4AXnDe+Igo0Lqejd9eyl8Se0PQXQqImltWP78sO4FlDU8dDRiCZ7ZCpiT+Mdy27VmxSL3CLUQrGJ7wADKkgFiqU75HN2yYbKZAqhti0Tz1tQyJn+3wyf UFhe7GLw k7nZTL5SvZP7eRCGCPjoUYGySd/JxLl4MrVljVAI6Q4KDVZrwrmMroJ97MJpVxye2coNd7+GcYfoepYe4XyvRD0wFHtW998WuzyAjpTTYDyJLHvMZrRR68NC6b/ipMwXLDY4Wn5qD09GxZB5KChkp7C0V8QOFjZ4y0pBx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --FfqVFWjacRZfxsuZ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 13, 2023 at 03:50:45PM +0800, yang.yang29@zte.com.cn wrote: > This patch updates shadow_nodes of anonymous page when swap > cache is add or delete. By what? > diff --git a/mm/swap_state.c b/mm/swap_state.c > index cb9aaa00951d..7a003d8abb37 100644 > --- a/mm/swap_state.c > +++ b/mm/swap_state.c > @@ -94,6 +94,8 @@ int add_to_swap_cache(struct folio *folio, swp_entry_t = entry, > unsigned long i, nr =3D folio_nr_pages(folio); > void *old; >=20 > + xas_set_update(&xas, workingset_update_node); > + > VM_BUG_ON_FOLIO(!folio_test_locked(folio), folio); > VM_BUG_ON_FOLIO(folio_test_swapcache(folio), folio); > VM_BUG_ON_FOLIO(!folio_test_swapbacked(folio), folio); > @@ -145,6 +147,8 @@ void __delete_from_swap_cache(struct folio *folio, > pgoff_t idx =3D swp_offset(entry); > XA_STATE(xas, &address_space->i_pages, idx); >=20 > + xas_set_update(&xas, workingset_update_node); > + > VM_BUG_ON_FOLIO(!folio_test_locked(folio), folio); > VM_BUG_ON_FOLIO(!folio_test_swapcache(folio), folio); > VM_BUG_ON_FOLIO(folio_test_writeback(folio), folio); > @@ -252,6 +256,8 @@ void clear_shadow_from_swap_cache(int type, unsigned = long begin, > struct address_space *address_space =3D swap_address_space(entry); > XA_STATE(xas, &address_space->i_pages, curr); >=20 > + xas_set_update(&xas, workingset_update_node); > + > xa_lock_irq(&address_space->i_pages); > xas_for_each(&xas, old, end) { > if (!xa_is_value(old)) Adding xas_set_update() call? In any case, please explain what you are doing above in imperative mood (no "This patch does foo" but "Do foo" instead). Thanks. --=20 An old man doll... just what I always wanted! - Clara --FfqVFWjacRZfxsuZ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCY8EangAKCRD2uYlJVVFO o/BdAQDMnNlScYe1V+iOgxiyUqa+4s6U6CuxgqAm32d4eSqx3AEAlj1BCKBcygkF cWXy2GN8ry6qwub9QEaS1RFWFhC6Ews= =a99s -----END PGP SIGNATURE----- --FfqVFWjacRZfxsuZ--