From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A00C5C3DA78 for ; Sun, 15 Jan 2023 05:33:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AF31C8E0002; Sun, 15 Jan 2023 00:32:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AA34B8E0001; Sun, 15 Jan 2023 00:32:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 96A598E0002; Sun, 15 Jan 2023 00:32:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8990D8E0001 for ; Sun, 15 Jan 2023 00:32:59 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 27779120A56 for ; Sun, 15 Jan 2023 05:32:59 +0000 (UTC) X-FDA: 80355914478.04.8DE28CF Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by imf14.hostedemail.com (Postfix) with ESMTP id 6FFF2100006 for ; Sun, 15 Jan 2023 05:32:56 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=UsjVTg8U; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf14.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.170 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673760776; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6pV+Lc/D2szFMSqw+ADbk9E95BAdnQD4U8oWvWD9EP0=; b=kq4bbOVkIDhjQ2NmwxKWqrh6xdoU4E26OaezT/lnx18Pzn9lHYPa1YBFmbxbvbLAaCtIah UBHZfNDT9rMvDJIT2hKnI8LhzyccmCGVpm+CqwJIxvfhT50yNNz6ijmKq8bDBUwgm5A+ct YDqY/k3WaEZVuvi3swJL6marp71lzRk= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=UsjVTg8U; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf14.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.170 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673760776; a=rsa-sha256; cv=none; b=x4zcbmbkTye+igbtoCrYyNq3PLPKm/9QzPUziCuRb2Bu+8iOkNQlBa1q8vWVoipmyqtEnD yeVtjpYN0oDDNPqH7fcISNTngJcAUD5rjjOXzxpNxTP4SBQuuo7b2LTV2xJSb8lczRhAr+ l6SMvCFvWqkE6X52/staOEvS8DmM4KY= Received: by mail-pl1-f170.google.com with SMTP id c6so27296480pls.4 for ; Sat, 14 Jan 2023 21:32:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6pV+Lc/D2szFMSqw+ADbk9E95BAdnQD4U8oWvWD9EP0=; b=UsjVTg8UKzR4bqwwTKuexbqPD1K8c7rYDjqkBdbFTSxrx2z6wdrNX0rYuViUtvpSLV aaTQxaoUuT4GWrqxIzEBSwTzVfq97lPKXME7jRoptzIp/axAt1lrlRmLuOo5bQrVrS4a GJLrzFIf55B1ja1GDXVtB6vuIGHlmafdSBUCM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6pV+Lc/D2szFMSqw+ADbk9E95BAdnQD4U8oWvWD9EP0=; b=hYg3nT3Cxnw7v6DmsKJwcBm/I/d40NCwMDFGRTLg3OP+WaBM8yJTM6h+5MOQ8URWm8 2isbhNkM4EBc+IdQ/Wl84R1omejAm4wZpoNey91VvVxK63WjWTJjC8tBZ6THdKo8Vgh7 AanyQV/W2/Bhlrgn3kuFMbGv6o/rPZQ4JPvl2lIdxIp9dzjwN6yoc2x9PbM7+fb5NEL0 DAoWexzCiHosnSsQHv+Cm7ziSWAtYsmVOB/jnkLyhZ+oNKJHJNdrKqlyYOE3C9koJwry 2xHLn4EyxfRv3FRysXikSI6P0OC1wEEIizegPKPAXrQNH5kxon1EdQ3sJPU9tsZO58sK 7SuA== X-Gm-Message-State: AFqh2kq/soJmkE03orTOESz6CpY1PwFF7MbC4ZsdpjhKwBzSH6YWz4hj 3FhGYzFLA9y5G6nlS72RKhbqjzXwyS+vzG6n X-Google-Smtp-Source: AMrXdXu476ANBdQERztD+vprQduoY6AMavWCXl/BPijSPZwRKQxObo9GyB33wyLGp+GtSOUJky208A== X-Received: by 2002:a17:902:ccc5:b0:185:441e:4cfc with SMTP id z5-20020a170902ccc500b00185441e4cfcmr100561742ple.44.1673760775240; Sat, 14 Jan 2023 21:32:55 -0800 (PST) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id s1-20020a170902ea0100b001913c5fc051sm5646253plg.274.2023.01.14.21.32.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Jan 2023 21:32:54 -0800 (PST) Date: Sun, 15 Jan 2023 14:32:50 +0900 From: Sergey Senozhatsky To: Mike Kravetz Cc: Minchan Kim , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Sergey Senozhatsky Subject: Re: [PATCHv2 0/4] zsmalloc: make zspage chain size configurable Message-ID: References: <20230109033838.2779902-1-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 6FFF2100006 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 9dskmi638icobpgacyhaj73wt5abop6z X-HE-Tag: 1673760776-220857 X-HE-Meta: U2FsdGVkX18qHaWobg1SngMI+gUPanCjMwjrMdMd4RbOmNYE0XBoWKd5qK0M0XZJs13biBZ0gb+Oo6izMyi720ALFlxMUwlsP2G3fF4nTsb1m48z4Do0MEZJuWi51SvH9RnCvJjuNPsEf/Wak1CAn8ox5pNU6O7ICArai384l1fQRTIRFHZPhNhMJPzM7NP7BdBGAUndBJT7lLcVlQEbs4TerWzWwreh7brRrzG6JK1nyQ3kEBGYN5SkzFjG7A+5a9vrqglnZQ3L0eaSf0fTmQUl0/AsmjuLCWpaNQp9EcaVAX3NtscqWZPOTKgwfE2t+gM4to06F5QuySsnkQdJxu3RfP7Kzj/2XMj+g0MEXZa4c6IKjBXXND2TpLhLfUP7YSO7kUobdf0K0Vk+Qs7/g4HxXgs0AQktl6YctZWXU1mhU/SDKBeNuX4We69wUGQHk14OPcwmJfkipXYxdXU9Dlv+/Ie16jYkWz7iRIL/DhD0DFe+ms87p5Oci5a5mWo6BvsRBXWVtO0TkhgLQdBPNT3GNWn8BHD5phE7IkElzBBLgztnZOTLhNfGqVguj+ays4iAM/zORtZuAFEGLgGeKND3xAzXewkL3XUgqiukILGN3v2PPM3QtVNbW8vDViCvKplMKHm+rhgLSPAOOELsnWOIZ//UoAPaV6Oa0/F3W1KvoGabNZ65ar7yIv4UDshYJkLg6dMSTiElkbNFyEq+ZeGysGWxoKUvYWootHxYqFT8IdTJ+T0AcgznsGWIYuGcqFTzprWmFHolvAVE+OdQosmEFby/OVAEHP756p9loS/kyAmFW17aJp2WonXfOJ61HlXEUzFR1i1BvHBFXSz5qtmsZc8BbK5uPX1rSd+LUZDjzqmta8d0fhPJHS7ucOT5kKJxc4PlaCwx0fnrIaPkzYCmGKjQl01GpbmbgHzXE9qOAHmOHbsbEBNfvRy5UiZwYZGyfizIm1SZSq3WllU dvq0P7nu +eG5tGsUmmRprVw4gClv2u0HdfiqRBfhy+uZ33Vqhrn+HlXd3+nSlCsJ37A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (23/01/15 13:21), Sergey Senozhatsky wrote: > On (23/01/14 13:34), Mike Kravetz wrote: > > I did the following: > > > > - Start with clean v6.2-rc3 > > Perform echo, did not see issue > > > > - Applied your 5 patches (includes the zsmalloc: turn chain size config option > > into UL constant patch). Took default value for ZSMALLOC_CHAIN_SIZE of 8. > > Performed echo, recreated issue. > > > > - Changed ZSMALLOC_CHAIN_SIZE to 1. > > Perform echo, did not see issue > > The patch set basically just adjusts $NUM in calculate_zspage_chain_size(): > > for (i = 1; i <= $NUM; i++) > > It changes default 4 to 8. Can't really see how this can cause problems. OK, I guess it overflows zspage isolated counter, which is a 3 bit integer, so the max chain-size we can have is b111 == 7. We probably need something like below (this should not increase sizeof zspage): --- diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index 290053e648b0..86b742a613ee 100644 --- a/mm/zsmalloc.c +++ b/mm/zsmalloc.c @@ -129,7 +129,7 @@ #define HUGE_BITS 1 #define FULLNESS_BITS 2 #define CLASS_BITS 8 -#define ISOLATED_BITS 3 +#define ISOLATED_BITS 5 #define MAGIC_VAL_BITS 8 #define MAX(a, b) ((a) >= (b) ? (a) : (b))