From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76EDAC46467 for ; Mon, 16 Jan 2023 07:37:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B688F6B0071; Mon, 16 Jan 2023 02:37:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B18A96B0072; Mon, 16 Jan 2023 02:37:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E0496B0073; Mon, 16 Jan 2023 02:37:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8D1E96B0071 for ; Mon, 16 Jan 2023 02:37:27 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 6F7111C602D for ; Mon, 16 Jan 2023 07:37:27 +0000 (UTC) X-FDA: 80359856934.16.558BDB2 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id E6EA0120009 for ; Mon, 16 Jan 2023 07:37:25 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=m8qsO75d; spf=pass (imf29.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673854646; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/AHkZm1OuYto89btHGRYiNjjnDO1SMKCfzrD5TaAIh4=; b=aLvh8LeCGr7td/Rx9SFG8c1T2qHt3gpv3UVqGfk7MtZh3KVjcpbAOI1N1haP4R6BDZe25W cz45jcp1vemRaWCOBYAbpT9Q7uQjRyRdt64Scv5ziAN0pOcirB8769ORLm1FJ0a0LVOoJI 3LKl2D1pjKdKVBU8amJRz/5X90S1dXc= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=m8qsO75d; spf=pass (imf29.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673854646; a=rsa-sha256; cv=none; b=F98sso1AMGFm/9UQLzHhNA8SI74uyJ5lpZAS3XzrMf5ClmInUFAAkWXJoUKhZ2iFsUTh+g o+Rvu8ekX6Oj5HkPL8vBJtvvfDQfgnfLvK2V3GaYoz9gCWYWdXfmP7lCT4jD2pcyF6JMEG Fs7HsdLEgFaHoiivvdONdYJE3ZUULnw= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DAF2160EB6; Mon, 16 Jan 2023 07:37:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0A505C433EF; Mon, 16 Jan 2023 07:37:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673854644; bh=Tl6jLwg9ODlFWmZcwhzVGr7C/u1X+6fbamRRbNhBmw8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=m8qsO75donOoh2XLqMaXotNJX+0a2mfQExgIP8AZfyfLQq+yD1Pf5CP6Ni/T3XcQh OSVostHbcmVZ+jGtmz48pdlDvQxZ2LUemKCczVSjotUr0/9Jhg45YQVmtKexP9aIxv K9qRj+aTgdwXZjAE8uzkFKmQWsVNA8QhLG3jBQpbvldFXLOBIzIWEG9VN+yDzyz/MV PNIIJ5O1NDAuXhQIvEnCHve3RNz+3DWRvzFsyUojqcZv9mCB1yGfp8fE5/PsdUdCNZ NC2k15EYGjFGsKiaEk+rmQuLfL8LbyvLwIgjmfrsJSqNMCRaUDV4hT69fsKqotbLFU gj5yF0jfEkHvA== Date: Mon, 16 Jan 2023 09:37:13 +0200 From: Mike Rapoport To: Peng Zhang Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] memblock: Make finding index faster when modify regions. Message-ID: References: <20230113082659.65276-1-zhangpeng.00@bytedance.com> <20230113082659.65276-3-zhangpeng.00@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: E6EA0120009 X-Stat-Signature: inokbkje3jrm7z77tiny48duodsrzu6i X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1673854645-30699 X-HE-Meta: U2FsdGVkX1+2Wa/yQEvs8kpls6DN+Hw2If2lJ8QKBmfK2YbQoOfgRZoTf0b5XjacJxlfkqHlvj/3AnFfwZjAubZENeUyK6HVUUf1vxU6XgaoFSIkiCzH77IYDXClPIjjnPIiR9rLhLi+aNuYuzFqYxDh2lG2MRi4XTqDf4zDwmeJhsXGjuj41sMkYabR3lbj+Ty288bS4HXAxoDC3PGEHeKs8V25nCSifjuKCuY2P9wrOmypE9OnAr2MpNkcu/rJxKx/HS/m9E+P5vRz0/hme6a1EIa3hEKCIOeF7xbPy+5krvX1QCcuJ+wUaxb1JilCKm5bltOlfo4Ke4L4R4zDtkMt0MOszFy8OHY6OTpUL6ePLFTSDQfBTkvPrc4zmtffWEJ4l9xf2rE1GmUbybG7jhyI/Dn21t4XcuvrA7jMkvsRQ+iA1zOAk3XAkxIeUMCKiGa4tO2AsGta2Z/7CdDUwYImtKcRwL0dB/qoVYzt0bdaAVYVN06UQBdmisCIFDcZFdqaLb2q5NiVlwxNLSFIqkjJfepZpczEfVRbG8ZcimdCbkmfqTx/roheKEJE6eUEENAnV+92a9BqGJbHNPE0vi8B20R6jOW2YG6D0WMMyYw+Qn5vehu9lF8pw6qJIC9wABAorO3E9G4uaBmR7N8Wugotc7/IN9amOtl0te4zV4SN08b59B870kzSmsowJoPtV+FYtbI09CGy1g1IRK1RIF821OiSDPB1MNtFDjXJE5WvlRu0YE22nQH4gsztyb7b/hsTPM2URlSaI4bX6pC29NzQ1OtI3DyXLdcOFwzrDAUJ+V0pjwIBIIGgiaBpIT8j5IAygC9aFyLPuvxMCdmr40OTKE4QRa0F0GiSTP0ZCeIBDf6U98BkHAn/g4Mlu4YiMowJeQz++dUpc8WuLW5NULxl6UkvLMoFU3pR9E17hDguVS1vT/vyu3Ex+EsZJSYq1v1EitO4CgbibHcX7lR fGcHnOKN 2BmtEd9xRFsgzbwfeRBARcBxQ1YkanjkdvCBJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000013, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 16, 2023 at 11:17:40AM +0800, Peng Zhang wrote: > > > 在 2023/1/15 22:02, Mike Rapoport 写道: > > Hi, > > > > On Fri, Jan 13, 2023 at 04:26:58PM +0800, Peng Zhang wrote: > > > We can use binary search to find the index to modify regions in > > > memblock_add_range() and memblock_isolate_range(). Because the > > > arrangement of regions is ordered. It may be faster when there are > > > many regions. So implemented a binary search and a new macro to walk > > > regions. > > > > Did you see a measurable speedup with this optimization? > > I'm not in favor of micro-optimizations that complicate code. > > > Thank you for your reply. I haven't measured this patch yet, theoretically > this small optimization might be difficult to observe. > If you think this patch complicates the code, you can ignore this patch. > > These three patches are independent and they can be applied independently. > The logic of the third patch is very simple. It will not complicate the > code. It is tested by the default configuration of qemu. The total number of > iterations of memblock_merge_regions() in the third patch is reduced from > more than one thousand to more than one hundred, this is only in the case of > a small number of regions. Can you consider the third patch? Can you please send the numbers and show how did you obtained them? > Sincerely yours, > Peng. -- Sincerely yours, Mike.