From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C25F8C54EBE for ; Mon, 16 Jan 2023 03:46:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F53D6B0071; Sun, 15 Jan 2023 22:46:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A5A36B0072; Sun, 15 Jan 2023 22:46:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED6376B0073; Sun, 15 Jan 2023 22:46:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DEEC66B0071 for ; Sun, 15 Jan 2023 22:46:13 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B7A391A03E1 for ; Mon, 16 Jan 2023 03:46:13 +0000 (UTC) X-FDA: 80359274226.25.1F99F54 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by imf27.hostedemail.com (Postfix) with ESMTP id 0DCD240012 for ; Mon, 16 Jan 2023 03:46:11 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=HIY+W0ev; spf=pass (imf27.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.51 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673840772; a=rsa-sha256; cv=none; b=Gcgmi9QKWkOSJmEXt+kg4TPOXxL6XSa5Dpx2AEuX/pmIkvYHwI4nmzwAqGEiQ0ngm8sgsY 3okOsZV8AlQrPoWLSYEcTRUjPr7FMK5FKgV0XhNGt93/Edfvvv+nvlszd0NjavQ1C9gsZZ OWmv7B/VowdP96tYR7hbBmhPYuVEvas= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=HIY+W0ev; spf=pass (imf27.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.51 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673840772; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OLF9LDPywIH2CQhdt+WdpQ3H/KRGlA2mgi78cfBC+2E=; b=AosA6oB8GD/OQVuX0l9BP2IA6t7Nb9YD7+vlvAk265rmryfPZ8sZAI5Stywa4crDrgqRQB keOgWFBflKZ6dFWBgQKcBL+BPygpJiokaR/zZGMY/VKo+p5RwBygK5+CgS+HKlSOzQ61BO tObcXK0jTfBD/AHuqiUxThN0YDMV9OY= Received: by mail-pj1-f51.google.com with SMTP id x2-20020a17090a46c200b002295ca9855aso1670624pjg.2 for ; Sun, 15 Jan 2023 19:46:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=OLF9LDPywIH2CQhdt+WdpQ3H/KRGlA2mgi78cfBC+2E=; b=HIY+W0evMjl0ltmm5N+7Vono5/NQqKq7yvJyTJbsTWd5JFumfJ3iTzCbopTvUzOaMG BGCHA6zrjQI0g9FVvr/6n1SuRQDcmSdZJNTF0yyGAooatXY0GZxNVtV9BcoJNjr7FLE2 W60TLtiOgP597YCj+liVCzKM4YQjsfG4RZmtU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OLF9LDPywIH2CQhdt+WdpQ3H/KRGlA2mgi78cfBC+2E=; b=M6N7cvNWXpAUxeE2hDDmgakXDwZYvMTPhCYyAgCKaLLM6QiLm83ro1QJBIdOdNZMA+ zGL2As/9SkhbXXHVn09aD1AQ9hswwjsZl/p7tLDozS8G24/ceikXq3TQCUow/cdpRy15 CGQmWZBn92JrJTumMuKdSbQ1wHRPo9kwaomlyUGMw9TuD5BG5A+8rA9spHUA8JeHiYfj PnXbBEU6jgqnaGXKTJguTctGyDIC2AQ3jVSHKVQbL9osvfvxvZQ6SH2jQ6tlJIsKBxax klFakcm3YxLRngdWPmuFefjISW7qzMXqcv8JWQT3WMbN7zJZzevTw2GoOzqrtuBOXqqU p9mw== X-Gm-Message-State: AFqh2krRei9JBz7bNxwtGhzY5Ic3Qcyr4At9pT/tw8s4AVrHXGT3KkyO EuN05dkLQ7vOlnJpMtmUHr6fZQ== X-Google-Smtp-Source: AMrXdXvPkrh8ktMjPshkyW5xQ8T/PSWD3MiZFo2ya2FGF5Egfo+VrQOMD8D9a5c8W2gkNg7ZCaLmMw== X-Received: by 2002:a17:903:1d0:b0:192:4f32:3ba7 with SMTP id e16-20020a17090301d000b001924f323ba7mr113458205plh.18.1673840770853; Sun, 15 Jan 2023 19:46:10 -0800 (PST) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id t2-20020a170902e84200b001946a3f4d9csm5669226plg.38.2023.01.15.19.46.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Jan 2023 19:46:09 -0800 (PST) Date: Mon, 16 Jan 2023 12:46:05 +0900 From: Sergey Senozhatsky To: "Huang, Ying" Cc: Sergey Senozhatsky , Matthew Wilcox , Andrew Morton , Mike Kravetz , Minchan Kim , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv2 0/4] zsmalloc: make zspage chain size configurable Message-ID: References: <20230109033838.2779902-1-senozhatsky@chromium.org> <87y1q3qneo.fsf@yhuang6-desk2.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87y1q3qneo.fsf@yhuang6-desk2.ccr.corp.intel.com> X-Rspam-User: X-Rspamd-Queue-Id: 0DCD240012 X-Rspamd-Server: rspam01 X-Stat-Signature: cxns7pfzb5owbqpc46ti6r6y1z48h3ac X-HE-Tag: 1673840771-106681 X-HE-Meta: U2FsdGVkX19cTXnEYQr7ELF0Zr7ysCsLFkCktWFj0rFRRqd3MtXb2fEHFX9yW/e7O6UMgzUk4mHQzs7XuO3UfMV9R/Hnza+84BZ1XQbcLb3K1OxMj2aN0TI/okwKtg75YUvyDsrSBv0p0dYSFtcbs6kgd0GJlmosfffrHMLr69C2hoaWqnSybTWSwuocgHJLUImcWeS2kLJKt7B1YeKkMHiwvSYPVsMUXja60XwAYjEF2irdXFJfrxQUEw3lEmq5o3ZZU/F+f+2cjPEH1wKxSJXQ5bSIw9vAcY0KSjs5Y8FA+WmpCvm7lTjsueJ6tz1HBYpvLnlly7oppkPW/E3EHCB6sQ6vICqHdk/pCrDEy65r/3whLf4Tq+6JGt4grCfWKuFFkswY8OqiOyg8BSOAzmPqAw8AZbC+jCgex8xaT5YMBAmIRHraFfh1xOHXvIULBVc1BN09ybjzTHF1/ZRPRVPBL9XMZyIYtJPTkY8ya+WVSiD4yG4I14r3Qo1hZf+00YFlor4pNGASJK6CjkpDVpxMrKI0NlgMdoFI25VjJRK7NsG9zgsrfwvtqx6nEgLGtmlJs1kdjGgBY8jqFtGnT0ro4D3Zsyh2Hi9/JkDPpsWecu4yIoZ/TQ4Zrh+S+ffqXKZMYmvja9WkYbK95Y3q01hsQCdrIuF6+xYFXAqE+INOptGXKEIyQCeVYsf5PERn8gALR+Pj5eu/LBAoMbocAzTnHuDaKHoFQXl+2d97eGhxzeNT2hBPKXKQqFGU4Gnee3UrA7YCXaIVbzwV4DRtty97hAfYoWIPbEhF4RjVzLYDTOw89zX+DznjPIVGM5RAr3LB1uePPVvcV/x8D3vnyswLZHDdJo4I7kGz+OSXOkrpL0gtNZ3WL5hVYMcQ1IVUktSpX3ekjgUizslPGL5QbLkIs4aXAr5T9jJYPszUQs0UrZb7gT9cU6h2pmst0mc+bLPTYjJG1HeIea3VNGA 1z74TAby yZyRaC1P1rAeDZU8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, On (23/01/16 09:27), Huang, Ying wrote: > >> [ 59.546261] Call Trace: > >> [ 59.546833] > >> [ 59.547371] ? lock_is_held_type+0xd9/0x130 > >> [ 59.548331] migrate_pages_batch+0x650/0xdc0 > >> [ 59.549326] ? move_freelist_tail+0xc0/0xc0 > >> [ 59.550281] ? isolate_freepages+0x290/0x290 > >> [ 59.551289] ? folio_flags.constprop.0+0x50/0x50 > >> [ 59.552348] migrate_pages+0x3fa/0x4d0 > >> [ 59.553224] ? isolate_freepages+0x290/0x290 > >> [ 59.554214] ? move_freelist_tail+0xc0/0xc0 > >> [ 59.555173] compact_zone+0x51b/0x6a0 > >> [ 59.556031] proactive_compact_node+0x8e/0xe0 > >> [ 59.557033] kcompactd+0x1c3/0x350 > >> [ 59.557842] ? swake_up_all+0xe0/0xe0 > >> [ 59.558699] ? kcompactd_do_work+0x260/0x260 > >> [ 59.559703] kthread+0xec/0x110 > >> [ 59.560450] ? kthread_complete_and_exit+0x20/0x20 > >> [ 59.561582] ret_from_fork+0x1f/0x30 > >> [ 59.562427] > >> [ 59.562966] Modules linked in: deflate zlib_deflate zstd zstd_compress zram > >> [ 59.564591] ---[ end trace 0000000000000000 ]--- > >> [ 59.565661] RIP: 0010:move_to_new_folio+0x362/0x3b0 > > Thanks for reporting. We have just fixed a ZRAM related bug in > migrate_pages() batching series with the help of Mike. Oh, great. Yeah, I narroved it down to that series as well. > https://lore.kernel.org/linux-mm/Y8DizzvFXBSEPzI4@monkey/ That fixes it!