From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9700DC54EBE for ; Mon, 16 Jan 2023 04:35:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 86CC26B0071; Sun, 15 Jan 2023 23:35:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 81D6A6B0072; Sun, 15 Jan 2023 23:35:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E4DC6B0073; Sun, 15 Jan 2023 23:35:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5AC976B0071 for ; Sun, 15 Jan 2023 23:35:38 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2464C12031A for ; Mon, 16 Jan 2023 04:35:38 +0000 (UTC) X-FDA: 80359398756.27.FA87CA0 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP id 5543120006 for ; Mon, 16 Jan 2023 04:35:36 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=IHzhB2qA; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673843736; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6X5H5b4mTEHtRm79YlcNwUJw2vmgwvvxhyKoNWNRjmk=; b=XOjLDsHaJQFNySd6IeQ4v5DqQe/6/gAV6tfG93hO9bStt541khYT9bI8W0O2G/jzstUgnl TrWy2eLgvuYkLAb8901qT5+69bxJp4wJY0e4j4WPkuOAdtqB/yH3K1D0+dzF+05Jwm3MR/ OppAz5762FjxbAbSaONaQQdL9Yy7jrA= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=IHzhB2qA; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673843736; a=rsa-sha256; cv=none; b=MYTUubb4peZ4qNEGuBFp6K9xaOp6kfm/57rbAbOx7IFQE1nvUZuFIR7kxbUwMYXVNSvkaW jqerKUV3Tw7LWcyzb0+9OLcdAMmiXYr6+P8bYzDyo8T7FZ/DtVyciqwmDBZPeufOP84PJd eK+BA7/tejSiHul8T7pwzI7dy6C1S/U= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=6X5H5b4mTEHtRm79YlcNwUJw2vmgwvvxhyKoNWNRjmk=; b=IHzhB2qAPOkPwlxaUbIKJeX+AV QXSYncECDy0NAaJ6A4CrkRL5zdeBBP8vyJu1Bf6q157ve+igyBCIcibGfkOik+hzMckBwA1mVtk9f g674es2LWE9nhBvJ3fGgQurXz9XALqnecx8VgaMGCKntm9cvxRv15DUeAqPLhsvrUi8aS+k5cW3Lt YZ9yUzerZUw5tbXQ7TGb80ENjP4B18cHdQ9KQ19qziHAh4ICj29iFbboRUfRJc3JHObIvBNxtVKFU RyWDQcjC+Bj9ZneCe/nxRVLHNiObF3IAsbKX2lMzZVM7A0mskU4zQQw8ViYZiloFj/COlG3tYeKZU +0gL3GWw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHHDX-008QM0-L6; Mon, 16 Jan 2023 04:35:31 +0000 Date: Mon, 16 Jan 2023 04:35:31 +0000 From: Matthew Wilcox To: "Huang, Ying" Cc: Mike Kravetz , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zi Yan , Yang Shi , Baolin Wang , Oscar Salvador , Bharata B Rao , Alistair Popple , haoxin Subject: Re: [PATCH -v2 0/9] migrate_pages(): batch TLB flushing Message-ID: References: <20230110075327.590514-1-ying.huang@intel.com> <87a62oy5o9.fsf@yhuang6-desk2.ccr.corp.intel.com> <87ilhcrzkr.fsf@yhuang6-desk2.ccr.corp.intel.com> <87bkn3rw8v.fsf@yhuang6-desk2.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87bkn3rw8v.fsf@yhuang6-desk2.ccr.corp.intel.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 5543120006 X-Rspam-User: X-Stat-Signature: 89exwydd3a7c67h861dug138pjz5fqmj X-HE-Tag: 1673843736-235157 X-HE-Meta: U2FsdGVkX19vBVfC3UTR5b/6xkcVwSYwB1n7D4IJ0uBy5J/Q4kRDMyTxMPVwtR8kb2CjT1oKSx6+ALusXOCye076lr8XMSza9/nCgRvjqUEQF37xH9m4qdpLAHjNFrb3y2y4Z9Vw88zTi3lR6MTkjjh9ewvrzQDzicYvq8LLPluCMi28UjFHtNVN5oEYopoH15BFjhQJzfAoJjkixv9CwG9XxiZEr6GfzTVDxCAf7enElHU8pDqv1blmQfHyprTWnVQS9RPP0VS+as0nAcHOvkq/myAbVWnML1gFAmvtnVCnu1GLCe0WEp+wZqzjXKj4Jg/cThom+B20fL2n1/2yaWMdKxWtMIK5GHg6+6XQmC6/vOnIgo9DE7+0eE9u1cD10Qnvpw6ystZ5MjNm8Rz0yPUsA7+3p/IhkVBIoOWbjWnH0KA64u/ADDzkTIHVGXcWpOsdzA2DEFjC+BHTGhPD99eQj02NL9F11fXPU5QV0SbpNp3xCD0uF/2eQTqhaceDmOHRZ38Xbx1J/PhLBQ/b7cejOyOdmuLpPWkHDiPhUtXwEehRMlK3iz1KOupWzy29bKpseJvrcHCzScucQyovka50Crld1eAxQyaEbXlIPn826m9CXTp/niBNdAytZrbjfzsINZFR52AwYcYIT6PBGpPF0LpDm5D71Mo2N9agi6n+QqzKEO8QfKoTveECNpffbyrrGnWju12Pz4Aoj2aZs1CGEjrctS1UPY8djRkOr9rGz6yIqqrBpgzMbIiIRnKMC+OyQDwUci8KpXjLE1Xfwj5Xk2D3ptEiZllDjbNx6KIFzRgnayE//ngPgUKnLpQE2cEitJ3MNbB5c8rmJe3jleE+5m/6P2wnch6qwxVcNLm79nP0Tv5VGgvNX7sn4lECNQ61Xu2dRtQNcpVrcKyTtQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 13, 2023 at 10:42:08AM +0800, Huang, Ying wrote: > +++ b/mm/migrate.c > @@ -1187,10 +1187,13 @@ static int __migrate_folio_move(struct folio *src, struct folio *dst, > int rc; > int page_was_mapped = 0; > struct anon_vma *anon_vma = NULL; > + bool is_lru = !__PageMovable(&src->page); > > __migrate_folio_extract(dst, &page_was_mapped, &anon_vma); > > rc = move_to_new_folio(dst, src, mode); > + if (!unlikely(is_lru)) > + goto out_unlock_both; This reads a little awkwardly. Could it be: if (likely(!is_lru)) ... but honestly, I think the polarity here is wrong. LRU pages tend to outnumber !LRU pages, so shouldn't this be: if (unlikely(!is_lru)) { just like it is in migrate_folio_unmap()?