From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5328DC54EBE for ; Mon, 16 Jan 2023 12:24:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D001C6B0071; Mon, 16 Jan 2023 07:24:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C89746B0072; Mon, 16 Jan 2023 07:24:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B2A2C6B0073; Mon, 16 Jan 2023 07:24:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9D38F6B0071 for ; Mon, 16 Jan 2023 07:24:05 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6C3BF40817 for ; Mon, 16 Jan 2023 12:24:05 +0000 (UTC) X-FDA: 80360579250.01.EE6BAD5 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by imf26.hostedemail.com (Postfix) with ESMTP id 978B8140017 for ; Mon, 16 Jan 2023 12:24:03 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=TmbuMuF0; spf=pass (imf26.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.221.43 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673871843; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3vLKemaUaWA2M71p2ZRoCgzBORvg7EAfdOMqyeO6w0s=; b=dVEWC2wqQads7NMohPJBwZcE0zTH7CMBMw1arjrvYTN5eHeHYJFt+mazEP1x43zjZR+MEM yXGUxTD7dGR/LlRdmBHnkAVVQWcreBnZTCgBygJlng0O1h2vWYiWEQjwidOu/e7oj8uqiB LDkwfvkNWDbL2OEEPVnv4GWX92N+7A8= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=TmbuMuF0; spf=pass (imf26.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.221.43 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673871843; a=rsa-sha256; cv=none; b=NpztUnHuqrgdpd+43xLULjDt370byklFhwJNvLX9EYvzlR3+XcBmmZJPektaDQwa6cwkZL 8uZVmOG68eCsXbg9mv78HTt+W5hVZ+9K1vJqfP4UP9JgPOBPK4k8m/DaW8h/JK3tEee/6b QfMfi0cbuRZZrlXGprTmqK28Yo0Lghs= Received: by mail-wr1-f43.google.com with SMTP id r9so4516138wrw.4 for ; Mon, 16 Jan 2023 04:24:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3vLKemaUaWA2M71p2ZRoCgzBORvg7EAfdOMqyeO6w0s=; b=TmbuMuF05vpgltiucUluFh+Y6gDWwdnY5Tm4iaGqOVliEZzgROT2LyX6ObzXmdqgKg hL+Z7HPembSdWEozpDQapOj1nSdd8adDSKSq2JC9xmwoV+9Y0nzSxIHDOyqMdY9nPYz+ TSsxEMoK2ozlLZ9W8WwC4FwewYNVqM/ohxDRQgzFK57C/h9V/lrGAg3Z6rm9PjAdnWFS tQMoRyp/OEK8MAgHRxxQqzbaOM4EnJ9wFQY2Uj95a90N8MlEDuZJiUFpNWhIJIYafAex pcWRf1xnojjABMVUV8KMiWc6uhYxNxgSu+FHPfv6hBTcV73lMxH4JUfaQry8YuJzye4B P+Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3vLKemaUaWA2M71p2ZRoCgzBORvg7EAfdOMqyeO6w0s=; b=XoZPLzUf+iNoZ0LStQHQDHYTdSPTb//q3141fKJ+dynGbvSjQSv1SeDtm+jnIMu1e4 r9UbEqc2HX2V7RMd/BUqTDbzcaiwsggNNUgRlsiDUaVhjov5newthMqrwORxazPe7ACa DSoHAgPLa9tkQ0NDXg+Yia+7Sst8PM4hW62/Y3g4BlWEti896OldRfcxr0asbPGDlXzr 6zG/tiEe3jMm5hMEI2MxIO+6gw1HY0oJnLRpvRrYRu2w9pFtEY/1snYDpEJcTlkilyod CO2N4plZD03CTe5t26nCK0umuaSYKNN8lQtcvQamoqIrqgD8FNLJvngfLGwtDoWy0ems 3tbw== X-Gm-Message-State: AFqh2kppJeI3lQMiLMMCSyQWFEJbnztQ6xEszdxdc235N6gPQD2tHbHW weQUFZkaisKPWuHFkvCtEG316WflOeM= X-Google-Smtp-Source: AMrXdXtTVrb9gX3/l3rkA6X80ajTCz5+pUjgZESkh6QTGnxtB+LLVHe1QNkw01HfblRXq1S/1WabqA== X-Received: by 2002:a05:6000:256:b0:2ba:f555:613e with SMTP id m22-20020a056000025600b002baf555613emr6077447wrz.65.1673871842245; Mon, 16 Jan 2023 04:24:02 -0800 (PST) Received: from localhost (host86-164-169-89.range86-164.btcentralplus.com. [86.164.169.89]) by smtp.gmail.com with ESMTPSA id z12-20020adfd0cc000000b002bdff778d87sm3408782wrh.34.2023.01.16.04.24.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jan 2023 04:24:01 -0800 (PST) Date: Mon, 16 Jan 2023 12:24:00 +0000 From: Lorenzo Stoakes To: Baoquan He Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, urezki@gmail.com, stephen.s.brennan@oracle.com, willy@infradead.org, akpm@linux-foundation.org, hch@infradead.org Subject: Re: [PATCH v3 4/7] mm/vmalloc: explicitly identify vm_map_ram area when shown in /proc/vmcoreinfo Message-ID: References: <20230113031921.64716-1-bhe@redhat.com> <20230113031921.64716-5-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230113031921.64716-5-bhe@redhat.com> X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: nchf8qehw9rac8hg8jmn48qjn756a45j X-Rspamd-Queue-Id: 978B8140017 X-HE-Tag: 1673871843-918572 X-HE-Meta: U2FsdGVkX19xsYUoWMZzYZqDhFVKB3V5bjaaWjBdjvhdeKm+jztq9U0mcIfbgqCOpHjwjVnxd3MphY6wcNMYozWkb+NzJLUh1+Pmq9uMwQCpz6qfMCCfvVuMO2pCI5FpZ4K6cGffOhjYpafVAi2u85jUWbsTPiROc1wVKeMZEVOkmUgllBpsX44O2cA8WKfSZC+ewb4TvCnCXRkGTwZBKHzCn3hJ3wQjkgwTcE9MPcBIbxqW/ZG0r2AaeivAlZLCVau0V8LcRGxvdTkF5+QJRAEXROjpangifNaj4i6jEm/ZUgB4mOxCcUG3FzVmPae94Dav1buNk4waiNZMcQS2rKNTbYirFeqZkoL18e7tNonwl2y50gNtknpRbQGCutt67bzrLsWiEV6Cn1zSSNDWkzj3zcCrexHBkfV6QheDz6hwB6UM/JKPT9PgT+s14CSNPcxQmKx5jhFAaLRXYytMKowtXKqgduwnQ9PoUDWEDTnxbJkh0fQEi7pDdxRFSr1f1gLryexv4sPZ47JU7/3/97kupryJ6evooGamyhxYBVXTjWGr85r5Sw5gqkuah9TNA8p2Jc1V7gs8LvNP48KdsDw+07nviyk38hzs3oc9GroRmthvJYyIpoajvlrz+rdG750rq2QXt1HDaKuf8MsaoJoh04cWpaS9/iH9l+s92m8Jijl1VfFPLAZjsG7KjK5cRxDqAPmZ+ox0Azsn10ffd7asf/ziq8fJYAZFvtXOnvPjIN709sjVSUbt3d5Kz2QbOEHI2E+lIQY7OnswBQx9/VW3SP6zjw9qPAt6I+wpwYiXmBC0MEGihXaTHp0Clurwn3jkUfbXEwKH8HFbKzfaNu3+quNdW4/dDjGC5MDpBt3lZBIJi5QnQYrEzuqgf5YxRnUXl1jFmUlfyjRxCFU6yr93H6WuwPEoakm5gHwvUN31rp4rwVdnYQ7bksOBP+uS9IeJmzyX8qrIrbOQYIT 4JMf2aL8 J+F3pdO1L5sSqu9tymO9mtYrLlQZZelCHGCptGMKcoIROVBxFqLCKh48BqSYnuaF8gk4OQQSBVwQ/NRlzRYA8NNIifz5dXj44walGi8bxsRwp0AGlltPgMSMx0Xr5NyQKlMeXmqZqRI2718g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 13, 2023 at 11:19:18AM +0800, Baoquan He wrote: > Now, by marking VMAP_RAM in vmap_area->flags for vm_map_ram, we can > clearly differentiate it with other vmalloc areas. So identify > vm_map_area area by checking VMAP_RAM of vmap_area->flags when shown > in /proc/vmcoreinfo. > > Meanwhile, the code comment above vm_map_ram area checking in s_show() > is not needed any more, remove it here. > > Signed-off-by: Baoquan He > --- > mm/vmalloc.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 13875bc41e27..4a10b3b692fa 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -4225,11 +4225,7 @@ static int s_show(struct seq_file *m, void *p) > > va = list_entry(p, struct vmap_area, list); > > - /* > - * s_show can encounter race with remove_vm_area, !vm on behalf > - * of vmap area is being tear down or vm_map_ram allocation. > - */ > - if (!va->vm) { > + if (!va->vm && (va->flags & VMAP_RAM)) { > seq_printf(m, "0x%pK-0x%pK %7ld vm_map_ram\n", > (void *)va->va_start, (void *)va->va_end, > va->va_end - va->va_start); > -- > 2.34.1 > Reviewed-by: Lorenzo Stoakes