From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BA6DC63797 for ; Mon, 16 Jan 2023 12:25:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E10836B0072; Mon, 16 Jan 2023 07:25:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DC0E86B0073; Mon, 16 Jan 2023 07:25:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C8A106B0074; Mon, 16 Jan 2023 07:25:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BAD646B0072 for ; Mon, 16 Jan 2023 07:25:09 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8ECCE1409CF for ; Mon, 16 Jan 2023 12:25:09 +0000 (UTC) X-FDA: 80360581938.13.15DEA0D Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by imf02.hostedemail.com (Postfix) with ESMTP id DB1888001C for ; Mon, 16 Jan 2023 12:25:07 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=nlf4mxN6; spf=pass (imf02.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.43 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673871908; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lAPYg/ZvWBJjUQwtgLMe2yVs/QOrldZYm/bQtr2RTD4=; b=3r5auWkEYp0iOIxECNEKRI7UOj/Kh1kgqcQOs4hT78JEduUiQQ2rXklMtR8I71YOArP0ch zX5KNAzq7UGETtV3iGaphmXLje+mn2Y7rwA9pL33qdIeLo6av+Q6GCFjdYhHaTkBKa/AZm rwEgUKQOQ6wrK69pNGAc7MevcsG5fyM= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=nlf4mxN6; spf=pass (imf02.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.43 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673871908; a=rsa-sha256; cv=none; b=QMg1Kg6zBpI6Y45equhiZr+7hgAdBcM2bVA/qImgcgyJrSCgxcTP2oLtlTbZwwLukexhRs dmw4Ya+v1idlotRYz+oga4Ql480Y3a/pAhVUSYQUSQMETdwCUihbrr5OqLYE26QKEIOqwT K/ANhQZAKeQwng/PzPZrleb3ao1tn0c= Received: by mail-wm1-f43.google.com with SMTP id l41-20020a05600c1d2900b003daf986faaeso2117760wms.3 for ; Mon, 16 Jan 2023 04:25:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=lAPYg/ZvWBJjUQwtgLMe2yVs/QOrldZYm/bQtr2RTD4=; b=nlf4mxN6WlnHSI9yZLFFKUieEv+F0BHxIuXsVVf/lguDjouSr9E0dxwEeAcnkKvFs6 RZWJKKGqMMHMzdzLpZ1zZjc4L9EwHVw/zu4ut8TaEyhMSmVXOrhlzsmDfZWhq6uPD2xJ M9F9ZQqLY/adKNBoJ/eNHCeT3xXbw1c2peCFV2pvqZ25D2CAoSNWz1bjcAWrDa9rZjlR TWXarLaYQ19gkxu3OW8DdV+aSG063daEUV6ZK/GHS2LtssChbreg7nxUfgSkkW6QjrL0 OHgcU3Wa8fM0q2LaA2FiuqYiciAvTDDudOpllXN4Kw8I0Dx1js5l+mHwboSyBj0SIIBs 3lSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lAPYg/ZvWBJjUQwtgLMe2yVs/QOrldZYm/bQtr2RTD4=; b=z9IqZL9iSaR2l9qOCd+RY3+pRFXvF8gCWM22ij6+PM3gr8ZHJund7/DLv9F8WIer9x VNqhD3PM7D4NfUjVWtAtS/OwtvWTYhPCi7RrdFACYuqLuaHXRYKlXuMO/ShG6Cdp5777 qg4TMdN8oe8BMCJ8XescLQtDTsefN1hY3cfmo4Sm5up+5n+aDEkqJSCdrSR7nNAUWlg+ EXQFXvx+WzC4uiLfWnakESvAH3/DnHLUIVtIDYUW65SOTxW+4gdvShby/DAhSEY+gzJR R7BDUc1CgsoIZXHBP338Jgvnxat7wmLjo6UIVy6DJ2juvXJS8N9t/zpgngh32XXC0WDK oSZg== X-Gm-Message-State: AFqh2kqSRs2vp9oa/7uz7gb2SNPI+Ih3cpFkaccq9RGi8QGNHaAyKDcz bMKuANo6w1PWNTul9tVkx9A= X-Google-Smtp-Source: AMrXdXuDZx/3P4IJpzil2eHi6fJoaVfDCc/FM92eo7r9oqnkPDgkTEw11YP9bKcAVid1i44ckTdGtg== X-Received: by 2002:a05:600c:2142:b0:3d5:365b:773e with SMTP id v2-20020a05600c214200b003d5365b773emr78322318wml.39.1673871906531; Mon, 16 Jan 2023 04:25:06 -0800 (PST) Received: from localhost (host86-164-169-89.range86-164.btcentralplus.com. [86.164.169.89]) by smtp.gmail.com with ESMTPSA id fl12-20020a05600c0b8c00b003dab40f9eafsm6838196wmb.35.2023.01.16.04.25.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jan 2023 04:25:05 -0800 (PST) Date: Mon, 16 Jan 2023 12:25:05 +0000 From: Lorenzo Stoakes To: Baoquan He Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, urezki@gmail.com, stephen.s.brennan@oracle.com, willy@infradead.org, akpm@linux-foundation.org, hch@infradead.org Subject: Re: [PATCH v3 6/7] powerpc: mm: add VM_IOREMAP flag to the vmalloc area Message-ID: References: <20230113031921.64716-1-bhe@redhat.com> <20230113031921.64716-7-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230113031921.64716-7-bhe@redhat.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: DB1888001C X-Stat-Signature: k1fniseg1p4enidue3i4txx6spbus6yb X-Rspam-User: X-HE-Tag: 1673871907-289011 X-HE-Meta: U2FsdGVkX18NrOYiXaMk4+DaDrC1g+CXeL7nPV2MBhWiyVvVknIcfuH+yHG1Y4C7M6d/hbUCC6fbKXWghz8RArmOAe6pK87tIqAS3tJram+aDPoRhul6MvWvlSuE1kchCAPyAPURqpAbgOEaV3gWJ+ENAmKFTvmO+6x0rZVVSvyCprYQiYKBSwPsh6m3pzsC0wMo5YAoP1PZvdB14eUp9KgD7c9dEzI6Mw457KhG5DlBfAset87N6ajWg1TjDTM7LPLuLIpkx43xX3RsWHMKDR2mWXkdsI93uMsi+Jv97B2VjwGHt7d86mqzhJU3ujxlvPY8jwyft+odVGYLP+tLtZGKHUskd6J8UgjYQJQIxafRPXCJq744449o5lkopDaQ82krtJdz5RHn84zkxYjbsIgc3kMZZiLGRxLwWuJ4P1c0TCcPbzrqP1v25qF7TMh46mCkEcTYHuLVhm/d5nLNzk1iS688C54w21XHUAtszNnf55+qWsOi82D0rJwGQiQxX2OZrZJiui2iSupOtT0GgQG5zUmilIWO9gRB8l6LSbFwVqlTYUeBXGHu535TeaPuownny5dfftaDs1GHqUvR0c26VCSsFiKlIc/FXTZkiXW7J2Vt1+6BsUvTSbREQkkc+BlWza23XrNcV/zP0jZKaSaaAD06A35w6pqm52yTKXnT85Kgys29Nf/L4CkLmIvuIBd+GDSm+wxiVj/QASuLS+kIFBIWcejnYmQ4/H6ljgn00nwJdt7vdhYQMAJzmRLSALmTdKN50HBtUfADsZSh7/VGs4zhig8zYntDROebkHVOzpQQB6ADriJJLqrI0BqcZgBxKIyT4eGP0gF3weR/re5kZeNkaiwH+OLBFZfezPQu8BTnedqML30nHTGt4uGZpjUM2PhVVLr1q60df5u6IGKBX2Q1f8Lsun1isXAOOhIYqtarMXTmUvvOarpiRCA5+oVQP6JmFq9pgwCQ9nl FGACoaQH fYqcjLF7WwzSjF0Mq+ZL4byiVkMrVV9jUIxGYrzLnLJzHgoSv4Gh+m58swLSuqQSQYnhY6Lxqw24uQq3oax2VTaJUIOVod4eK5CclDJOV1uI6n6xQgAvdzrGdbCUWeQEoyZJ9gJXYd1k4UU4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 13, 2023 at 11:19:20AM +0800, Baoquan He wrote: > Currently, for vmalloc areas with flag VM_IOREMAP set, except of the > specific alignment clamping in __get_vm_area_node(), they will be > 1) Shown as ioremap in /proc/vmallocinfo; > 2) Ignored by /proc/kcore reading via vread() > > So for the io mapping in ioremap_phb() of ppc, we should set VM_IOREMAP > in flag to make it handled correctly as above. > > Signed-off-by: Baoquan He > --- > arch/powerpc/kernel/pci_64.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/kernel/pci_64.c b/arch/powerpc/kernel/pci_64.c > index 0c7cfb9fab04..fd42059ae2a5 100644 > --- a/arch/powerpc/kernel/pci_64.c > +++ b/arch/powerpc/kernel/pci_64.c > @@ -132,7 +132,7 @@ void __iomem *ioremap_phb(phys_addr_t paddr, unsigned long size) > * address decoding but I'd rather not deal with those outside of the > * reserved 64K legacy region. > */ > - area = __get_vm_area_caller(size, 0, PHB_IO_BASE, PHB_IO_END, > + area = __get_vm_area_caller(size, VM_IOREMAP, PHB_IO_BASE, PHB_IO_END, > __builtin_return_address(0)); > if (!area) > return NULL; > -- > 2.34.1 > Reviewed-by: Lorenzo Stoakes