From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38BB0C38147 for ; Wed, 18 Jan 2023 14:35:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ABFF76B0071; Wed, 18 Jan 2023 09:35:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A6D686B0072; Wed, 18 Jan 2023 09:35:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9346A6B0074; Wed, 18 Jan 2023 09:35:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7F16C6B0071 for ; Wed, 18 Jan 2023 09:35:10 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 433C71A0977 for ; Wed, 18 Jan 2023 14:35:10 +0000 (UTC) X-FDA: 80368167180.27.B1109F4 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf27.hostedemail.com (Postfix) with ESMTP id 87C8B40037 for ; Wed, 18 Jan 2023 14:35:00 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674052500; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JfBTvkeJOx9tx0quLYYGYfVQ7IO/sB2UijFdb8/ibpM=; b=ZRiqF7ldkunfb/OMHgo4aC6z8Dn3kKo0kxcTjTAEDMnwdFRF5ASodz2vXgh1geGq3y8ML1 VGuoHbjBFuy3/owakcJ27+3Y/q8v/V6d+JPGKW2wChDWgPQfGWuh9jbHdiLz+tgiALORDZ fgehATXsgRhN2fxfqA8wmDWqxQMpEUk= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674052500; a=rsa-sha256; cv=none; b=ywC+R85hJqeS36ViM7MzeBz1sY7Qixk/N/v723ii2KkKcY9pY/nA1YVGIKw5p7+mcHwCRt qxSnyTi/LOebKGVA+yhrRhF+1+84F66B0tIhDqN3n1ecCtey1nABItNxsELmoh3JTQp0D7 tHnUCdOXGYeNiLBlcFMVI/mwZ9WWwnI= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id F0D1FB81D69; Wed, 18 Jan 2023 14:34:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C4A43C433D2; Wed, 18 Jan 2023 14:34:33 +0000 (UTC) Date: Wed, 18 Jan 2023 14:34:30 +0000 From: Catalin Marinas To: "zhaoyang.huang" Cc: Andrew Morton , Vlastimil Babka , Nathan Chancellor , Peter Zijlstra , Zhaoyang Huang , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ke.wang@unisoc.com, Mirsad Todorovac Subject: Re: [PATCHv3] mm: use stack_depot_early_init for kmemleak Message-ID: References: <1674007655-23016-1-git-send-email-zhaoyang.huang@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1674007655-23016-1-git-send-email-zhaoyang.huang@unisoc.com> X-Stat-Signature: g5k815ebj7s17xzy937n6zbxn5mn6q7o X-Rspam-User: X-Rspamd-Queue-Id: 87C8B40037 X-Rspamd-Server: rspam06 X-HE-Tag: 1674052500-421787 X-HE-Meta: U2FsdGVkX19tu/gL+h+NlyvMp8El5//BlQgvFMnK/QWkUyNyIy78SYU7rb4z/gDElMFun3ySAN3dmmj5StRC3//KhFQH3VDR0IanS+VuaOwM3lgGNBo1hX/BlXt91dC0Mi16jny70XG912XkB6pXo/ZaqJ25RwufmnBvNWcpTXYGhwZ8fPzScAgu1xnkwLwtHqvUujHB/emjbmVei54zJT4eUmzo5ofQyBVIKdzYnHUd+EEyIopZ1snLGUXvdqgXvL9OC9t1uatI+YvZtnmGv3o+Lyg+jGGNhTotfdn99xJoM0L4A3ybNqreYiLXITU39snzZn/f85GnKDl6y+c98d++bhisDnKenJSS1qish4gMK64s8+jdtjgeiZjxz0tRSBGUR64Q9iQj6k73vffDfPmzOXgD2Zu0NE9Isz9ei1RG8OdFkolQUBqEtiOfJVzKwTqWlfFQGn0V4rkVnCbqUW2GOTOiwYvSILA4qJQtWKG2R4DzyaFeqOawJ+dDnXuZHMHkPyoDrKjdxwDf6CPaMYr5/CF7Qoi7OYTd+3czV0gIX9q/sFLAVdp426DMIDPjRcEB4ieGFZFeRF7G3liDy+qIuodr1oTaT7hO6tK/VJC+vGxtbC1rDmI+cwOs0ONLICoiTAjM7awCc31WQsUPuGRRL41t5lO/APffQBB7qKrlHIPLcF2ZdadUzbdZHrDba6l/157iWJ62Xq41PnGcmcDhI9Ft1NbGn47S+8wbrcvVgA3uhvRAG40ZpVIYtSfFGeHdgbc9H7Fuqkv0LOwjLbDcGmvg814RCb4n9PNn++BCt8XCLEFjVXbiwXbljuEBsf1BQeE1TGO103UqxiEhCm8x7vOzluBnVZ6bIvNy0GqGXKqHpgtFvajbtvTMLePdCxBUdML/+c169jjGFuiPVnXqw8Q958j6TMgBTLsLfbVEhBMWq7CwFBlK7PLrq26EPE5cjFgujYl96kxZmb+ sf+h98TX aiy6uFgxfHaSOwErmmMH1mdBU3kQs2R3YVX5+5Y6F6wEGZfRFwPLytMofiNBDg5zEJ3QWX08r9gyLs2LdFyKouMDua23R6GMdSOzIZH18ZpyCYr1INkQ1S0AxSdf3crP6uhsxIBd+lUorw7VMTxHRM0bX5V3RJRa7OCOPe5Jkf4toTwgzpneHfIQy32JochR3tJdMV2APpLdceCT7UeIesDn8C9yLl2TtqqWTvEgQ3+25FvTEfw8WH/toVaSjJq+aQ2u0NUg1DyknskhcrA31GSKaN0GNnMwHw9EH6dJM6X7nbS3evQFj0fjuWi7z6WovR/Fc7SVZ7q8yxYMlbbexjYM/3SHp2xQLrmqzd3dErWhWPDBv5Pf3Cooqw1oMkiXKY2R75xcA4EZ+OBv6UbV/OliOMA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 18, 2023 at 10:07:35AM +0800, zhaoyang.huang wrote: > Mirsad report bellow error which caused by stack_depot_init failed in kvcalloc. > Solve this by having stackdepot use stack_depot_early_init. [...] > diff --git a/mm/kmemleak.c b/mm/kmemleak.c > index 762b91f..ddc1ddf 100644 > --- a/mm/kmemleak.c > +++ b/mm/kmemleak.c > @@ -2070,8 +2070,10 @@ static int __init kmemleak_boot_config(char *str) > return -EINVAL; > if (strcmp(str, "off") == 0) > kmemleak_disable(); > - else if (strcmp(str, "on") == 0) > + else if (strcmp(str, "on") == 0) { > kmemleak_skip_disable = 1; > + stack_depot_want_early_init(); > + } Does this fix still work if kmemleak is default on and no option passed on the kernel command line? I thought we also need something like: diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 881c3f84e88a..80c69d026890 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -754,6 +754,7 @@ config DEBUG_KMEMLEAK select KALLSYMS select CRC32 select STACKDEPOT + select STACKDEPOT_ALWAYS_INIT if !DEBUG_KMEMLEAK_DEFAULT_OFF help Say Y here if you want to enable the memory leak detector. The memory allocation/freeing is traced in a way -- Catalin