From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3794C38159 for ; Wed, 18 Jan 2023 21:33:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 767B26B007B; Wed, 18 Jan 2023 16:33:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F0916B007D; Wed, 18 Jan 2023 16:33:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B83E6B007E; Wed, 18 Jan 2023 16:33:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4692F6B007B for ; Wed, 18 Jan 2023 16:33:45 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2162A80349 for ; Wed, 18 Jan 2023 21:33:45 +0000 (UTC) X-FDA: 80369222010.18.3234F14 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) by imf24.hostedemail.com (Postfix) with ESMTP id 962F5180009 for ; Wed, 18 Jan 2023 21:33:43 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=fe7L45tM; spf=none (imf24.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674077623; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2WuvGVVjPfhcIZhsbkz2EarT7sqqS33Y8zjJm+VJ7vM=; b=XyfXiPebm3H5kfKbJlP1zaiH5hYpaNoiRfsmfp+jT/ubFGXuLgXjH0329k65caXLNdaYQu Ag5cEoOL9ERODol5EceZyvyZd4B2CrlhQrt0GqPy7viOcqbZXneSfPb2itjEzPvQEA+6Ns Aoo3Hjc3TJEVgv/AijyHeiOyBytHkbo= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=fe7L45tM; spf=none (imf24.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674077623; a=rsa-sha256; cv=none; b=wrQXqupfGBE8Pu7md+QocVQFwlGtdRpyFkBSQ6HYDlVkYGGUspUrMhM2krtfKx51GOzS81 XpfGUuBeijrmUCsgKQS6L6YJ+vrnEYh3PM+x8WZ/hx/+MLwFYyIp7kL+wPHB8d9A6nLlrW pHvlgilkYqVCvbCH20k56Czqc7BXBpw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=2WuvGVVjPfhcIZhsbkz2EarT7sqqS33Y8zjJm+VJ7vM=; b=fe7L45tMENKiRxn7zi4tRhwwlq Ka5ppExwaE6DFwx/CqB0+37N0aLfxrGY/yR9SU+3bXUd3gORpegWv9nUm+2xC7bL4vmAzx5/INwtP Muh6AjDBr6uaZRUQp5hjyDiAfWKZJcRlsP90J26QDLBymCU0J5DZdzOH28NjQUaoo0Hp253JJ1gJB 9j3DtqzVyJoKWUQzVFGORlGKXga7hvqMNhnbJxggVrWAK1fcbnDifJY4WSVkls5Oqns7E+mEXLKJb kF6HRfCmp8w+gJBHWrYBaHDyf92WPI//I8sS7CAUUG6DlDpar9pHmO6O4wsyehqHizyo0hV2CQBk7 bElPFxdA==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux)) id 1pIG3o-002cgd-1s; Wed, 18 Jan 2023 21:33:32 +0000 Date: Wed, 18 Jan 2023 21:33:32 +0000 From: Al Viro To: Christoph Hellwig Cc: Andrew Morton , Mark Fasheh , Joel Becker , Joseph Qi , Evgeniy Dushistov , "Matthew Wilcox (Oracle)" , ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: remove most callers of write_one_page v3 Message-ID: References: <20230118173027.294869-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 962F5180009 X-Stat-Signature: etome336xzpmb5n3tx48w8yx3sjdr711 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1674077623-932341 X-HE-Meta: U2FsdGVkX1+TqMV4mcXCowgcPtR08/mypW9mIsVZ4nw5JJJmNDYfGSyXbvPr9YguhbgFuEL/Xr13cJHG0GyetGRUHoCgZy0gk3EwI/fm/79U3r/kq6XQt03lVJ9t0wE9/LbbF8Fksr6b9mfllG+fujGAALUU/1DLPqqUuYC6M8m7OOrCbpdsiDfSc9eG3tLs1FvfIpaR6XKUvKfCOMwqC8SvaH5VNJR4rxkqJ8jJNg8O/GNTILfupUVvzXfJwU20iaYmtX9dUn0y69x28XP+v1nOp+nrdDpz2reMdDAHl7dxJ60uteGFNklq3EVhXgemibkXEJpmRbbwPrXGUty9QMnP0iAVhspzpxRSwYKHnf4pbMTUirmxsmlie8wWQPzCi2nKPkZBnDLB8Lxd5iSMG2iucEz7CNOJfq33Z9DJZo4Cb8tDGGYCabzkZh7QzBkHyI4NS5btXNfYWVlEvVOKTPs4uCWTHxm8ZJFL2GUgJXCjexFve80fCq2Qaa7bw/iGaU/U5gKstKtAaYtfSl6G1c4RZwUKyd/9i5jRbCaY6td6B7e/C22tZ/r7uaBeHFjOejqxhLMfhBme4H1ko/FbDZb3GbE9vQ9ngR0b7EsXjF4OxugcREc4dH/X02weJbhAEh29iEOoXWs7DwhKRmAdB1CCGCsnVXDZU2C8aMftUoW8D1vH4a+EPliOlVphK6SmEZZHMPx0yh2YL/n17x5siDpBtOm8NULCmFS5o/xqELuBhbdcvEMRmB0UbzwG+Uns/PI+FwmE1JOdTCVHRdhxNmSOKO0Q+3oX+BLtYn4EoCDmKCqkDNMdEapWBLoE1FtAsukmG7ydrpYwWpxt1dEayOAwAhe3iXsTi9zW50gdNgDsjegOGi3cdjMAQf1SjrnVR3X2Jvvw2JzOZNcBwDt2rvJoiuAyztCkKwAooxVfxV29/KJR46VsB4jrYfoEIVsv/saeV6wQUZqOMuFom5L 6XzuJn5r BPVPLij9n+MOJIHojfFSK+CkyBWOtJNgSttk1d+e9iE7gcRfHxYO97GTiPLzkdDG2B4yih8Oqw9WP1gLyEFIes5eSNXWZXNI4/TcgGlXAfET7hTJPtoIC+odNTBxpoy9Wd9Goap2qwjilimI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 18, 2023 at 09:23:37PM +0000, Al Viro wrote: > On Wed, Jan 18, 2023 at 06:30:20PM +0100, Christoph Hellwig wrote: > > Hi all, > > > > this series removes most users of the write_one_page API. These helpers > > internally call ->writepage which we are gradually removing from the > > kernel. > > > > Changes since v2: > > - more minix error handling fixes > > > > Changes since v1: > > - drop the btrfs changes (queue up in the btrfs tree) > > - drop the finaly move to jfs (can't be done without the btrfs patches) > > - fix the existing minix code to properly propagate errors > > Grabbed. I'll split that into per-fs branches (and synchronize wrt > fixes), fold the kmap_local stuff into that and push out. BTW, do you have the check for minix_delete_entry() failure when called from minix_rename() anywhere in your tree? I don't see that in this series; I'm adding the trivial fix, hopefully that won't end up creating conflicts...