From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A86E4C32793 for ; Wed, 18 Jan 2023 21:34:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 481036B007D; Wed, 18 Jan 2023 16:34:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 409F86B007E; Wed, 18 Jan 2023 16:34:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 25CE86B0080; Wed, 18 Jan 2023 16:34:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 13E126B007D for ; Wed, 18 Jan 2023 16:34:00 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E1A781C6207 for ; Wed, 18 Jan 2023 21:33:59 +0000 (UTC) X-FDA: 80369222598.25.3371AC2 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf03.hostedemail.com (Postfix) with ESMTP id 4540220010 for ; Wed, 18 Jan 2023 21:33:58 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=jClde1sv; spf=pass (imf03.hostedemail.com: domain of seanjc@google.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=seanjc@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674077638; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PV2LLjcXwxGB4uAP0cXtlo+9pb6/lAlmJvlfTFPpKO0=; b=ZVdJSQWBYNfVHXUJaFxJak6jHiieJnXkxBsHBOpgQ+3C5Is/BQIO9UCAF24tXHr+Ghor+F rDXRnb0nrjZ5jYuW0uowiRKJcrlxve98Ecu8zkx3qfujI6wexw5x2N8c94teZiKZo9Jzvt DH6Tpnu2w0kzn1DZ5Epm9dKbV8+Lc8o= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=jClde1sv; spf=pass (imf03.hostedemail.com: domain of seanjc@google.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=seanjc@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674077638; a=rsa-sha256; cv=none; b=Eq8Vvj1qm9htroH9/LlvMlAevrkO02vplC8rwbSh81ica1ooOyQij7rJAia56Wd1gum4HC DdA1bpxO/KzP6bo/gZ4WcJvVr9hr4vrdDDQDj/J+tQubH5/y4G/GgMWXlDFXvwReRbQ6np Ujj6W57s3LG2+ZFMfLZjq0ZoIZMlfkQ= Received: by mail-pl1-f180.google.com with SMTP id y1so415515plb.2 for ; Wed, 18 Jan 2023 13:33:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=PV2LLjcXwxGB4uAP0cXtlo+9pb6/lAlmJvlfTFPpKO0=; b=jClde1svtNxzd4S5YpqLYxhB5hDETtoHp4f98weH3OKDzKvrFMdPXPDW7GNYj7KzP6 IAOODq4osxaWdKQIztfYn6p2PEETi9Y1foDc5Ho2m99IAPDykVHkiV9eYhri8cSRdTEv DTK03VrwpCnS5yMQMMdo1V+JcDVvnecZFy89o5zutgd2dl7qtn61gSYxGYCee3FLvM3S fjQUJoP0iuKFTPBXimR1s1PnYwovsVdbLYRXH7Ajxn3nqSIkvOEVj1vb5nTCH3f9l6kn v8htsXGKXcijvhSlD1M+mnlUEbO/WCI2btqI+QRP4Li157TCJGwuDw38TzYaJwNng0F5 6Wog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PV2LLjcXwxGB4uAP0cXtlo+9pb6/lAlmJvlfTFPpKO0=; b=Y/1fe3xZ+BjLEI9DmbR9syGN1zXvgOxy6sz0F2IilIlrPFQ0K7ZtgADxI/BQ/eVrlI xygRYtgAj3LcdwJAvYlrdWcdhWpq8749Ws99nuH5N1U+FmsIlAhdjRKLDP0wMGA4vEas nIgWAslYQ1uXeH5+P5GEAEr1Pqlna3xln2Q/hu55WoY6POOR2XgjLhLmDkZ8gB8B15Jk Znh9PlZC+Ekj9pn76CoSEnil9Eovf+wuVnpXA+tFZxceLy0gvmGZ7qkhzqR4SKVyLRu+ vu9KbGyaWomyo+8opcoaz1kod7kHL6svoQw86DnQOwz5rB/CFBqBWvQCWg6M8Xvj/Vzx MQrA== X-Gm-Message-State: AFqh2krZ5P/dBLZz0zIqfX83pFxPuU1JVg46kqaq2w/C+je+2WI9d84o wDZgRmrY9v2NgzthDUJ8GREaQA== X-Google-Smtp-Source: AMrXdXtmY68VQO8PeJqA2jW7tlmH+eNNquVAK7kXYpjOhcdoxIkG+SuufwVgmp4Q8YuAFk9vvmEUBQ== X-Received: by 2002:a17:90a:fd12:b0:226:5758:a57f with SMTP id cv18-20020a17090afd1200b002265758a57fmr3340532pjb.2.1674077636822; Wed, 18 Jan 2023 13:33:56 -0800 (PST) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id 8-20020a631448000000b004b25a51d6f4sm16484941pgu.36.2023.01.18.13.33.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Jan 2023 13:33:56 -0800 (PST) Date: Wed, 18 Jan 2023 21:33:52 +0000 From: Sean Christopherson To: "Huang, Kai" Cc: "kvm@vger.kernel.org" , "michael.roth@amd.com" , "tglx@linutronix.de" , "tobin@ibm.com" , "srinivas.pandruvada@linux.intel.com" , "Luck, Tony" , "jmattson@google.com" , "Lutomirski, Andy" , "ak@linux.intel.com" , "pbonzini@redhat.com" , "pgonda@google.com" , "rientjes@google.com" , "slp@redhat.com" , "dovmurik@linux.ibm.com" , "alpergun@google.com" , "peterz@infradead.org" , "linux-kernel@vger.kernel.org" , "thomas.lendacky@amd.com" , "harald@profian.com" , "x86@kernel.org" , "bp@alien8.de" , "dgilbert@redhat.com" , "vkuznets@redhat.com" , "marcorr@google.com" , "vbabka@suse.cz" , "ashish.kalra@amd.com" , "nikunj@amd.com" , "linux-coco@lists.linux.dev" , "wanpengli@tencent.com" , "Rodel, Jorg" , "mingo@redhat.com" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "hpa@zytor.com" , "kirill@shutemov.name" , "jarkko@kernel.org" , "ardb@kernel.org" , "linux-crypto@vger.kernel.org" , "linux-mm@kvack.org" , "dave.hansen@linux.intel.com" Subject: Re: [PATCH RFC v7 03/64] KVM: SVM: Advertise private memory support to KVM Message-ID: References: <20221214194056.161492-1-michael.roth@amd.com> <20221214194056.161492-4-michael.roth@amd.com> <4e75a1a0b67e7b3ccaf6b140b08a5f2080aedbdb.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4e75a1a0b67e7b3ccaf6b140b08a5f2080aedbdb.camel@intel.com> X-Rspamd-Queue-Id: 4540220010 X-Stat-Signature: pj7dqywftjmjh6cz681cn55s1z18jojq X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1674077638-913372 X-HE-Meta: U2FsdGVkX1/NVoYDPbvXpmEo7hkqRVHX7foAGR9vrF3V088CHB24QDjNzHOawPuCUXQQtWNtF7D173AuxqOrm4mSsBJ88BHnkZ8wnb9jCuUOvhF6O+g+edAy4ZVvOk9SzzVdtaHd48q4SoCHbtNMAnZq7qFJ+5buFUYMZwSAKt40tMDZt+UW0zqZeKfS9bHyUGfFycNxOWhQ3ZAEx7XYvSLGyR2Ins5m98cD6q/844YTHLU+6hAfncoHdkwmCso1aFnaYheSjiUK0O6Is29Qn7Vb2kuVCDqyIHfsXys3PLSdc7ipld0rNQcRgf9G5bPHpVLVd7VFGZWKsBv830Fpa7wnX1mOXRmNe5PwSym8x7v17FEcWpxDj5wg4aXkuSY0/ZbQ0oaigWx3ZIBTGtdaEUREXX2jA7jeaTdoZ0Abnudjh6/yFTYORhydqjeIQ/G0RCt+88/GEvlWNnIRQRKsCcr99aMVR3lI5XNOuAInRFli3yRiWmBpeoUQyI3vFuRpDhpxXAOBJ+t26UgyoQhRQKGcYYPEXU/cf1106zJZqYgZ+xpzHCDmR/XuH8QjpyrS9AVRdAPMPNJq7V6v5M55/qRV7DUyENWsNGZPF6UdHJuAGwa95MqXcxiyMwfUIQODHVRbHvwotp4i0MRpe/xtSZagE6GEQOBeDzVrRac74KDgi6eWEDSopeek8/QIoRPUcWNsbuBYWhFTuHItQ/5iRKWMKkEOUhopevzdQqkOzYrNuP/rtQTjnuaP+rgJ/xP/w3Tyfan70gcswzuGONZaStf1itEujso5zP4J0hTKiNQDKj94Gez6o+P+BGWi9C1oz0VHgHR3okTYTFH8VQoylMjwM+ULzCbQ3Y6IWH/omdkkdmi0CutghmceoY1GHg8hYXAfRUKrYJH8lLcrPNhiB2yGsGY4B1XCu3YQcU+ZSjgcEEos6+su8Z1fnowpo2wmLF926vQyzOJ0ALL4Zbp lhiRjfGv SMLcw1rfMjpygXup4tK+bFbonEZkug4ifE2maZX9H67SHsajweC1LfEW65hT8Y9C1Dz8hm+tbuoy+Jhp/0FcVf9DhvpJ7rRIn5tf+9c8iakepJeGJemMw00zLmmfmGx2+RK5W1J3a2C/tIfs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 18, 2023, Huang, Kai wrote: > On Wed, 2022-12-14 at 13:39 -0600, Michael Roth wrote: > > diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c > > index 91352d692845..7f3e4d91c0c6 100644 > > --- a/arch/x86/kvm/svm/svm.c > > +++ b/arch/x86/kvm/svm/svm.c > > @@ -4694,6 +4694,14 @@ static int svm_vm_init(struct kvm *kvm) > > return 0; > > } > > > > +static int svm_private_mem_enabled(struct kvm *kvm) > > +{ > > + if (sev_guest(kvm)) > > + return kvm->arch.upm_mode ? 1 : 0; > > + > > + return IS_ENABLED(CONFIG_HAVE_KVM_PRIVATE_MEM_TESTING) ? 1 : 0; > > +} > > + > > Is this new callback really needed? Probably not. For anything in this series that gets within spitting distance of CONFIG_HAVE_KVM_PRIVATE_MEM_TESTING, my recommendation is to make a mental note but otherwise ignore things like this for now. I suspect it will be much, much more efficient to sort all of this out when I smush UPM+SNP+TDX together in a few weeks.