From: Mike Rapoport <rppt@kernel.org>
To: Colin Ian King <colin.i.king@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] mm/secretmem: remove redundant initiialization of pointer file
Date: Thu, 19 Jan 2023 11:45:32 +0200 [thread overview]
Message-ID: <Y8kRPPTpL5J85YXW@kernel.org> (raw)
In-Reply-To: <20230116164332.79500-1-colin.i.king@gmail.com>
On Mon, Jan 16, 2023 at 04:43:32PM +0000, Colin Ian King wrote:
> The pointer file is being initialized with a value that is never read, it
> is being re-assigned later on. Clean up code by removing the redundant
> initialization.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: Mike Rapoport (IBM) <rppt@kernel.org>
> ---
> mm/secretmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/secretmem.c b/mm/secretmem.c
> index 04c3ac9448a1..be3fff86ba00 100644
> --- a/mm/secretmem.c
> +++ b/mm/secretmem.c
> @@ -190,7 +190,7 @@ static struct vfsmount *secretmem_mnt;
>
> static struct file *secretmem_file_create(unsigned long flags)
> {
> - struct file *file = ERR_PTR(-ENOMEM);
> + struct file *file;
> struct inode *inode;
> const char *anon_name = "[secretmem]";
> const struct qstr qname = QSTR_INIT(anon_name, strlen(anon_name));
> --
> 2.30.2
>
>
--
Sincerely yours,
Mike.
prev parent reply other threads:[~2023-01-19 9:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 16:43 [PATCH][next] mm/secretmem: remove redundant initiialization of pointer file Colin Ian King
2023-01-19 9:45 ` Mike Rapoport [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8kRPPTpL5J85YXW@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=colin.i.king@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).