From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B1EDC00A5A for ; Thu, 19 Jan 2023 09:45:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D4C756B0072; Thu, 19 Jan 2023 04:45:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CD3396B0073; Thu, 19 Jan 2023 04:45:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AFEE46B0074; Thu, 19 Jan 2023 04:45:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9CF096B0072 for ; Thu, 19 Jan 2023 04:45:48 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 70A91140289 for ; Thu, 19 Jan 2023 09:45:48 +0000 (UTC) X-FDA: 80371066776.21.20EA192 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf11.hostedemail.com (Postfix) with ESMTP id D062340011 for ; Thu, 19 Jan 2023 09:45:46 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UhVKbhG9; spf=pass (imf11.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674121547; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NUOdLYfhVwQxn3v5YfuRt5Gk8JyBqA3GAEkUxr+q0f0=; b=trPBejh92CW7D3Q3O2DKn6I58kfPLJpaUxClp7t6UWhPFi6AgdcsQaO1GAPgDzSK/NDVw1 h5ygMkxCiRlbn++dZlN6IIyFYChUllGStF24HBNH+Jo+Eq8+FSakqbyOE4V8o5wYhWol7b /1JDngQjHQ4O+UU1x4U2qi1lvEw5k1w= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UhVKbhG9; spf=pass (imf11.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674121547; a=rsa-sha256; cv=none; b=FmDbgn1Uo/XVp9dshNXWrAALKgDHRg2xkbe/KD1rF6MTsrkDysQich2miPcUkPmMydbl7v JLZn7Jjia57qKUk1iRbI3B3Tt6KIZ/CzTZYT6i/iSVqhyAnwXgjl03nxE4CCObnksl5y6C AEpa3mnSX3/2Sbp3ZDBVHDV9wNKCyfc= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4FBE2B81FBD; Thu, 19 Jan 2023 09:45:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 658ACC433EF; Thu, 19 Jan 2023 09:45:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674121544; bh=86dQPWFpAB2B9o/b+NLqYzvxFFkIRRnlhWeIPtazXf0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UhVKbhG9GbPkFYGVE7fEp/J673sYlchRWnirLbLe8U+O7t6Ex16OrAUIDFU2wAYqb Emq/x6VUHonZ2HZmWCWRGK3cOOgelbDaK04yHnKrGsgIoZ6DUjxNNcsED3ahbus0KI jxLzHZu4MhTNYF/pHzvyRmnR221q5mXXuJFW3UIU3kfFZoZRdBDimkoOtl/gVgJ3Wi b6o4AeFP0LQxIOgRUg9qQhPsz/cv+1szFySI3cKZTEQdN2IYNi0J01S1VF5qVLJKr5 gCgrZCoGBOpQqEfQI8NtxuAhBGrgoJ+Ze+PZYYEmhO8oo/0+OClE/Hazm+BruBJzEC EbvZmwDCioOBg== Date: Thu, 19 Jan 2023 11:45:32 +0200 From: Mike Rapoport To: Colin Ian King Cc: Andrew Morton , linux-mm@kvack.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] mm/secretmem: remove redundant initiialization of pointer file Message-ID: References: <20230116164332.79500-1-colin.i.king@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230116164332.79500-1-colin.i.king@gmail.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: D062340011 X-Rspam-User: X-Stat-Signature: m5h6x117umbw4uod8pdnzuityjskuq7w X-HE-Tag: 1674121546-23522 X-HE-Meta: U2FsdGVkX1/YoZpd9CTHoAbh/hTPJdI+5CQcJ7rFJOhWCLE3pbiTG6LaEsoJTgEKyAp4VKFyI+0cJ1hEokkXupOmbopA6gTZOHa3qc32CPWNCwieZ8vjkZPKLIdF/rSehwxgo2weF0BY6ZR1KPFsiytqh1Mb3dOb9kzQEpa1MUsYr3ff0QC1jYdhLvmpO3HHIQ6NMJDnzFmUxepbFqqzWwLWYg5pgQrDVfy7gqtmY3xsYT35+YxbyOIp6nu83SAmAmuqKOlreNgING6i6Kpwv/df0NjK0Yb133x64gB9IQU8Dj1mlh7zNXgKNdB42fFppl0Pkjt6EOU5/yU3sM9dPkd4mOmjrz8V7fmYz4YxFollSL8/5rEyWfclCaMS14wNNYOzu2mVT1UlarqAT5WIHhkpunW4xjRtbYATJfpxQGIHC5Qt3BB3h8+DbT6issc+1d03xTwz/bXxLRSMOwcu+BZ/m5SDzWUOm9vAoVQ4atNGwGluiPGbb76jVwQZm5MIMve138fV6QkCtlS2JHmz8dKJy+6QQtsyGCGElQEAUzPSUhgiXV5XScjwVKOX5X1BjpyiEgo4oz5JsuYAw0UcJcpPpOhvktFPoZyqZuy0iFPRYE83OJNa4nTwxXFdHfuz75cHJTBW0CwjRI+8LgPBDWSwaNC9d3US5wCWvOa0wnU5LDK/ToJ9wt8FFQZjLq1Y1lfjGakoQdrOwBle/ZFSZfMIa0uD7R5xPhn8XDaP9gD5J7S1VKaP1jfP0936/c2rft7oxWo88BhJxDhbUKsRgzaitT/EtWRzlgDu26CslwyVUzx9fuTzkLLdiIho0XfUNMLfzgdNI/JBeBalTprNcI15iHEwznec5ZkW3ioD1CXUT/DuF1LGqjJ5qZvbzXJafLwwHXxu6mHnkBz0VZv1T7i/xNXjGnhnSRRMhSkjl/RrF8IN3qqniT0Vn6DX53k+P++azW7QXaFrRRsjppL yMdXk762 u9XXOtn6HHBn23RovKaJkmVIYu1DWWTzch5+LUtAd5cLyO8OGmtZvqjdbcPxGHU40KqvtqilFsv6AQMAnGHnqgfl9oLB9te/HdE1T X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 16, 2023 at 04:43:32PM +0000, Colin Ian King wrote: > The pointer file is being initialized with a value that is never read, it > is being re-assigned later on. Clean up code by removing the redundant > initialization. > > Signed-off-by: Colin Ian King Reviewed-by: Mike Rapoport (IBM) > --- > mm/secretmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/secretmem.c b/mm/secretmem.c > index 04c3ac9448a1..be3fff86ba00 100644 > --- a/mm/secretmem.c > +++ b/mm/secretmem.c > @@ -190,7 +190,7 @@ static struct vfsmount *secretmem_mnt; > > static struct file *secretmem_file_create(unsigned long flags) > { > - struct file *file = ERR_PTR(-ENOMEM); > + struct file *file; > struct inode *inode; > const char *anon_name = "[secretmem]"; > const struct qstr qname = QSTR_INIT(anon_name, strlen(anon_name)); > -- > 2.30.2 > > -- Sincerely yours, Mike.